After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 513776 - Selected effects GConf key values are not standard
Selected effects GConf key values are not standard
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-02-01 21:19 UTC by Luca Ferretti
Modified: 2008-08-07 12:17 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Luca Ferretti 2008-02-01 21:19:10 UTC
Currently the description for selected_effetcs GConf key is:

Effects, that are applied on startup. Possible values are: Mauve, Noir/Blanc, Saturation, Hulk, Vertical Flip, Horizontal Flip, Shagadelic, Vertigo, Edge, Dice and Warp

It should be, instead something like:

A list of effects applied on startup. Possible values are: "mauve", "noir-blanc", "saturation", "hulk", "vertical-flip", "horizontal-flip", "shagadelic", "vertigo", "edge", "dice" and "warp".

Unfortunately I think this change will require a code change too, to parse the new strings...
Comment 1 Luca Ferretti 2008-02-01 21:22:46 UTC
OT: about other GConf keys, IMHO could be better use:

* Use countdown
* Set to True to show countdown when taking a photo.

* Webcam device
* The device which points to the webcam (e.g. /dev/video0).

* Selected effects

OK to apply those changes?
Comment 2 Jaap A. Haitsma 2008-02-01 23:04:18 UTC
Fine by me. 
Comment 3 daniel g. siegel 2008-02-02 00:14:27 UTC
fine by me too. i dont think the effect gconf setting should be that much work: just add the gconf-name to the effects array and use that when storing/reading from gconf.
Comment 4 daniel g. siegel 2008-02-19 14:45:49 UTC
luca, please paste your patch here and we will commit it for you, if you arent able to do it

thanks!
Comment 5 Luca Ferretti 2008-02-28 15:36:01 UTC
Daniel, we are in string freeze, so I think this should be delayed to GNOME 2.24
Comment 6 daniel g. siegel 2008-03-12 14:38:18 UTC
luca, trunk is now open for devlopment, please commit your patch
Comment 7 Luca Ferretti 2008-03-12 15:12:55 UTC
I've not patches by now.. Be patient and let me finish the Italian translation of GNOME :-)
Comment 8 daniel g. siegel 2008-03-12 16:31:15 UTC
hey, you have 6months time ;)
Comment 9 daniel g. siegel 2008-08-07 12:17:18 UTC
fixed in trunk