After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 513628 - [flacdec] Decoding of PICTURE blocks is always disabled by bad ifdef
[flacdec] Decoding of PICTURE blocks is always disabled by bad ifdef
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-01 07:08 UTC by John Millikin
Modified: 2008-02-02 19:49 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Compile PICTURE block support if LEGACY_FLAC is not defined (2.30 KB, patch)
2008-02-01 07:09 UTC, John Millikin 		committed Details | Review

Description John Millikin 2008-02-01 07:08:45 UTC 
Please describe the problem:
In gstflacdec.c, decoding of PICTURE blocks is guarded against compilation with old FLAC libraries using an #ifdef. However, the #ifdef checks against the always-absent define FLAC__METADATA_TYPE_PICTURE (which is actually an enum value). Instead, it should use the LEGACY_FLAC macro defined in gstflacdec.h.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 John Millikin 2008-02-01 07:09:15 UTC 
Created attachment 104169 [details] [review]
Compile PICTURE block support if LEGACY_FLAC is not defined
Comment 2 Tim-Philipp Müller 2008-02-02 19:49:38 UTC 
Oops, sorry about that.

 2008-02-02  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: John Millikin <jmillikin at gmail dot com>

        * ext/flac/gstflacdec.c: (gst_flac_dec_scan_for_last_block),
          (gst_flac_extract_picture_buffer), (gst_flac_dec_metadata_callback):
          Fix extraction of picture blocks with newer libflac versions again:
          FLAC__METADATA_TYPE_PICTURE is an enum, not a define (#513628).