GNOME Bugzilla – Bug 513557
New standard playing cards for gnome-games
Last modified: 2012-01-31 23:13:42 UTC
Hello, I'd like to suggest three versions of gnomangelo as a new standard deck in gnome-games. (Or if you want to for gnome-games-extra-data). As Christian noted [1] the colors of an earlier version [2] might seem a bit light (2. below). So I'll attach the following versions of gnomangelo_bitmap: 1. Original colors 2. Tango palette on white cards 3. Tango palette on white cards and (real) black for symbols etc. Aike [1] http://mail.gnome.org/archives/games-list/2008-January/msg00051.html [2] http://mail.gnome.org/archives/games-list/2008-January/msg00044.html
Created attachment 104142 [details] anglo gnomangelo_bitmap.svg 1. Original colors
Created attachment 104143 [details] tangowhite gnomangelo_bitmap.svg 2. Tango palette on white cards
Created attachment 104144 [details] tangoblackwhite gnomangelo_bitmap.svg 3. Tango palette on white cards and (real) black for symbols etc.
I'm all for accepting one of the cards you attached here as the new default for Aisleriot, as soon as possible. It is a huge improvement over the current 'bonded'.
Should we replace Bonded with one of these, or add it in stead of Bonded ?
If we are going to use one of the new cards as default I would prefer we replace bonded. Bonded would of course be moved to -extra-data. I prefer gnomangelo over bonded due to the prettier faces. And I prefer the tango version because it will make aisleriot blend more in with the GNOME desktop. I'm somewhat colorblind myself so I don't have strong feelings about the specific colors. I do however feel that we should use the tango palette where possible to make GNOME look integrated.
Hmm. What I was asking was, rather, should we _name_ the new theme Bonded again? The issue to consider is how settings from a previous version will apply in the new version. If the user has never changed the card theme, the default gconf value will apply; we can just change the schema for this and the user will get the new default value. If the user has ever changed the theme, but then changed back to Bonded, then gconf will get us Bonded instead of the default value...
It seems OK to name the new theme Bonded, if this is the only way to enable the new card theme for users who are upgrading. However, I think the ideal solution would be to name the new card theme Gnomangelo to distinguish it from the old theme, and simply update the schema with the new default during upgrade.
I suggest, you do not name the new card theme "bonded". This name is associated with the look of the current standard deck. As a user I'd be puzzled if the name means something different. I can think of the following possibilities: a) If a user didn't change the defaults, the new cards are used. b) If a user changed the default theme to bonded and bonded is not installed, the new default is used. IMHO that's ok. ("Failed to load theme 'bonded'; trying fallback theme 'gnomangelo'") c) If a user changed the default theme to bonded and bonded is somehow installed, bonded is used. That's ok. We can not guess why the user changed to bonded. Maybe he just likes those cards. And after all he already knows how to change the card theme. Maybe you can even use a name that makes it clear that the user selected the standard deck like e.g. "default". You could also create a link from gnomangelo.svg to default.svg. Aike
Ok, we'll change the schema default. Which one of the variant should we use? I'm for either variant 1 or variant 3; variant 2 looks too pale to me.
I like variant 3. Remember to update both Aisleriot and blackjack.
Christian, will you do the honour to commit the new cards to Aisleriot and Blackjack before the next release?
Done, using variant 3.
There was only one of two needed votes to break the UI freeze for this. I had to revert the change to make the 2.21.91 release. I'll see if we can get the approval for the 2.21.92 release. Otherwise we will have to postpone this until 2.23 Also we should remember to update the screenshots in the documentation with the new cards.
You didn't add the bonded.svg back... at least I don't see anything in svn for that...
odd. I don't seem to have an svn commit mail about that. Do you know any easy way to do this?
I don't understand what you mean... You changed blackjack and half of aisleriot back to the old card theme, but didn't change games-card.h or added bonded.svg back to svn. There's only gnomangelo_bitmap.svg in svn.
I added bonded.svg back to svn and fixed games-card.h. That should complete the reversal of the change. I did the original change thinking that comment 12 was the go-ahead from the maintainers...
Sorry for the confusion. I had a patch for games-card.h and Makefile.am in libgames-support ready. What i meant was if you knew of a way to restore bonded.svg? Is there some way to restore a deleted file? svn diff -r7326:7325 didn't help me :( I'm truly sorry about the extra work. Thank you for helping getting this solved.
I simply copied the file from gnome-games-extra-data, and svn added it :)
ahh, clever :)
Any chance that the new cards can be committed for Aisleriot now? :-)
Fixed again in svn trunk. * configure.in: Add --with-default-card-theme. Bug #513557. * Makefile.am: R bonded.svg: * games-card.h: Change default card theme. Bug #513557. * aisleriot.schemas.in: Change default to "" which indicates the default theme. * window.c: (aisleriot_window_init): Use the default theme for empty pref string. Bug #513557. * data/blackjack.schemas.in: Use "" for the default theme. * src/blackjack.cpp: Use the default theme for empty pref string. Bug #513557.
Just for further reference, http://mail.gnome.org/archives/games-list/2008-January/msg00020.html says the licence is GPL2 like the Bonded theme.
As far as I can see the bonded theme was under the same license as Gnome Games and was not restricted to a specific version of the GNU GPL. I put gnomangelo.svg under the same license as Gnome Games, which is the GNU GPL without a specified version number. (from README-file: "This is the GNU General Public License and it can be found in the file COPYING.")
Ok, so you're saying it's "GPL 2, or (at your option), any later version", just like the rest of GNOME Games? Thanks for the clarification! :)
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component. Apologies for the mass email!