GNOME Bugzilla – Bug 513301
drivel doesn't compile against libsoup 2.4
Last modified: 2009-07-12 19:07:19 UTC
But I'm working on it...
Created attachment 105058 [details] [review] lame patch for libsoup 2.4 support OK, here's a lame patch for libsoup 2.4 support. "Lame" because rather than porting to the new libsoup 2.4 XML-RPC API, I just imported the libsoup 2.2 soup-xmlrpc-message/response code into drivel... I was originally planning to actually port it, but this turned out to be a little bit tricky in places (particularly blog_lj.c, which is organized around the idea that it can build half of an XML-RPC message, then pass it to send_getchallenge_request(), and then finish building it later). And then, while I was trying to figure out the best fix, I noticed that drivel hadn't really been hacked on all that much for a little over a year, so I wasn't sure if it was still being actively developed, so I didn't want to spend a lot of time porting it if no one really cared any more. So anyway, this patch makes it compile with libsoup 2.4, and if anyone does want to keep hacking on it now or in the future, they could port it to the new xmlrpc api at that point.
I should mention that the patch is totally untested, since I don't have all the various different kind of blog accounts to test it against...
This only relates to the 2.1 code in trunk/ - we're currently working on synchronising the 2.0.3 and 2.0.4 branches.
I've updated the patch a bit - a few offsets and a fix for a MoveableType crash. I'll do some testing with trunk/ and go from there.
Testing fails, I can't use the patched drivel to login. Entity: line 91: parser error : Opening and ending tag mismatch: p line 91 and form nput type='submit' name="submit" value="Create a Journal" class="start" /></form ^ Entity: line 92: parser error : Opening and ending tag mismatch: form line 91 and div ef='http://www.livejournal.com/login.bml'>Already a member? Sign In</a></p></div ^ namespace error : Namespace prefix lj for user on span is not defined lass='user'><span class='ljuser' lj:user='montreal' style='white-space: nowrap;' ^ namespace error : Namespace prefix lj for user on span is not defined class='user'><span class='ljuser' lj:user='4_eyez' style='white-space: nowrap;' ^ namespace error : Namespace prefix lj for user on span is not defined 'user'><span class='ljuser' lj:user='lj_volunteers' style='white-space: nowrap;' ^ namespace error : Namespace prefix lj for user on span is not defined more at <span class='ljuser' lj:user='lj_spotlight' style='white-space: nowrap;' ^ Entity: line 148: parser error : Opening and ending tag mismatch: img line 147 and A width="300" height="250" border="0" alt=""></A> ^ Entity: line 149: parser error : Opening and ending tag mismatch: A line 146 and NOSCRIPT </NOSCRIPT> ^ Entity: line 150: parser error : Opening and ending tag mismatch: NOSCRIPT line 145 and div </div></div></div></div></div></div></div></div><div class='homepage-promo'><div ^ Entity: line 151: parser error : Entity 'raquo' not defined J. <br /><a href='http://www.livejournal.com/update.bml'>update journal » ^ Entity: line 151: parser error : Entity 'raquo' not defined /www.blurb.com/partner/livejournal' target='_blank'>Let the books begin! » ^ Entity: line 151: parser error : Entity 'nbsp' not defined blog scene and reports back with the highlights.</p></td><td width='50%'> ^ Entity: line 214: parser error : EntityRef: expecting ';' <li><a href="https://www.spreadshirt.com/shop.php?sid=121380&op ^ Entity: line 214: parser error : EntityRef: expecting ';' <li><a href="https://www.spreadshirt.com/shop.php?sid=121380&op=articles&p ^ Entity: line 269: parser error : Entity 'raquo' not defined <p class="more_lj"><a href="http://www.livejournal.com/site/">» ^ Entity: line 273: parser error : Entity 'copy' not defined <div id="footer-copyright">Copyright © 1999-2009 LiveJournal, I ^ Entity: line 293: parser error : xmlParseEntityRef: no name id='NavMenuItem6'><a href='http://www.livejournal.com/news-and-politics/'>News & ^ Entity: line 352: parser error : Entity 'bull' not defined <a href="http://www.livejournal.com/manage/settings/?cat=display">English • ^ Entity: line 352: parser error : Entity 'bull' not defined www.livejournal.com/manage/settings/?cat=display">English • Español • ^ Entity: line 352: parser error : Entity 'bull' not defined .com/manage/settings/?cat=display">English • Español • Deutsch • ^ Entity: line 352: parser error : Entity 'hellip' not defined at=display">English • Español • Deutsch • Русский… ^ Entity: line 371: parser error : Entity 'nbsp' not defined <div id='Alpha' style='display: none !important'> </div> ^ Entity: line 376: parser error : Opening and ending tag mismatch: div line 62 and body </body> ^ Entity: line 377: parser error : Opening and ending tag mismatch: div line 61 and html </html> ^ Entity: line 379: parser error : Premature end of data in tag body line 60 ^ Entity: line 379: parser error : Premature end of data in tag html line 3 ^ (drivel:23075): Gdk-CRITICAL **: gdk_x11_atom_to_xatom_for_display: assertion `atom != GDK_NONE' failed
Oops, my fault - incomplete testing. The livejournal test fails with SVN trunk/, with libsoup2.2 or libsoup2.4 (using this patch) in the same way. A Moveable type test works with libsoup2.2 and with the libsoup2.4 patch, albeit with messages to the console, mostly related to egg. There is more going on here than just libsoup2.2 to libsoup2.4. I'm going to commit the libsoup2.4 patch and fix the other problems as fixes for the other bugs.