After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 512847 - Flat review is quite broken in OpenOffice and Firefox
Flat review is quite broken in OpenOffice and Firefox
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other All
: High critical
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-29 17:26 UTC by Mike Pedersen
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
proposed patch (570 bytes, patch)
2008-01-29 17:50 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Mike Pedersen 2008-01-29 17:26:00 UTC 
Open writer or calk so that you just have a blank document.  At this point try any flat review command.  Notice that nothing happens.  
You can also reproduce this while trying to create a presentation in impress.  
In any of these situations one should be able to review the application.
Comment 1 Willie Walker 2008-01-29 17:30:55 UTC 
Thanks Mike!  Which version of OOo are you using?
Comment 2 Mike Pedersen 2008-01-29 17:36:33 UTC 
Sorry about that.  It's the 2.3 in gutsy.  I'm of course using orca trunk.
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-01-29 17:50:09 UTC 
Created attachment 103971 [details] [review]
proposed patch

In the interesting coincidences department, I was told that flat review was broken in Firefox as well so looking into that was on my list for today.

Mike does this fix it for you?
Comment 4 Willie Walker 2008-01-29 18:11:35 UTC 
(In reply to comment #3)
> Created an attachment (id=103971) [edit]
> proposed patch
> 
> In the interesting coincidences department, I was told that flat review was
> broken in Firefox as well so looking into that was on my list for today.

I think this looks fine.  See also http://bugzilla.gnome.org/show_bug.cgi?id=509683#c1 for a similar problem.  We might need to have more "so you don't support accessible text do you?" defensive patches in flat_review.py.
Comment 5 Mike Pedersen 2008-01-29 18:14:29 UTC 
Happily I've just tested this in OOWriter, OOimpress, firefox thunderbird, terminal and gedit.  Flat review seems to work well in all places.  
thanks much
Comment 6 Joanmarie Diggs (IRC: joanie) 2008-01-29 18:23:19 UTC 
Thanks Mike.  Patch committed.  Moving to pending.