Bug 512593 – nautilus crashed with SIGSEGV in nautilus_bookmark_list_load_file()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 512593 - nautilus crashed with SIGSEGV in nautilus_bookmark_list_load_file()


Summary:	nautilus crashed with SIGSEGV in nautilus_bookmark_list_load_file()


Status:	RESOLVED FIXED

Product:	nautilus
Classification:	Core
Component:	[obsolete] GIO
Version:	2.21.x
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Christian Neumair
QA Contact:	Nautilus Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-01-28 15:56 UTC by Pedro Villavicencio
Modified:	2008-02-28 19:21 UTC

See Also:
GNOME target:	---
GNOME version:	2.19/2.20

Attachments
Proposed patch (411 bytes, patch) 2008-02-25 16:31 UTC, Christian Neumair	committed	Details \| Review

Description Pedro Villavicencio 2008-01-28 15:56:21 UTC

This report has been entered here:

https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/186665

".

+ Trace 187076

Thread 2 (process 7975)

#0 read
from /lib/libpthread.so.0
#1 child_watch_helper_thread
at /build/buildd/glib2.0-2.15.3/glib/gmain.c line 3909
#2 g_thread_create_proxy
at /build/buildd/glib2.0-2.15.3/glib/gthread.c line 635
#3 start_thread
from /lib/libpthread.so.0
#4 clone
from /lib/libc.so.6
#5 ??

Thread 1 (process 7856)

#0 nautilus_file_get_gicon
at nautilus-file.c line 3191
#1 nautilus_bookmark_list_load_file
at nautilus-bookmark-list.c line 86
#2 nautilus_bookmark_list_init
at nautilus-bookmark-list.c line 162
#3 IA__g_type_create_instance
at /build/buildd/glib2.0-2.15.3/gobject/gtype.c line 1569
#4 g_object_constructor
at /build/buildd/glib2.0-2.15.3/gobject/gobject.c line 1046
#5 IA__g_object_newv
at /build/buildd/glib2.0-2.15.3/gobject/gobject.c line 937
#6 IA__g_object_new_valist
at /build/buildd/glib2.0-2.15.3/gobject/gobject.c line 986
#7 IA__g_object_new
at /build/buildd/glib2.0-2.15.3/gobject/gobject.c line 795
#8 nautilus_bookmark_list_new
at nautilus-bookmark-list.c line 496
#9 nautilus_get_bookmark_list
at nautilus-window-bookmarks.c line 59
#10 nautilus_window_initialize_bookmarks_menu
at nautilus-window-bookmarks.c line 325
#11 nautilus_window_init
at nautilus-window.c line 175
#12 IA__g_type_create_instance
at /build/buildd/glib2.0-2.15.3/gobject/gtype.c line 1561
#13 g_object_constructor
at /build/buildd/glib2.0-2.15.3/gobject/gobject.c line 1046
#14 nautilus_window_constructor
at nautilus-window.c line 653
#15 IA__g_object_newv
at /build/buildd/glib2.0-2.15.3/gobject/gobject.c line 937
#16 IA__g_object_new_valist
at /build/buildd/glib2.0-2.15.3/gobject/gobject.c line 1027
#17 IA__gtk_widget_new
at /build/buildd/gtk+2.0-2.12.5/gtk/gtkwidget.c line 2735
#18 nautilus_desktop_window_new
at nautilus-desktop-window.c line 120
#19 nautilus_application_open_desktop
at nautilus-application.c line 816
#20 start_desktop_at_idle
at nautilus-shell.c line 304
#21 IA__g_main_context_dispatch
at /build/buildd/glib2.0-2.15.3/glib/gmain.c line 2064
#22 g_main_context_iterate
at /build/buildd/glib2.0-2.15.3/glib/gmain.c line 2697
#23 IA__g_main_loop_run
at /build/buildd/glib2.0-2.15.3/glib/gmain.c line 2905
#24 IA__gtk_main
at /build/buildd/gtk+2.0-2.12.5/gtk/gtkmain.c line 1163
#25 main
at nautilus-main.c line 571
#26 __libc_start_main
from /lib/libc.so.6
#27 _start

Comment 1 Christian Neumair 2008-02-25 16:27:24 UTC

Confirming.

Comment 2 Christian Neumair 2008-02-25 16:31:51 UTC

Created attachment 105919 [details] [review]
Proposed patch

Submitted for review:
http://mail.gnome.org/archives/nautilus-list/2008-February/msg00203.html

Comment 3 Christian Neumair 2008-02-28 19:21:02 UTC

Committed, closing. Another patch was also committed (cf. mailing list) that makes bookmark parsing robust against lines beginning with spaces.