After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 512549 - vala sample does not build
vala sample does not build
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.11.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-28 11:32 UTC by Götz Waschk
Modified: 2008-02-21 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
this will make it build (520 bytes, patch)
2008-01-28 11:56 UTC, Götz Waschk 		committed Details | Review

Description Götz Waschk 2008-01-28 11:32:49 UTC 
This is on Mandriva Cooker with vala 0.1.6 and rhythmbox 0.11.4:

/usr/bin/valac --vapidir=../../bindings/vala --pkg=rhythmdb --pkg=rb rb-sample-vala-plugin.vala
../../bindings/vala/rb.vapi:20.24-20.31: error: Abstract methods may not be declared in non-abstract classes
../../bindings/vala/rb.vapi:23.24-23.33: error: Abstract methods may not be declared in non-abstract classes
Compilation failed: 2 error(s), 0 warning(s)
make: *** [rb-sample-vala-plugin.c] Fehler 1
Comment 1 Götz Waschk 2008-01-28 11:56:55 UTC 
Created attachment 103873 [details] [review]
this will make it build
Comment 2 Bastien Nocera 2008-01-30 16:02:51 UTC 
Won't that break with vala 0.1.5? If so, we'd need to up the requirements for it as well.
Comment 3 David Keijser 2008-02-19 19:57:12 UTC 
I tested this patch with vala 0.1.5 and it compiles smoothly without warnings.
Comment 4 Jonathan Matthew 2008-02-21 13:16:20 UTC 
Committed to svn.  Thanks.