After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 512403 - libgnomeuimm (gentoo package) doesn't compile with gcc-4.3
libgnomeuimm (gentoo package) doesn't compile with gcc-4.3
Status: RESOLVED FIXED
Product: libgnomeuimm
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2008-01-27 17:15 UTC by hodoscek
Modified: 2011-01-16 23:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
patch to compile libgnomeuimm with gcc-4.3.0 (615 bytes, patch)
2008-01-27 17:17 UTC, hodoscek
none Details | Review

Description hodoscek 2008-01-27 17:15:04 UTC
Please describe the problem:
libgnomeuimm (gentoo package) doesn't compile with gcc-4.3
two files are missing #include <cstring>


Steps to reproduce:
1. emerge libgnomeuimm
2. 
3. 


Actual results:
.lo -MD -MP -MF .deps/ui-items-stock.Tpo -c ui-items-stock.cc  -fPIC -DPIC -o
.libs/ui-items-stock.o
mv -f .deps/wrap_init.Tpo .deps/wrap_init.Plo
mv -f .deps/init.Tpo .deps/init.Plo
mv -f .deps/ui-items-icon.Tpo .deps/ui-items-icon.Plo
app-helper.cc: In copy constructor 'Gnome::UI::Items::Info::Info(const
Gnome::UI::Items::Info&)':
app-helper.cc:83: error: 'memcpy' was not declared in this scope
app-helper.cc: In member function 'Gnome::UI::Items::Info&
Gnome::UI::Items::Info::operator=(const Gnome::UI::Items::Info&)':
app-helper.cc:100: error: 'memcpy' was not declared in this scope
make[4]: *** [app-helper.lo] Error 1


Expected results:
to compile it normally

Does this happen every time?
yes

Other information:
this is the patch to fix the problem:
--- libgnomeuimm-2.20.0/libgnomeui/libgnomeuimm/app-helper.cc   2007-09-14 13:38:49.000000000 +0200
+++ new/libgnomeui/libgnomeuimm/app-helper.cc   2008-01-27 13:23:39.000000000 +0100
@@ -20,6 +20,7 @@
 #include <gtk/gtkstock.h>
 #include <libgnomeuimm/app-helper.h>
 #include <glibmm/exceptionhandler.h>
+#include <cstring>


 namespace Gnome
--- libgnomeuimm-2.20.0/examples/iconlist/iconlist2.cc  2007-09-14 13:38:50.000000000 +0200
+++ new/examples/iconlist/iconlist2.cc  2008-01-27 13:19:43.000000000 +0100
@@ -1,3 +1,4 @@
+#include <cstring>
 #include <libgnomeuimm.h>

 static GtkTargetEntry target_table[] = {
Comment 1 hodoscek 2008-01-27 17:17:40 UTC
Created attachment 103826 [details] [review]
patch to compile libgnomeuimm with gcc-4.3.0

I am sending it as an attachement now. The one in the text window is with broken lines :-((
Comment 2 Christian Persch 2008-01-27 18:07:22 UTC
Reassigning to the correct product.
Comment 3 Murray Cumming 2008-02-10 16:30:08 UTC
I believe that this was fixed by this commit already:

2007-11-08  Stanislav Brabec  <sbrabec@suse.cz>

	* libgnomeui/libgnomeuimm/app-helper.cc,
	examples/iconlist/iconlist2.cc: Fixed gcc 4.3 implicit
	declaration errors (#491469).
	* libgnomeui/libgnomeuimm/ui-items-icon.cc: Never return random
	value in Icon::get_pixmap_info (#491469).

However, your patch adds an extra include in app-helper.cc so I have applied that. I will release a new tarball now.