GNOME Bugzilla – Bug 512146
Remove non-dbus FSpot interface
Last modified: 2008-06-04 09:33:11 UTC
FspotDbusModule is the only supported FSpot interface in the future. We should remove the old one because it confuses users
Created attachment 103757 [details] [review] Just the DBus part The attached patch removed the fsport dbus factory part and just makes fspot dbusmodule a normal dp. It fails refresh if fspott is not running, much like the tomboy behavior. The whole FSpotDbusModule class should be moved into FSpotModule.py and FSpotDBusModule.py should be deleted. Until I decide furthur, just disable the non-dbus fspot module by removing its entry in MODULES
More or less fixed in r1265: removed the FSpotDbusModule.py file; moved the code to FSpotModule; also we no longer load the source dataprovider, we always load the dbus one and we error on refresh when f-spot's not running. Thanks John for the initial patch. One small update: i also make sure that the remote's are reset to None when f-spot is closed. This makes sure that they are reinstantiated when f-spot opens again.
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.