After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 512146 - Remove non-dbus FSpot interface
Remove non-dbus FSpot interface
Status: RESOLVED FIXED
Product: conduit
Classification: Other
Component: dataproviders
unspecified
Other Linux
: Normal normal
: ---
Assigned To: conduit-maint@gnome.bugs
conduit-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2008-01-25 23:13 UTC by John Stowers
Modified: 2008-06-04 09:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Just the DBus part (7.10 KB, patch)
2008-01-25 23:17 UTC, John Stowers
committed Details | Review

Description John Stowers 2008-01-25 23:13:56 UTC
FspotDbusModule is the only supported FSpot interface in the future. We should remove the old one because it confuses users
Comment 1 John Stowers 2008-01-25 23:17:05 UTC
Created attachment 103757 [details] [review]
Just the DBus part

The attached patch removed the fsport dbus factory part and just makes fspot dbusmodule a normal dp. It fails refresh if fspott is not running, much like the tomboy behavior.

The whole FSpotDbusModule class should be moved into FSpotModule.py and FSpotDBusModule.py should be deleted. Until I decide furthur, just disable the non-dbus fspot module by removing its entry in MODULES
Comment 2 Thomas Van Machelen 2008-01-27 19:52:30 UTC
More or less fixed in r1265: removed the FSpotDbusModule.py file; moved the code to FSpotModule; also we no longer load the source dataprovider, we always load the dbus one and we error on refresh when f-spot's not running.

Thanks John for the initial patch. One small update: i also make sure that the remote's are reset to None when f-spot is closed.  This makes sure that they are reinstantiated when f-spot opens again.
Comment 3 John Stowers 2008-06-04 09:33:11 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.