I've just tested with gtk+ trunk and setting a filter worked as expected:

  GtkAction *action;
  GtkRecentFilter *filter;

  filter = gtk_recent_filter_new ();
  gtk_recent_filter_add_mime_type (filter, "image/*");

  action = gtk_recent_action_new ("recent",
                                  "Open Recent", "Open recent files",
                                  NULL);
  gtk_recent_chooser_set_filter (GTK_RECENT_CHOOSER (action), filter);

this adds a filter for the given MIME type. changing the filter to:

  gtk_recent_filter_add_group (filter, "Totem");

I correctly get all the files under the Totem group.

gtk_recent_chooser_set_filter() should be implicitly called by gtk_recent_chooser_add_filter(), on a GtkRecentAction and a GtkRecentChooserMenu (as they support just a single filter); in any case, could you please try using set_filter() instead?

Ah, I see what's happening: It's working for all kind of filters, but for vinagre.

Isn't GtkRecentAction prepared to work with things other than files?

Vinagre's .recently-used.xbel entry looks like:
<bookmark href="200.100.100.191:5900" added=...

Notice that href isn't a file, but a string that vinagre understands.

BTW, The places menu, under panel works correctly, I guess because it's not using filters...

GtkRecentFilter, like the entire GtkRecent machinery, expects a valid URI and not an IP address.

you should probably provide a custom filter function instead, to override the default one. you should also pass a valid URI, albeit with a custom scheme; something like "vinagre://<ipaddress>:<port>".

in gtk+ trunk I'm going to port most of the internals to GIO as well, but that will not fix passing invalid URIs to gtk_recent_manager_add_*().

Thanks, Emmanuele.

Vinagre is already passing a valid URI (vnc://host:port), with a valid entry in gconf (/desktop/gnome/url-handlers/vnc).

gnome-panel is working.

But, inside vinagre, it doesn't work :(

As you said, I've created a custom filter:
  filter = gtk_recent_filter_new ();
  gtk_recent_filter_add_custom (filter,
				GTK_RECENT_FILTER_GROUP,
				vinagre_window_filter_recent,
				NULL,
				NULL);
  gtk_recent_chooser_add_filter (GTK_RECENT_CHOOSER (window->priv->recent_action),
				 filter);

My filter function:
static gboolean
vinagre_window_filter_recent (const GtkRecentFilterInfo *info,
			      gpointer data)
{
  gint i;

  if (!info->groups)
    return FALSE;

  for (i=0; info->groups[i]; i++)
    if (!g_strcmp0 (info->groups[i], "vinagre"))
      return TRUE;

  return FALSE;
}

The items are passing through my function (I tested with lots of printf's), and are passing in the test, returning TRUE. But they don't appear in menu :(

What's missing? What's wrong?

Thanks.

Created attachment 104808 [details] [review]
proposed patch

I think I found the problem. With this patch, Vinagre is working fine :)

2008-02-10  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtkrecentaction.c: Propagate local-only.  (#511987,
        Jonh Wendell)

Hi, Matthias.

Any chance this get into 2.12 branch? (I mean, is this fix going to get into GNOME 2.22?)

I've committed it to both branches.