After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 511759 - Can't automatically open $DOWNLOADS directory after GIO port
Can't automatically open $DOWNLOADS directory after GIO port
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-24 11:11 UTC by Luca Ferretti
Modified: 2008-01-24 19:14 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
patch (952 bytes, patch)
2008-01-24 16:25 UTC, Cosimo Cecchi
committed Details | Review
better patch (3.74 KB, patch)
2008-01-24 18:44 UTC, Cosimo Cecchi
committed Details | Review

Description Luca Ferretti 2008-01-24 11:11:21 UTC
After a download, Epiphnay opens the download directory. After the GIO port, on my jhbuild it fails trying to open a non existant path.

 1. Click on a link targeting a non managed file type[1].
 2. Choose "Download" on alert
 3. Wait for download

Expected Results:
  Epiphany should open (through Nautilus, of course) the folder
  storing the downloaded file.

Actual Result:
  Nautilus display an error alert saying it can't open the folder
  /home/username/file://home/username/Downloads

[1] like this MacOS dmg file:
http://wsidecar.apple.com/cgi-bin/nph-reg3rdpty2.pl/product=14144&cat=9&platform=osx&method=sa/20080114-VisionSynth-2.0.dmg
Comment 1 Luca Ferretti 2008-01-24 11:14:31 UTC
Note: instead, if you right click the test link in previous comment and choose "Download Link" from popup menu, the auto open feature works fine...
Comment 2 Cosimo Cecchi 2008-01-24 16:25:00 UTC
Created attachment 103644 [details] [review]
patch

I committed this tiny patch to fix this bug, now it works fine.
Comment 3 Cosimo Cecchi 2008-01-24 16:26:12 UTC
Closing as FIXED.

------------------------------------------------------------------------
r7886 | cosimoc | 2008-01-24 17:23:39 +0100 (gio, 24 gen 2008) | 4 lines

Use g_file_new_for_uri () instead of g_file_new_for_path () in
ephy_file_browse_to ().
Fix bug #511759.
Comment 4 Cosimo Cecchi 2008-01-24 18:44:01 UTC
Created attachment 103654 [details] [review]
better patch

Reopening.
I made a better patch for this, as |parameter| in ephy_file_browse_to () could be both a uri or a path.
Comment 5 Cosimo Cecchi 2008-01-24 19:14:44 UTC
Committed.