After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 51152 - CD Player does not support CDDA
CD Player does not support CDDA
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: Gnome-CD
2.5.x
Other All
: High major
: 2.7.2
Assigned To: gnome media maintainers
gnome media maintainers
: 86331 129604 138173 143595 147622 151991 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2001-02-20 03:35 UTC by wwsmurf
Modified: 2005-08-15 01:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Updated patch from bug 86331 (37.83 KB, patch)
2004-03-01 01:58 UTC, alexander.winston
needs-work Details | Review

Description wwsmurf 2001-02-20 03:38:13 UTC
Package:  gtcd
Severity: normal
Version:  ???
Synopsis: gtcd dosen't support digital extraction (extract mode)
Class:    change-request

Distribution: Red Hat Linux release 7.0 (Guinness)
System: Linux 2.2.16-22 i586 unknown
C library: glibc-2.1.92-14
C compiler: 2.96
glib: 1.2.8
GTK+: 1.2.8
ORBit: ORBit 0.5.6
gnome-libs: gnome-libs 1.2.11
libxml: 1.8.10
gnome-print: gnome-print-0.25-8_helix_1
gnome-core: gnome-core 1.2.4


Description:
gtcd dosen't support extract mode (rip/play) like winamp does with
plugins, or Windows 2000 does when you enable "digital playback"




------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-02-19 22:38 -------

The original reporter (wwsmurf@go.com) of this bug does not have an account here.
Reassigning to the exporter, unknown@bugzilla.gnome.org.
Reassigning to the default owner of the component, peter@ximian.com.

Comment 1 Dave Bordoley [Not Reading Bug Mail] 2002-02-25 22:32:04 UTC
I think this is a little outside the scope of gtcd. If you want to rip
cd's use grip. Gtcd is meant to be a basic cd player. Should be marked
wontfix or notabug.
Comment 2 Dave Bordoley [Not Reading Bug Mail] 2002-03-19 04:36:48 UTC
Switching component to Gnome-Cd.
Comment 3 Iain 2002-03-23 02:08:10 UTC
If it's useful for playing then maybe it could be done. If it's only
for ripping a CD, then, no, we probably won't do that. Condone
piracy...never
Comment 4 Iain 2002-04-08 01:12:01 UTC
Yeah, I've been reading and this only looks like its useful for
ripping. Use grip or rythmbox for that. I don't think gnome-cd will
ever get that advanced.
Comment 5 Robert McMeekin 2004-02-22 02:54:08 UTC
Hi!  This does affect playing.  I just bought an emachines c2825.  It
comes with a CD-RW and DVD-ROM, but no CD -> sound card cables.  This
means when I start gnome-cd, I don't get any errors.  It thinks
everything is just fine.  But no sound comes from the speakers.  I
haven't opened up the box yet, but I figure if I go out and buy the
cables I can connect them.  Usually I would have to choose which one
to connect to though.  So if I chose to connect the CD-RW, I wouldn't
be able to burn a CD and listen to a CD at the same time.  If I hooked
up the DVD-ROM, I wouldn't be able to read data from a DVD-ROM and
listen to a CD at the same time.

I think this is very relevant.  It even took me a while googling to
figure out what was wrong.  :-)
Comment 6 alexander.winston 2004-02-28 17:12:57 UTC
Yes, this is extremely relevant. For all users that do not have this
cable (many are built without them these days), GNOME CD has been
broken from the start.
Comment 7 Luis Villa 2004-02-28 17:15:40 UTC
Alexander: don't bother adding the 10,000,000 gnomever keywords- just
add the latest one that it is found in.
Comment 8 alexander.winston 2004-02-28 17:33:22 UTC
Okay, Luis. :)

All right . . . At the moment, there are two patches from the two
duplicates (bug 86331 and bug 129604) of this bug. The patch from bug
86331 adds GStreamer support and (from what I can tell) uses
GStreamer's Paranoia element for playback. The patch from bug 129604
goes adds playback by going straight to Paranoia. Neither of them
apply cleanly as of 2004-02-28.

Now, I hate to pick one over the other, but it will have to be done
because of this work duplication. :( As we are currently transitioning
(I think) toward GStreamer, I think that the patch from 86331 is more
promising.

Any thoughts?
Comment 9 alexander.winston 2004-03-01 01:58:55 UTC
Created attachment 24957 [details] [review]
Updated patch from bug 86331
Comment 10 alexander.winston 2004-03-01 02:04:17 UTC
I just uploaded an updated patch from bug 86331. I fixed the bits that
kept it from applying cleanly, switched the C99 comments back to C90,
and ran indent over it. Could anyone take this patch out for a test
drive for me? I'm having (unrelated) trouble building things today.

Adding the PATCH and portability keywords, clarifying subject and
affected versions and operating systems.
Comment 11 Iain 2004-03-01 13:10:29 UTC
Testing the patch now, but on first inspection it seems to always use
gstreamer, which is bad. It needs some autoconf magic to allow you to
turn off the gstreamer stuff for gnome-cd
Comment 12 Iain 2004-03-01 13:13:18 UTC
Further to this

gst-cdparanoia-cdrom.o: In function `build_pipeline':
/usr/local/src/gnome2-1/gnome-media/gnome-cd/gst-cdparanoia-cdrom.c:207:
undefined reference to `gst_bin_set_post_iterate_function'
Comment 13 Ronald Bultje 2004-03-01 14:50:58 UTC
Instead, connect to the 'iterate' signal.

static gboolean
cb_iterate (GstBin  *bin,
            gpointer data)
{
  //.. bla

  return FALSE;
}

g_signal_connect (pipeline, "iterate",
                  G_CALLBACK (cb_iterate), NULL);

I do agree that a GStreamer'less gnome-cd as compile-time option would
be nice. Defaulting to GStreamer seems ok. ;).
Comment 14 Iain 2004-03-01 16:26:21 UTC
Okay, with that last change the patch works, but it would still need
the autoconf stuff done correctly.
Comment 15 Luis Villa 2004-04-08 23:19:06 UTC
Comment on attachment 24957 [details] [review]
Updated patch from bug 86331

Adding the 'needs-work' status based on Iain's last comment.
Comment 16 Ronald Bultje 2004-04-22 17:28:18 UTC
*** Bug 129604 has been marked as a duplicate of this bug. ***
Comment 17 Ronald Bultje 2004-04-22 17:28:55 UTC
*** Bug 86331 has been marked as a duplicate of this bug. ***
Comment 18 Ronald Bultje 2004-04-22 17:36:23 UTC
The only work needed is autoconf, I can do that in one or two hours. I propose
to apply this patch right after 2.6.x is branched off.
Comment 19 Thomas Vander Stichele 2004-05-06 15:16:44 UTC
*** Bug 138173 has been marked as a duplicate of this bug. ***
Comment 20 Ronald Bultje 2004-06-02 18:05:20 UTC
*** Bug 143595 has been marked as a duplicate of this bug. ***
Comment 21 Balamurali Viswanathan 2004-06-15 05:40:01 UTC
Ronald, Since we have branched could this patch be applied. Thanks
Comment 22 Ronald Bultje 2004-06-16 01:04:09 UTC
Checked in, including proper autotools magic, works correctly on my system. I'll
test on some university boxes later this week or this weekend.

And of course thanks to Iain for all the work.
Comment 23 Balamurali Viswanathan 2004-07-15 04:12:39 UTC
*** Bug 147622 has been marked as a duplicate of this bug. ***
Comment 24 Ronald Bultje 2004-11-25 22:48:33 UTC
*** Bug 151991 has been marked as a duplicate of this bug. ***