After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 511462 - Labeled by/Label for relationship missing in address book.
Labeled by/Label for relationship missing in address book.
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: Accessibility
GIT master
Other All
: Normal enhancement
: ---
Assigned To: Jan Schampera
Ekiga maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-23 06:51 UTC by Tim Miao
Modified: 2013-01-28 17:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix LDAP address book entries with a11y relations (6.40 KB, patch)
2008-02-04 14:27 UTC, Patrick Wade 		none Details | Review
Fix LDAP address book entries with a11y relations (4.91 KB, patch)
2008-03-10 17:36 UTC, Patrick Wade 		none Details | Review

Description Tim Miao 2008-01-23 06:51:32 UTC 
Steps to reproduce:
1. Launch ekiga, invoke address book.
2. Creat a new contact. Choose Type to Remote LDAP.
3. Invoke accerciser, poke to this new card window.

Expected result:
The text entry should be labeled by the label before each text entry.

Actual result:
The text entry is not labeled by the label before each text entry.
Comment 1 Patrick Wade 2008-02-04 14:27:31 UTC 
Created attachment 104387 [details] [review]
Fix LDAP address book entries with a11y relations
Comment 2 Rich Burridge 2008-02-05 22:23:45 UTC 
Functionally this patch looks good. There are several identical
chunks of code. I suggest adding a new routine that gets called
in multiple places instead.

Thanks.
Comment 3 Tim Miao 2008-03-05 07:35:39 UTC 
Any updates of this bug?
Comment 4 Rich Burridge 2008-03-05 14:41:39 UTC 
Patrick, I would suggest that the patch should be readjusted to use the
same approach to the other similar bug I recently fixed. Thanks.
Comment 5 Patrick Wade 2008-03-10 17:36:22 UTC 
Created attachment 106993 [details] [review]
Fix LDAP address book entries with a11y relations
Comment 6 Rich Burridge 2008-03-10 19:08:20 UTC 
Much nicer. Thanks! 

Ekiga developers, can this be checked in SVN trunk
for GNOME 2.23.X after you've branched (assuming you
haven't already done so).
Comment 7 Jan Schampera 2008-09-09 05:22:34 UTC 
I'll take that bug to implement the patch into the current code - some things changed since march.
Comment 8 Jan Schampera 2008-09-09 05:32:50 UTC 
Though I'm not sure how to globally place it.

lib/gui/atk-helper.[hc] for now?
Comment 9 Jan Schampera 2008-09-11 03:51:58 UTC 
*** Bug 369210 has been marked as a duplicate of this bug. ***
Comment 10 Jan Schampera 2008-09-11 03:59:58 UTC 
The above bug is not a real DUP, but it's very similar.

For mass-input windows (with much label/entry pairs) I doubt that mnemonic labels are a solution (usually users use TAB or even mouse to go throuch the entries, not a mnemonic), so I'll go the explicit relation way there (*opinions?*).

For everything else, too.

Obsoleting the attached patch due to code changes. Using it as boilerplate, of course.

Planning for 3.2, since 3.01 will have other trouble. Though it will be a step-by-step ATKing, so it's floating anyways.
Comment 11 Eugen Dedu 2009-03-05 23:46:19 UTC 
Jan, is there a drawback to create mnemonics?
Comment 12 Eugen Dedu 2009-03-06 01:32:06 UTC 
It seems to me that "Create LDAP directory" has mnemonics and relationship, so this bug could be closed.  Can someone confirm that?
Comment 13 Eugen Dedu 2009-03-28 15:18:21 UTC 
There are still two issues:
- alt-m and alt-s show a warning "(ekiga:24776): Gtk-WARNING **: Couldn't find a target for a mnemonic activation."; it seems the relatinship label/single_choice does not work (label/editbox does work)
- Use TLS and Use SASL check boxes do not have a shortcut
Comment 14 Eugen Dedu 2013-01-28 17:42:56 UTC 
Fixed with http://git.gnome.org/browse/ekiga/commit/?id=1a5e1331a89.