After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 511160 - optional countdown for taking picture
optional countdown for taking picture
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-01-22 01:31 UTC by Jaap A. Haitsma
Modified: 2008-03-13 01:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the ui patch (3.00 KB, patch)
2008-02-19 17:53 UTC, daniel g. siegel
none Details | Review
final patch (5.58 KB, patch)
2008-02-25 23:43 UTC, daniel g. siegel
accepted-commit_after_freeze Details | Review

Description Jaap A. Haitsma 2008-01-22 01:31:51 UTC
Now the countdown is forced. This can for instance be not so handy if you want to take pictures of something else then yourself. 

PS for Daniel ;-). I know I ripped this out myself in the refactor branch. This is just a placeholder so we or somebody else writes a patch for it for GNOME 2.24
Comment 1 daniel g. siegel 2008-02-19 16:44:02 UTC
partially fixed in trunk. we need to alter the gui though
Comment 2 daniel g. siegel 2008-02-19 17:53:00 UTC
Created attachment 105589 [details] [review]
the ui patch
Comment 3 daniel g. siegel 2008-02-19 17:53:33 UTC
now whats missing is to read out the gconf setting at start and set the toggle entry to that value
Comment 4 Jaap A. Haitsma 2008-02-19 20:24:47 UTC
The UI patch sofar looks fine to me. The thing that is also missing as far as i can see is that you have to disable the countdown process

BTW I think if you want to get this in you need a freeze break.
Comment 5 daniel g. siegel 2008-02-19 22:25:43 UTC
i will apply for a freeze break if the patch is complete.

i didnt manage to read the setting from gconf and apply it to the toggle menu entry. do you mind having a go there?

what do you mean by disable the countdown process? do you mean if we are right into the countdown and then pressing esc?
Comment 6 Jaap A. Haitsma 2008-02-20 07:31:09 UTC
(In reply to comment #5)
> 
> i didnt manage to read the setting from gconf and apply it to the toggle menu
> entry. do you mind having a go there?

What's the problem you are having? Can't you read it from gconf or can't you set the toggle menu? For the rest it seems straigthforward. You read the setting at startup and the toggle menu item to the correct state
 
> what do you mean by disable the countdown process? do you mean if we are right
> into the countdown and then pressing esc?

No, I mean that if countdown is not set, I should not see the countdown widget

Comment 7 daniel g. siegel 2008-02-20 10:21:48 UTC
i cant set the toggle menu as i just have the action group but not the toggleaction itself which i need to set.

Comment 8 Jaap A. Haitsma 2008-02-20 20:55:52 UTC
Always look in code what does what you want. in eog-window.c for instance you can find

	action = gtk_ui_manager_get_action (priv->ui_mgr, "/MainMenu/View/StatusbarToggle");
	g_assert (action != NULL);
	gtk_toggle_action_set_active (GTK_TOGGLE_ACTION (action), visible);
Comment 9 daniel g. siegel 2008-02-25 23:43:51 UTC
Created attachment 105942 [details] [review]
final patch

this is the final patch. settings are read out from gconf.
Comment 10 daniel g. siegel 2008-03-13 01:59:01 UTC
fixed in trunk/