After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 511146 - rtpjitterbuffer should not return an error on no-caps
rtpjitterbuffer should not return an error on no-caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-21 23:21 UTC by Olivier Crête
Modified: 2008-01-25 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Let the jitterbuffer drop packets which no clock-rate (1.58 KB, patch)
2008-01-21 23:22 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2008-01-21 23:21:28 UTC 
The jitter buffer should not return an error up the pipeline if it can not get the pt for an packet, but should just silently drop it. Patch attached
Comment 1 Olivier Crête 2008-01-21 23:22:23 UTC 
Created attachment 103381 [details] [review]
Let the jitterbuffer drop packets which no clock-rate
Comment 2 Wim Taymans 2008-01-22 11:17:04 UTC 
I'm thinking if we should not add this functionality to the rtpsession manager instead.
Comment 3 Olivier Crête 2008-01-22 16:20:52 UTC 
probably needs to be added to both, otherwise we can have a race where the data existed when the buffer reached the session manager, but no longer does when it reaches the jitterbuffer (alright, with farsight2 that can't happen, but you never know).
Comment 4 Wim Taymans 2008-01-25 17:17:43 UTC 
        Patch by: Olivier Crete <tester@tester.ca>

        * gst/rtpmanager/gstrtpjitterbuffer.c:
        (gst_rtp_jitter_buffer_init), (gst_rtp_jitter_buffer_change_state),
        (gst_rtp_jitter_buffer_chain), (gst_rtp_jitter_buffer_loop):
        Remove old unused variable.
        Track pt on input buffers and get the clock-rate when it changes.
        Ignore packets with unknown clock-rate. Fixes #511146.