GNOME Bugzilla – Bug 511146
rtpjitterbuffer should not return an error on no-caps
Last modified: 2008-01-25 17:17:43 UTC
The jitter buffer should not return an error up the pipeline if it can not get the pt for an packet, but should just silently drop it. Patch attached
Created attachment 103381 [details] [review] Let the jitterbuffer drop packets which no clock-rate
I'm thinking if we should not add this functionality to the rtpsession manager instead.
probably needs to be added to both, otherwise we can have a race where the data existed when the buffer reached the session manager, but no longer does when it reaches the jitterbuffer (alright, with farsight2 that can't happen, but you never know).
Patch by: Olivier Crete <tester@tester.ca> * gst/rtpmanager/gstrtpjitterbuffer.c: (gst_rtp_jitter_buffer_init), (gst_rtp_jitter_buffer_change_state), (gst_rtp_jitter_buffer_chain), (gst_rtp_jitter_buffer_loop): Remove old unused variable. Track pt on input buffers and get the clock-rate when it changes. Ignore packets with unknown clock-rate. Fixes #511146.