After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 510635 - PolicyKit policies descritions are not translatable.
PolicyKit policies descritions are not translatable.
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: clock
git master
Other All
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-19 16:42 UTC by Luca Ferretti
Modified: 2008-01-28 12:07 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
The proposed patch (4.30 KB, patch)
2008-01-19 16:43 UTC, Luca Ferretti
none Details | Review
Updated patch (4.43 KB, patch)
2008-01-19 17:24 UTC, Luca Ferretti
committed Details | Review

Description Luca Ferretti 2008-01-19 16:42:29 UTC
Here is a patch to allow translations of .policy files.

Basically:
 *  move .policy file to .policy.in
 *  add @INTLTOOL_POLICY_RULE@ in Makefile.am and add .policy.in do DISTFILES
 *  add .policy.in to POTFILES.in

I'm running make distcheck to ensure it works fine.
Comment 1 Luca Ferretti 2008-01-19 16:43:26 UTC
Created attachment 103202 [details] [review]
The proposed patch
Comment 2 Luca Ferretti 2008-01-19 17:24:33 UTC
Created attachment 103206 [details] [review]
Updated patch

Add $(polkit_DATA) to CLEANFILES

(still running make distcheck...)
Comment 3 Luca Ferretti 2008-01-19 17:39:19 UTC
distcheck says the latest patch is ok
Comment 4 Vincent Untz 2008-01-27 23:29:12 UTC
Thanks.
Comment 5 Wouter Bolsterlee (uws) 2008-01-28 01:22:39 UTC
There is a typo.

From: Seán de Búrca
To: gnome-i18n@gnome.org
Date: Sun, 27 Jan 2008 18:05:44 -0700
Subject: Re: String change in gnome-panel
> [...] the first word in the third _message [...] reads
> "Privieleges"
Comment 6 André Klapper 2008-01-28 09:47:03 UTC
yepp, there is a typo.
Comment 7 Vincent Untz 2008-01-28 09:55:42 UTC
Ok, I've grepped my all gnome-panel tree for the typo, and I can't find it.

Whoever can see it feel free to fix it.
Comment 8 Vincent Untz 2008-01-28 10:19:46 UTC
Ah, I understand what happened: you are talking about the strings in the patch, and I'm talking about the actual strings in svn.

The patch couldn't be applied (because of 'svn mv'), so I had to re-do part of it myself, and I didn't see the strings in Luca's patch.

Feel free to either change the strings to the ones proposed by Luca in his patch, or to close the bug.
Comment 9 Luca Ferretti 2008-01-28 10:47:08 UTC
Vincent, I've just applied a change on svn, it seems you have committed the .in file with

  <_message>...<message>

instead

  <_message>...<_message>

PS the string change was to match similar strings from PolicyKit, if I remember well.. If OK I'll change them (fixing the wrong one) and close the bug
Comment 10 Vincent Untz 2008-01-28 10:59:29 UTC
Ah, good catch. I shouldn't commit things at 1AM.

Feel free to change the strings.
Comment 11 Luca Ferretti 2008-01-28 12:07:23 UTC
The original PK messages are 
  Authentication is required to ....

This is the change committed to trunk

Index: gnome-clock-applet-mechanism.policy.in
===================================================================
--- gnome-clock-applet-mechanism.policy.in      (revisione 10764)
+++ gnome-clock-applet-mechanism.policy.in      (copia locale)
@@ -3,13 +3,11 @@
  "-//freedesktop//DTD PolicyKit Policy Configuration 1.0//EN"
  "http://www.freedesktop.org/standards/PolicyKit/1.0/policyconfig.dtd">
 
-<!-- needs i18n work -->
-
 <policyconfig>
 
   <action id="org.gnome.clockapplet.mechanism.settimezone">
     <_description>Change system time zone</_description>
-    <_message>Changing the system time zone requires privileges.</_message>
+    <_message>Privileges are required to change the system time zone.</_message>
     <defaults>
       <allow_inactive>no</allow_inactive>
       <allow_active>auth_self_keep_always</allow_active>
@@ -18,7 +16,7 @@
 
   <action id="org.gnome.clockapplet.mechanism.settime">
     <_description>Change system time</_description>
-    <_message>Changing the system time requires privileges.</_message>
+    <_message>Privileges are required to change the system time.</_message>
     <defaults>
       <allow_inactive>no</allow_inactive>
       <allow_active>auth_self_keep_always</allow_active>
@@ -27,7 +25,7 @@
 
   <action id="org.gnome.clockapplet.mechanism.configurehwclock">
     <_description>Configure hardware clock</_description>
-    <_message>Configuring the hardware clock requires privileges.</_message>
+    <_message>Privileges are required to configure the hardware clock.</_message>
     <defaults>
       <allow_inactive>no</allow_inactive>
       <allow_active>auth_self_keep_always</allow_active>