Created attachment 103117 [details] [review]
patch

Btw, there's a slight conflict here. Currently running sound-juicer, at least on Fedora, with the gvfs cdda backend active is not working. This is because s-j uses libcdparanoia which (errornously) uses O_EXCL (on Linux) to lock the drive. The way to fix this is to avoid using O_EXCL (or use cdda:/// directly to read the PCM data). One way to fix this is to use libcdio_paranoia from libcdio

 http://www.gnu.org/software/libcdio/

and in addition this will make things work on mixed discs. There's some more detail on this topic here

http://mail.gnome.org/archives/gtk-devel-list/2007-December/msg00228.html

and surrounding messages.

Btw, in addition, using libcdio, would gain you support for other OS's than Linux cf. this message

http://mail.gnome.org/archives/gnome-vfs-list/2006-May/msg00030.html

There is a plan to switch to cdio, I let it drop this release cycle but maybe I should switch today and see how it works.

Right, sound-juicer does this:

  priv->cdsrc = gst_element_make_from_uri (GST_URI_SRC, "cdda://1", "cd_src");

So it's up to GStreamer to decide what element to return.  Most people have two choices: cdiocddasrc or cdparanoiasrc.  cdparanoiasrc has a higher rank than cdiocddasrc, so that gets chosen.  The cdparanoia element is also a -base plugin, cdio is -good.

I'd like to see the cdio plugin promoted over the cdparanoia plugin for reasons of saner code and better cross platform support, but this is a gstreamer issue.

That said, if Fedora wanted to manually boost the rank of the cdio plugin to see what happened, I'd love to know. :)

I thought I'd just hack this and removed the cdparanoia plugin briefly.  libcdio is *vastly* slower, instead of ripping at 14x I'm only getting 4x.  GStreamer doesn't let me control the level of paranoia, so maybe its always a full paranoia.

Oh, and back to the real point of this bug: I'm not sure that adding DVD would work, as far as I know cdparanoia and cdio can't rip DVD-Audio disks.

Committed the CD audio content type, I've left of DVD-audio until someone can demonstrate that they work.  I'm pretty certain they won't.

Thanks for committing this. I agree about x-content/audio-dvd, that was more wishful thinking on my part ;-)