After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 509880 - artdisplay-plugin does not preserve alpha-channel of image
artdisplay-plugin does not preserve alpha-channel of image
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.11.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 412853
 
 
Reported: 2008-01-16 12:14 UTC by Mirco Müller
Modified: 2008-01-24 13:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix to make artdisplay preserve an images alpha-channel if present (2.93 KB, patch)
2008-01-17 16:33 UTC, Mirco Müller
committed Details | Review

Description Mirco Müller 2008-01-16 12:14:58 UTC
When drag&drop-ing a PNG with alpha-channel on the artdisplay-widget in rb the alpha-channel is not preserved and saved on harddisk. That's due to artdisplay only saving cover-images as JPG, which does not support an alpha-channel.

Example (right after drag&drop): http://macslow.thepimp.net/shots/sparkle-2.png

Example (after restart of rb): http://macslow.thepimp.net/shots/sparkle-3.png

A possible solution would be to extend artdisplay in a way to save images with an alpha-channel as PNG by default.
Comment 1 Mirco Müller 2008-01-17 16:33:37 UTC
Created attachment 103071 [details] [review]
fix to make artdisplay preserve an images alpha-channel if present

The patch checks if a pixbuf to save has an alpha-channel. If it does the file will be saved as PNG with the .png extension and a compression of 9. In case there is no alpha-channel it is saved as JPG with the .jpg extension and a quality of 100 (that just as it was before).
When an image is about to be loaded from harddisk it is checked (via extension) if it is a .png or .jpg.
Comment 2 Jonathan Matthew 2008-01-24 13:04:23 UTC
Committed to svn.  Thanks for the patch.