After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 509877 - "ask before emptying the trash or deleting files" doesn't work
"ask before emptying the trash or deleting files" doesn't work
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] GIO
2.21.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 516096 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-01-16 11:53 UTC by sangu
Modified: 2008-02-14 10:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Fist step: add a confirm_empty_local_trash() function (973 bytes, patch)
2008-02-12 21:09 UTC, Luca Ferretti 		needs-work Details | Review
patch v2 (1.50 KB, patch)
2008-02-13 00:17 UTC, Cosimo Cecchi 		none Details | Review

Description sangu 2008-01-16 11:53:34 UTC 
Please describe the problem:
"ask before emptying the trash or deleting files" doesn't work

Steps to reproduce:
1. launch nautilus-file-management-properties
2. click Behavior tab
3. "check ask before emptying the trash or deleting files"
4. delete a file on nautilus 
5. Empty Trash

Actual results:


Expected results:


Does this happen every time?
yes, always

Other information:
OS: Fedora development(rawhide 20080115)
nautilus-2.21.5-1.fc9
gvfs-0.1.2-1.fc9
glib2-2.15.2-1.fc9
Comment 1 Cosimo Cecchi 2008-01-16 16:06:54 UTC 
It's reproducible here, confirming.
Comment 2 Luca Ferretti 2008-02-12 20:31:16 UTC 
*** Bug 516096 has been marked as a duplicate of this bug. ***
Comment 3 Luca Ferretti 2008-02-12 21:09:04 UTC 
Created attachment 105089 [details] [review]
Fist step: add a confirm_empty_local_trash() function

Create a prompt dialog using the same primary and secondary message in current stable 2.20 (Note: applying this patch will need string freeze break approval)

Next step: where should we invoke it????
Comment 4 Cosimo Cecchi 2008-02-13 00:17:25 UTC 
Created attachment 105107 [details] [review]
patch v2

I took Luca's patch and made empty_trash_job () call the dialog accordingly. This works just fine in my testing.
Comment 5 Alexander Larsson 2008-02-13 20:33:34 UTC 
requested string break.
Comment 6 Alexander Larsson 2008-02-14 10:28:54 UTC 
got permissions. Commiting.