GNOME Bugzilla – Bug 509822
unsaved state is incorrectly unset
Last modified: 2008-10-30 20:08:13 UTC
Please describe the problem: GIMP indicates in the window title bar of each open file whether or not it has been modified since last save, i.e. whether it is currently in a state different from that last saved state. I found that if I colorise an area, save, then undo and colorise the same area differently, GIMP assumes that the colorisation settings have been the same, and thus indicates that the state of the document has already been saved. Steps to reproduce: 1. Select an area 2. Colors -> Colorise 3. Choose any settings that change the image 4. Apply 5. Save image 6. Undo 7. Colors -> Colorise 8. Choose different settings from first time 9. Apply Actual results: The changed document indicator (asterisk) disappears after the second colorisation. Expected results: Changed document indicator remains, since new state is not same as saved state. Does this happen every time? Yes. Other information:
There seems to be a strange bug in the code that updates the saved state. I can reproduce this with current trunk.
Created attachment 102982 [details] [review] patch to fix the dirty counter issue Not a very elegant fix, but I can't think of a better solution right now...
Applied in both branches. Closing as FIXED. 2008-01-24 Sven Neumann <sven@gimp.org> * app/core/gimpimage.c * app/core/gimpimage-undo.c: fixed handling of the image undo counter for the case where the user has undone the image to a state before the last save and then pushes a new undo. Fixes bug #509822.