GNOME Bugzilla – Bug 509689
bug-buddy patch for libsoup 2.4
Last modified: 2008-01-30 18:19:24 UTC
libsoup 2.3.0 will be merged to svn head and released later today, to become a part of GNOME 2.22. This is an API-breaking release, so everything that uses libsoup needs to be ported to the new release. I'm attaching a patch for bug-buddy. As you'll see, the XML-RPC code in libsoup has been completely rewritten, and though it's a little hard to tell from the patch, it makes things much simpler. :) Three things to note: 1) Some of the XML-RPC routines return GErrors directly now, so I tried to fix up bug-buddy's internal use of GErrors so that it made use of them, rather than creating its own GErrors out of the XML-RPC status. I may have messed this up. 2) Bug-buddy is currently base64-encoding crash dumps twice. (Once itself and once by asking libsoup to do it.) I preserved that behavior since I didn't know what the server would do if we only encoded them once. 3) There's another FIXME re: the User-Agent line. This is pretty minor/anal, but I noticed it and figured I'd mention it. I didn't change it because I wasn't sure if anything on the server side cared about the exact format.
Created attachment 102920 [details] [review] patch for bug-buddy
2.22 blocker. this should be reviewed asap.
Fer: do you need help reviewing this?
I looked at this, the code compiles and the patch looks good. Couldn't test it since I don't have everything ready for this, though. Fer: is it okay to commit for the beta release (tomorrow)?
Ehh, sorry, I was testing it on Friday before leaving for the weekend and there was a problem in the code hangling bugzilla error responses (debug symbols present). So it needs more testing. I'll work on it tonight. Thanks for the review!
Ok, commited after fixing the problem with UTF-8 control chars not valid in XML. Also fixed the title param. Thanks a lot Dan!