After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 509689 - bug-buddy patch for libsoup 2.4
bug-buddy patch for libsoup 2.4
Status: RESOLVED FIXED
Product: bug-buddy
Classification: Deprecated
Component: general
unspecified
Other Linux
: Immediate blocker
: ---
Assigned To: Bug-buddy Maintainers
Bug-buddy Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-15 16:38 UTC by Dan Winship
Modified: 2008-01-30 18:19 UTC
See Also:
GNOME target: 2.22.x
GNOME version: ---


Attachments
patch for bug-buddy (19.28 KB, patch)
2008-01-15 16:38 UTC, Dan Winship
none Details | Review

Description Dan Winship 2008-01-15 16:38:34 UTC
libsoup 2.3.0 will be merged to svn head and released later today, to become a part of GNOME 2.22. This is an API-breaking release, so everything that uses libsoup needs to be ported to the new release.

I'm attaching a patch for bug-buddy. As you'll see, the XML-RPC code in libsoup has been completely rewritten, and though it's a little hard to tell from the patch, it makes things much simpler. :)

Three things to note:

  1) Some of the XML-RPC routines return GErrors directly now, so I tried to
     fix up bug-buddy's internal use of GErrors so that it made use of them,
     rather than creating its own GErrors out of the XML-RPC status. I may
     have messed this up.

  2) Bug-buddy is currently base64-encoding crash dumps twice. (Once itself
     and once by asking libsoup to do it.) I preserved that behavior since
     I didn't know what the server would do if we only encoded them once.

  3) There's another FIXME re: the User-Agent line. This is pretty minor/anal,
     but I noticed it and figured I'd mention it. I didn't change it because
     I wasn't sure if anything on the server side cared about the exact
     format.
Comment 1 Dan Winship 2008-01-15 16:38:56 UTC
Created attachment 102920 [details] [review]
patch for bug-buddy
Comment 2 André Klapper 2008-01-23 15:11:39 UTC
2.22 blocker. this should be reviewed asap.
Comment 3 Vincent Untz 2008-01-23 15:13:14 UTC
Fer: do you need help reviewing this?
Comment 4 Vincent Untz 2008-01-27 15:31:41 UTC
I looked at this, the code compiles and the patch looks good. Couldn't test it since I don't have everything ready for this, though.

Fer: is it okay to commit for the beta release (tomorrow)?
Comment 5 Fernando Herrera 2008-01-28 16:51:11 UTC
Ehh, sorry, I was testing it on Friday before leaving for the weekend and there was a problem in the code hangling bugzilla error responses (debug symbols present). 

So it needs more testing. I'll work on it tonight.

Thanks for the review!
Comment 6 Fernando Herrera 2008-01-30 18:19:24 UTC
Ok, commited after fixing the problem with UTF-8 control chars not valid in XML.

Also fixed the title param.

Thanks a lot Dan!