After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 509677 - evolution-data-server patches for libsoup 2.4
evolution-data-server patches for libsoup 2.4
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks: 509681 509684 509686
 
 
Reported: 2008-01-15 16:07 UTC by Dan Winship
Modified: 2013-09-14 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to configure.in (2.19 KB, patch)
2008-01-15 16:08 UTC, Dan Winship
committed Details | Review
patch to calendar/backends/ (20.77 KB, patch)
2008-01-15 16:08 UTC, Dan Winship
committed Details | Review
patch to camel (1.83 KB, patch)
2008-01-15 16:09 UTC, Dan Winship
committed Details | Review
patch to servers/exchange/ (44.60 KB, patch)
2008-01-15 16:10 UTC, Dan Winship
committed Details | Review
patch to servers/groupwise/ (54.02 KB, patch)
2008-01-15 16:11 UTC, Dan Winship
committed Details | Review
patch to servers/google/ (7.96 KB, patch)
2008-01-15 16:11 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2008-01-15 16:07:51 UTC
libsoup 2.3.0 will be merged to svn head and released later today, to become a part of GNOME 2.22. This is an API-breaking release, so everything that uses libsoup needs to be ported to the new release.

I am about to attach patches for evolution-data-server. Unfortunately, while I've tested that they compile, I don't really have the infrastructure to really test that they *work*. At any rate, you can see that most of the changes are fairly mechanical renamings, so there shouldn't be major problems (and any minor problems should be worked out before 2.21.90).
Comment 1 Dan Winship 2008-01-15 16:08:21 UTC
Created attachment 102908 [details] [review]
patch to configure.in
Comment 2 Dan Winship 2008-01-15 16:08:44 UTC
Created attachment 102909 [details] [review]
patch to calendar/backends/
Comment 3 Dan Winship 2008-01-15 16:09:40 UTC
Created attachment 102911 [details] [review]
patch to camel

(this just removes some unneeded #includes)
Comment 4 Dan Winship 2008-01-15 16:10:05 UTC
Created attachment 102912 [details] [review]
patch to servers/exchange/
Comment 5 Dan Winship 2008-01-15 16:11:12 UTC
Created attachment 102913 [details] [review]
patch to servers/groupwise/

The big change here is that soup-soap-message and soup-soap-response have been removed from libsoup and imported into the groupwise backend. For now, I didn't rename them or otherwise try to integrate them with the other SOAP routines there.
Comment 6 Dan Winship 2008-01-15 16:11:35 UTC
Created attachment 102915 [details] [review]
patch to servers/google/

(last one!)
Comment 7 Akhil Laddha 2008-01-17 04:34:57 UTC
These patches need to be committed soon in trunk , libsoup changes break evolution-data-server build and also evolution fails to connect to exchange server. 

e-gw-connection.c:31:39: error: libsoup/soup-soap-message.h: No such file or directory
In file included from e-gw-connection.h:29,
                 from e-gw-connection.c:33:
e-gw-proxy.h:61: error: expected ')' before '*' token
e-gw-proxy.h:62: error: expected ')' before '*' token
e-gw-proxy.h:63: error: expected ')' before '*' token
e-gw-proxy.h:64: error: expected ')' before '*' token
e-gw-proxy.h:65: error: expected ')' before '*' token
e-gw-proxy.h:66: error: expected ')' before '*' token
In file included from e-gw-connection.h:30,
                 from e-gw-connection.c:33:
e-gw-container.h:27:40: error: libsoup/soup-soap-response.h: No such file or directory
In file included from e-gw-connection.h:30,
                 from e-gw-connection.c:33:
e-gw-container.h:75: error: expected ')' before '*' token
e-gw-container.h:77: error: expected declaration specifiers or '...' before 'SoupSoapParameter'
e-gw-container.h:99: error: expected ')' before '*' token
In file included from e-gw-connection.h:31,
                 from e-gw-connection.c:33:
e-gw-item.h:161: error: expected declaration specifiers or '...' before 'SoupSoapParameter'
e-gw-item.h:219: error: expected declaration specifiers or '...' before 'SoupSoapMessage'
e-gw-item.h:325: error: expected declaration specifiers or '...' before 'SoupSoapMessage'
e-gw-item.h:326: error: expected declaration specifiers or '...' before 'SoupSoapMessage'
In file included from e-gw-connection.h:32,
                 from e-gw-connection.c:33:
e-gw-filter.h:74: error: expected declaration specifiers or '...' before 'SoupSoapMessage'
In file included from e-gw-connection.h:33,
                 from e-gw-connection.c:33:
e-gw-sendoptions.h:98: error: expected ')' before '*' token
e-gw-sendoptions.h:101: error: expected ')' before '*' token
In file included from e-gw-connection.c:33:
e-gw-connection.h:97: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
e-gw-connection.h:98: error: expected ')' before '*' token
In file included from e-gw-connection.c:34:
e-gw-message.h:31: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
e-gw-message.h:32: error: expected ')' before '*' token
e-gw-message.h:34: error: expected ')' before '*' token
e-gw-message.h:40: error: expected ')' before '*' token
e-gw-message.h:44: error: expected ')' before '*' token
e-gw-message.h:47: error: expected ')' before '*' token
e-gw-connection.c: In function 'reauthenticate':
e-gw-connection.c:67: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:67: error: (Each undeclared identifier is reported only once
e-gw-connection.c:67: error: for each function it appears in.)
e-gw-connection.c:67: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:68: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:68: error: 'response' undeclared (first use in this function)
e-gw-connection.c:69: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:69: error: 'param' undeclared (first use in this function)
e-gw-connection.c:78: warning: implicit declaration of function 'e_gw_message_new_with_header'
e-gw-connection.c:79: warning: implicit declaration of function 'e_gw_message_write_footer'
e-gw-connection.c:84: warning: implicit declaration of function 'e_gw_connection_send_message'
e-gw-connection.c:90: warning: implicit declaration of function 'e_gw_connection_parse_response_status'
e-gw-connection.c:99: warning: implicit declaration of function 'soup_soap_message_start_element'
e-gw-connection.c:100: warning: implicit declaration of function 'soup_soap_message_add_attribute'
e-gw-connection.c:102: warning: implicit declaration of function 'e_gw_message_write_string_parameter'
e-gw-connection.c:104: warning: implicit declaration of function 'soup_soap_message_end_element'
e-gw-connection.c:113: warning: implicit declaration of function 'soup_soap_response_get_first_parameter_by_name'
e-gw-connection.c:115: warning: implicit declaration of function 'soup_soap_parameter_get_string_value'
e-gw-connection.c:115: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: At top level:
e-gw-connection.c:132: error: expected ')' before '*' token
e-gw-connection.c:156: error: expected ')' before '*' token
e-gw-connection.c: In function 'logout':
e-gw-connection.c:217: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:217: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:218: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:218: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_dispose':
e-gw-connection.c:254: warning: implicit declaration of function 'printf'
e-gw-connection.c:254: warning: incompatible implicit declaration of built-in function 'printf'
e-gw-connection.c: In function 'e_gw_connection_finalize':
e-gw-connection.c:361: warning: incompatible implicit declaration of built-in function 'printf'
e-gw-connection.c: In function 'e_gw_connection_init':
e-gw-connection.c:395: warning: implicit declaration of function 'atoi'
e-gw-connection.c: At top level:
e-gw-connection.c:428: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
e-gw-connection.c: In function 'e_gw_connection_new_with_error_handler':
e-gw-connection.c:450: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:450: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:451: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:451: error: 'response' undeclared (first use in this function)
e-gw-connection.c:452: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:452: error: 'param' undeclared (first use in this function)
e-gw-connection.c:484: warning: implicit declaration of function 'form_login_request'
e-gw-connection.c:500: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:503: warning: implicit declaration of function 'soup_soap_parameter_get_first_child_by_name'
e-gw-connection.c:504: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:506: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:524: warning: implicit declaration of function 'e_gw_connection_response_parse_status_and_description'
e-gw-connection.c:539: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:550: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:556: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:562: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:570: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:577: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: At top level:
e-gw-connection.c:607: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
e-gw-connection.c: In function 'e_gw_connection_get_container_list':
e-gw-connection.c:636: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:636: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:637: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:637: error: 'response' undeclared (first use in this function)
e-gw-connection.c:639: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:639: error: 'param' undeclared (first use in this function)
e-gw-connection.c:678: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:681: warning: implicit declaration of function 'soup_soap_parameter_get_next_child_by_name'
e-gw-connection.c:684: warning: implicit declaration of function 'e_gw_container_new_from_soap_parameter'
e-gw-connection.c:684: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_get_items_delta_info':
e-gw-connection.c:739: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:739: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:740: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:740: error: 'response' undeclared (first use in this function)
e-gw-connection.c:742: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:742: error: 'param' undeclared (first use in this function)
e-gw-connection.c:742: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:742: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:786: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:787: warning: implicit declaration of function 'strtod'
e-gw-connection.c:795: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:805: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_get_items_delta':
e-gw-connection.c:820: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:820: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:821: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:821: error: 'response' undeclared (first use in this function)
e-gw-connection.c:823: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:823: error: 'param' undeclared (first use in this function)
e-gw-connection.c:823: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:823: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:823: error: 'subsubparam' undeclared (first use in this function)
e-gw-connection.c:823: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:876: error: too many arguments to function 'e_gw_item_new_from_soap_parameter'
e-gw-connection.c:882: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_get_items':
e-gw-connection.c:904: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:904: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:905: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:905: error: 'response' undeclared (first use in this function)
e-gw-connection.c:907: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:907: error: 'param' undeclared (first use in this function)
e-gw-connection.c:907: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:907: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:923: error: too many arguments to function 'e_gw_filter_append_to_soap_message'
e-gw-connection.c:956: error: too many arguments to function 'e_gw_item_new_from_soap_parameter'
e-gw-connection.c: In function 'e_gw_connection_get_items_from_ids':
e-gw-connection.c:971: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:971: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:972: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:972: error: 'response' undeclared (first use in this function)
e-gw-connection.c:974: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:974: error: 'param' undeclared (first use in this function)
e-gw-connection.c:974: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:974: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:1027: error: too many arguments to function 'e_gw_item_new_from_soap_parameter'
e-gw-connection.c: In function 'e_gw_connection_get_deltas':
e-gw-connection.c:1042: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1042: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1043: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1043: error: 'response' undeclared (first use in this function)
e-gw-connection.c:1045: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:1045: error: 'param' undeclared (first use in this function)
e-gw-connection.c:1045: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:1045: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:1087: warning: passing argument 1 of 'g_ascii_strcasecmp' makes pointer from integer without a cast
e-gw-connection.c:1112: error: 'param_id' undeclared (first use in this function)
e-gw-connection.c:1136: error: too many arguments to function 'e_gw_item_new_from_soap_parameter'
e-gw-connection.c:1154: warning: implicit declaration of function 'soup_soap_parameter_get_next_child'
e-gw-connection.c:1158: error: too many arguments to function 'e_gw_item_new_from_soap_parameter'
e-gw-connection.c: In function 'e_gw_connection_send_item':
e-gw-connection.c:1174: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1174: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1175: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1175: error: 'response' undeclared (first use in this function)
e-gw-connection.c:1191: error: too many arguments to function 'e_gw_item_append_to_soap_message'
e-gw-connection.c:1208: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:1208: error: 'param' undeclared (first use in this function)
e-gw-connection.c:1213: warning: implicit declaration of function 'soup_soap_response_get_next_parameter_by_name'
e-gw-connection.c:1215: warning: passing argument 2 of 'g_slist_append' makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_create_item':
e-gw-connection.c:1229: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1229: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1230: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1230: error: 'response' undeclared (first use in this function)
e-gw-connection.c:1231: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:1231: error: 'param' undeclared (first use in this function)
e-gw-connection.c:1244: error: too many arguments to function 'e_gw_item_append_to_soap_message'
e-gw-connection.c:1263: warning: passing argument 1 of 'g_strdup' makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_modify_item':
e-gw-connection.c:1276: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1276: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1277: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1277: error: 'response' undeclared (first use in this function)
e-gw-connection.c:1291: error: too many arguments to function 'e_gw_item_append_changes_to_soap_message'
e-gw-connection.c: In function 'e_gw_connection_get_item':
e-gw-connection.c:1320: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1320: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1321: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1321: error: 'response' undeclared (first use in this function)
e-gw-connection.c:1323: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:1323: error: 'param' undeclared (first use in this function)
e-gw-connection.c:1365: error: too many arguments to function 'e_gw_item_new_from_soap_parameter'
e-gw-connection.c: In function 'e_gw_connection_remove_item':
e-gw-connection.c:1382: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1382: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1383: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1383: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_remove_items':
e-gw-connection.c:1417: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1417: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1418: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1418: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_accept_request':
e-gw-connection.c:1454: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1454: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1456: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1456: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_decline_request':
e-gw-connection.c:1489: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1489: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1491: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1491: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_retract_request':
e-gw-connection.c:1523: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1523: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1525: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1525: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_complete_request':
e-gw-connection.c:1551: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1551: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1553: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1553: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_delegate_request':
e-gw-connection.c:1578: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1578: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1580: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1580: error: 'response' undeclared (first use in this function)
e-gw-connection.c:1587: error: too many arguments to function 'e_gw_item_add_distribution_to_soap_message'
e-gw-connection.c: In function 'e_gw_connection_create_book':
e-gw-connection.c:1756: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1756: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1758: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1758: error: 'response' undeclared (first use in this function)
e-gw-connection.c:1759: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:1759: error: 'param' undeclared (first use in this function)
e-gw-connection.c:1786: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_get_address_book_list':
e-gw-connection.c:1797: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1797: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1798: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1798: error: 'response' undeclared (first use in this function)
e-gw-connection.c:1801: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:1801: error: 'param' undeclared (first use in this function)
e-gw-connection.c:1802: error: 'type_param' undeclared (first use in this function)
e-gw-connection.c:1853: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:1859: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:1865: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:1874: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_modify_settings':
e-gw-connection.c:1925: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1925: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1926: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1926: error: 'response' undeclared (first use in this function)
e-gw-connection.c:1941: warning: implicit declaration of function 'e_gw_sendoptions_form_message_to_modify'
e-gw-connection.c: In function 'e_gw_connection_get_settings':
e-gw-connection.c:1978: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:1978: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:1979: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:1979: error: 'response' undeclared (first use in this function)
e-gw-connection.c:1981: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:1981: error: 'param' undeclared (first use in this function)
e-gw-connection.c:2033: warning: implicit declaration of function 'e_gw_sendoptions_new_from_soap_parameter'
e-gw-connection.c:2033: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_get_categories':
e-gw-connection.c:2047: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2047: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2048: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2048: error: 'response' undeclared (first use in this function)
e-gw-connection.c:2051: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:2051: error: 'param' undeclared (first use in this function)
e-gw-connection.c:2051: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:2051: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:2051: error: 'second_level_child' undeclared (first use in this function)
e-gw-connection.c:2051: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:2112: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:2115: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_add_members':
e-gw-connection.c:2143: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2143: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2144: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2144: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_remove_members':
e-gw-connection.c:2187: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2187: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2188: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2188: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_create_cursor':
e-gw-connection.c:2232: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2232: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2233: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2233: error: 'response' undeclared (first use in this function)
e-gw-connection.c:2235: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:2235: error: 'param' undeclared (first use in this function)
e-gw-connection.c:2246: error: too many arguments to function 'e_gw_filter_append_to_soap_message'
e-gw-connection.c:2270: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_destroy_cursor':
e-gw-connection.c:2289: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2289: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2290: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2290: error: 'response' undeclared (first use in this function)
e-gw-connection.c:2299: warning: implicit declaration of function 'e_gw_message_write_int_parameter'
e-gw-connection.c: In function 'e_gw_connection_position_cursor':
e-gw-connection.c:2322: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2322: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2323: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2323: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_read_cursor':
e-gw-connection.c:2352: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2352: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2353: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2353: error: 'response' undeclared (first use in this function)
e-gw-connection.c:2355: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:2355: error: 'param' undeclared (first use in this function)
e-gw-connection.c:2355: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:2355: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:2399: error: too many arguments to function 'e_gw_item_new_from_soap_parameter'
e-gw-connection.c: In function 'e_gw_connection_get_quick_messages':
e-gw-connection.c:2412: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2412: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2413: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2413: error: 'response' undeclared (first use in this function)
e-gw-connection.c:2415: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:2415: error: 'param' undeclared (first use in this function)
e-gw-connection.c:2415: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:2415: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:2465: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:2483: error: 'param_id' undeclared (first use in this function)
e-gw-connection.c:2502: warning: passing argument 1 of 'g_strdup' makes pointer from integer without a cast
e-gw-connection.c:2518: error: too many arguments to function 'e_gw_item_new_from_soap_parameter'
e-gw-connection.c: In function 'e_gw_connection_create_folder':
e-gw-connection.c:2535: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2535: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2536: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2536: error: 'response' undeclared (first use in this function)
e-gw-connection.c:2537: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:2537: error: 'param' undeclared (first use in this function)
e-gw-connection.c:2566: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:2567: warning: incompatible implicit declaration of built-in function 'printf'
e-gw-connection.c: In function 'e_gw_connection_get_attachment':
e-gw-connection.c:2581: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2581: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2582: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2582: error: 'response' undeclared (first use in this function)
e-gw-connection.c:2584: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:2584: error: 'param' undeclared (first use in this function)
e-gw-connection.c:2622: warning: implicit declaration of function 'soup_soap_parameter_get_property'
e-gw-connection.c:2622: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:2623: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:2628: warning: pointer targets in passing argument 2 of 'g_base64_decode' differ in signedness
e-gw-connection.c:2628: warning: pointer targets in assignment differ in signedness
e-gw-connection.c: In function 'e_gw_connection_get_attachment_base64':
e-gw-connection.c:2648: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2648: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2649: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2649: error: 'response' undeclared (first use in this function)
e-gw-connection.c:2651: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:2651: error: 'param' undeclared (first use in this function)
e-gw-connection.c:2689: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:2690: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:2691: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_add_item':
e-gw-connection.c:2714: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2714: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2715: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2715: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_add_items':
e-gw-connection.c:2749: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2749: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2750: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2750: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_rename_folder':
e-gw-connection.c:2789: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2789: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2790: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2790: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_share_folder':
e-gw-connection.c:2832: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2832: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2833: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2833: error: 'response' undeclared (first use in this function)
e-gw-connection.c:2837: warning: implicit declaration of function 'e_gw_container_form_message'
e-gw-connection.c: In function 'e_gw_connection_move_item':
e-gw-connection.c:2860: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2860: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2861: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2861: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_accept_shared_folder':
e-gw-connection.c:2899: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2899: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2900: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2900: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_purge_deleted_items':
e-gw-connection.c:2934: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2934: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2935: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2935: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_purge_selected_items':
e-gw-connection.c:2960: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2960: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2961: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2961: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_mark_read':
e-gw-connection.c:2992: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:2992: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:2993: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:2993: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_mark_unread':
e-gw-connection.c:3027: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3027: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3028: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3028: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_reply_item':
e-gw-connection.c:3062: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3062: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3063: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3063: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3065: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:3065: error: 'param' undeclared (first use in this function)
e-gw-connection.c:3106: error: too many arguments to function 'e_gw_item_new_from_soap_parameter'
e-gw-connection.c: In function 'e_gw_connection_forward_item':
e-gw-connection.c:3119: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3119: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3120: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3120: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3122: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:3122: error: 'param' undeclared (first use in this function)
e-gw-connection.c:3166: error: too many arguments to function 'e_gw_item_new_from_soap_parameter'
e-gw-connection.c: In function 'e_gw_connection_create_junk_entry':
e-gw-connection.c:3186: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3186: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3187: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3187: error: 'response' undeclared (first use in this function)
e-gw-connection.c: At top level:
e-gw-connection.c:3224: error: expected ')' before '*' token
e-gw-connection.c: In function 'e_gw_connection_get_junk_settings':
e-gw-connection.c:3283: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3283: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3284: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3284: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3285: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:3285: error: 'param' undeclared (first use in this function)
e-gw-connection.c:3312: warning: implicit declaration of function 'parse_junk_settings'
e-gw-connection.c: At top level:
e-gw-connection.c:3323: error: expected ')' before '*' token
e-gw-connection.c: In function 'e_gw_connection_modify_junk_settings':
e-gw-connection.c:3342: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3342: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3343: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3343: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3357: warning: implicit declaration of function 'msg_add_settings'
e-gw-connection.c: At top level:
e-gw-connection.c:3385: error: expected ')' before '*' token
e-gw-connection.c:3433: error: expected ')' before '*' token
e-gw-connection.c: In function 'e_gw_connection_get_junk_entries':
e-gw-connection.c:3478: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3478: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3479: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3479: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3505: warning: implicit declaration of function 'get_junk_list_from_soap_response'
e-gw-connection.c: In function 'e_gw_connection_remove_junk_entry':
e-gw-connection.c:3517: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3517: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3518: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3518: error: 'response' undeclared (first use in this function)
e-gw-connection.c: In function 'e_gw_connection_read_cal_ids':
e-gw-connection.c:3552: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3552: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3553: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3553: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3555: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:3555: error: 'param' undeclared (first use in this function)
e-gw-connection.c:3555: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:3555: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:3599: error: 'param_id' undeclared (first use in this function)
e-gw-connection.c:3604: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:3617: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:3637: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:3648: warning: implicit declaration of function 'soup_soap_parameter_get_int_value'
e-gw-connection.c:3660: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:3685: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_get_all_mail_uids':
e-gw-connection.c:3701: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3701: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3702: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3702: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3704: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:3704: error: 'param' undeclared (first use in this function)
e-gw-connection.c:3704: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:3704: warning: left-hand operand of comma expression has no effect
e-gw-connection.c:3748: error: 'param_id' undeclared (first use in this function)
e-gw-connection.c:3763: warning: assignment makes pointer from integer without a cast
e-gw-connection.c: In function 'e_gw_connection_get_proxy_access_list':
e-gw-connection.c:3786: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3786: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3787: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3787: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3789: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:3789: error: 'param' undeclared (first use in this function)
e-gw-connection.c:3814: warning: implicit declaration of function 'e_gw_proxy_construct_proxy_access_list'
e-gw-connection.c: In function 'e_gw_connection_add_proxy':
e-gw-connection.c:3827: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3827: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3828: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3828: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3834: warning: implicit declaration of function 'e_gw_proxy_form_proxy_add_msg'
e-gw-connection.c: In function 'e_gw_connection_remove_proxy':
e-gw-connection.c:3855: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3855: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3856: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3856: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3863: warning: implicit declaration of function 'e_gw_proxy_form_proxy_remove_msg'
e-gw-connection.c: In function 'e_gw_connection_modify_proxy':
e-gw-connection.c:3882: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3882: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3883: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3883: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3890: warning: implicit declaration of function 'e_gw_proxy_form_modify_proxy_msg'
e-gw-connection.c: In function 'e_gw_connection_get_proxy_list':
e-gw-connection.c:3912: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3912: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3913: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3913: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3915: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:3915: error: 'param' undeclared (first use in this function)
e-gw-connection.c:3943: warning: implicit declaration of function 'e_gw_proxy_construct_proxy_list'
e-gw-connection.c: At top level:
e-gw-connection.c:3956: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
e-gw-connection.c: In function 'e_gw_connection_get_proxy_connection':
e-gw-connection.c:3977: error: 'SoupSoapMessage' undeclared (first use in this function)
e-gw-connection.c:3977: error: 'msg' undeclared (first use in this function)
e-gw-connection.c:3978: error: 'SoupSoapResponse' undeclared (first use in this function)
e-gw-connection.c:3978: error: 'response' undeclared (first use in this function)
e-gw-connection.c:3980: error: 'SoupSoapParameter' undeclared (first use in this function)
e-gw-connection.c:3980: error: 'param' undeclared (first use in this function)
e-gw-connection.c:3981: error: 'subparam' undeclared (first use in this function)
e-gw-connection.c:4020: warning: implicit declaration of function 'form_proxy_login_request'
e-gw-connection.c:4046: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:4056: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:4062: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:4068: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:4072: warning: implicit declaration of function 'e_gw_proxy_parse_proxy_login_response'
e-gw-connection.c:4078: warning: assignment makes pointer from integer without a cast
e-gw-connection.c:4085: warning: assignment makes pointer from integer without a cast
make[4]: *** [e-gw-connection.lo] Error 1
make[4]: Leaving directory `/home/build/svn/gnome2/evolution-data-server/servers/groupwise'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/build/svn/gnome2/evolution-data-server/servers/groupwise'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/build/svn/gnome2/evolution-data-server/servers'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/build/svn/gnome2/evolution-data-server'
make: *** [all] Error 2
Comment 8 Srinivasa Ragavan 2008-01-17 08:06:27 UTC
Over all it looks fine. The naming has to be fixed in soup-soap* but thatz minor and independent thing. But it has to be committed asap to get buffer for any bug fix. IMO: Too much change to take this late in a cycle. Commit it asap.
Comment 9 Kjartan Maraas 2008-01-17 13:18:08 UTC
I commited this since it was breaking my build.
Comment 10 Dan Winship 2008-01-17 14:56:52 UTC
(In reply to comment #8)
> IMO: Too much change to take this late in a cycle. Commit it asap.

I did ask the release team first. :-}


Comment 11 André Klapper 2008-01-17 19:29:55 UTC
(In reply to comment #10)
> (In reply to comment #8)
> > IMO: Too much change to take this late in a cycle. Commit it asap.
> 
> I did ask the release team first. :-}

my two cents:
i can only talk for myself, but i was positive about 2.4 because dan provided patches for the affected modules, because of the api cleanup, because gio will partially use it, and because sometimes gnome really has to become faster in pushing useful changes and getting more attractive to devs. and i probably wouldn't had agreed to this change if it was two weeks later in the cycle, yepp.
Comment 12 Srinivasa Ragavan 2008-01-17 19:49:29 UTC
Andre/Dan, Had that been the case (2 weeks after now), I would have raised my objection where ever required. Now, it should be Ok. 

Just my thought :) No thing against anything.