GNOME Bugzilla – Bug 509508
Add wodim support for n-c-b
Last modified: 2009-07-29 16:20:55 UTC
Nowdays with the current license of cdrtools distributors often use cdrkit the cdrtools fork in their distributions. Like brasero 0.6 series we try to find wodim by default and then try to find cdrecord in the cmd line to burn, this makes distros not using the usual symlinks from wodim->cdrecord. This code was used on brasero before we start using plugins for the burning backends. Patch attached.
Created attachment 102864 [details] [review] support for wodim
Comment on attachment 102864 [details] [review] support for wodim >Index: src/nautilus-burn-recorder.c >=================================================================== >--- src/nautilus-burn-recorder.c (revision 2117) >+++ src/nautilus-burn-recorder.c (working copy) >@@ -1062,11 +1062,19 @@ > { > static gboolean first = TRUE; > static gboolean supported; >+ gchar *prog_name; > > if (first) { > char *standard_error; > gboolean res; >- res = g_spawn_command_line_sync ("mkisofs -input-charset utf8", NULL, &standard_error, NULL, NULL); >+ >+ prog_name = g_find_program_in_path ("genisoimage"); leaking prog_name. <snip> >@@ -1369,8 +1378,14 @@ > err_line_func = cdrdao_stderr_line; > } else { > argv = g_ptr_array_new (); >- g_ptr_array_add (argv, "cdrecord"); > >+ prog_name = g_find_program_in_path ("wodim"); leaking it again. >@@ -1486,8 +1502,14 @@ > } > > argv = g_ptr_array_new (); >- g_ptr_array_add (argv, "cdrecord"); > >+ prog_name = g_find_program_in_path ("wodim"); And again. etc.
Please keep in mind: wodim is a fork created from a nearly 5 year old version of cdrtools. Wodim added many bugs that never have been in cdrtools. Wodim claims support for DVDs but it does not work. Wodim is unmaintained since May 6th 2007. Thre are at least 150 important bugs that are unfixed for years. Wodim is in conflict with the Copyright law and cannot be legally distributed. Wodimis the result of a non-cooperative downstream package maintainer. See http://cdrecord.berlios.de/private/linux-dist.html for a list of the most typical bugs in wodim. The original cdrtools are perfectly legal and actively maintained. Many bugs have been fixed during the past years and cdrtools are free of known bugs. Many new features such as working UTF-8 support, support for large files in mkisofs, a built in find(1) in mkisofs, better UDF support, support for BluRay and many other things have been added. Do you really like to give your freedom for questionable software like wodim? Do you like to give up portability?
nautilus-cd-burner has been replaced by Brasero in the GNOME 2.26 release. If your bug still applies to Brasero, please feel free to re-open the bug, and reassign it to brasero itself.
This bug report does not go away with upgrading to brasero. It is related to wodim - defective, dead and very outdated fork from cdrtools. Please always look for the latest version of the original cdrtools software.
(In reply to comment #5) > This bug report does not go away with upgrading to brasero. > It is related to wodim - defective, dead and very outdated fork > from cdrtools. > > Please always look for the latest version of the original cdrtools > software. > Yes this bug goes away with Brasero since it supports all burning tools backends. It's a matter of giving the user and distributors a choice. Personally i prefer cdrtools but still you can convince distributors to ship[1] cdrtools instead of cdrkit (which seems dead). As for Brasero we probably will recommend to use libburnia sometime in a future. 1-http://lists.opensuse.org/opensuse-factory/2009-07/msg00033.html
Thank you for mentioning the URL above! I was not aware of this.... I just updated http://cdrecord.berlios.de/private/linux-dist.html in order to match recent news. Please understand that using libburnia is a bad idea as libburnia is non portable while Brasero claims to be portable. Libburnia also only implements a small subset of the features of cdertools. BTW: I was always friendly. The problems was a non-cooperative downstream package maintainer at Debian. This maintainer does not seem to be active at Debian anymore since May 6th 2007. P.S.: I am interested in a closer discussion with all GUIs and callers of cdrtools in order to learn about their problems and in order to help them to better use my software. There was a perfect communication with the Author of XCDroast and as a result, this program was very portable and had a clean privilege separation as it did not send own SCSI commands but rather used cdrtools to do this. cdrecord has many new features that should be made visible to GUI users. cdda2wav is one of the most perfect DAE program (even compared with win only programs) and it would help a lot to use cdda2wav (and e.g. it's enhanced paranoia features) for DAE. Mkisofs hass many new features. In fact, mkisofs added 50% new code sine the time when Debian created the fork. There is build in find(1) support via libfind that could be used for many interesting new GUI features. There is UTF-8 support (missing/unusable in genisoimage) and there is much enhanced UDF support. I would be happy to see a GUI that makes the new features from the cdrtools available to the users.
(In reply to comment #7) > Please understand that using libburnia is a bad idea as libburnia > is non portable while Brasero claims to be portable. Libburnia > also only implements a small subset of the features of cdertools. > I'm happy to discuss this with other developers on brasero mailing list (brasero-list@gnome.org) which is the appropriate place. > P.S.: I am interested in a closer discussion with all > GUIs and callers of cdrtools in order to learn about their > problems and in order to help them to better use my software. > > There was a perfect communication with the Author of XCDroast > and as a result, this program was very portable and had a > clean privilege separation as it did not send own SCSI commands > but rather used cdrtools to do this. > > cdrecord has many new features that should be made visible > to GUI users. > > cdda2wav is one of the most perfect DAE program (even compared > with win only programs) and it would help a lot to use cdda2wav > (and e.g. it's enhanced paranoia features) for DAE. > > Mkisofs hass many new features. In fact, mkisofs added 50% new code > sine the time when Debian created the fork. There is build in > find(1) support via libfind that could be used for many interesting > new GUI features. There is UTF-8 support (missing/unusable in > genisoimage) and there is much enhanced UDF support. > > > I would be happy to see a GUI that makes the new features from > the cdrtools available to the users. > Thanks for your interest, we also would like to support every feature from cd burning tools. Please subscribe to brasero ML and we can start working together. Thanks Luis
Please subscribe to cdrecord-developers@lists.berlios.de see https://lists.berlios.de/mailman/listinfo/cdrecord-developers I believe that discussions that may help other GUIs or other "users/programs" for cdrtools should be in the cdrtools related environment. Brasero specific discussions however should of course be in the brasero list. I am looking forward for a collaboration that helps to get better features to the users.