GNOME Bugzilla – Bug 509438
media player keys plugin is causing gnome-settings-daemon to start
Last modified: 2008-01-16 19:04:18 UTC
When used in desktop environment other than GNOME, starting totem is autostarting gnome-settings-daemon, because of dbus magic in media player keys plugin. I've prepared a patch which only enable the plugin when gnome-settings-daemon is already running. There is still an issue with this patch, since it causes an error popup in that particular case for each startup :(
Created attachment 102839 [details] [review] don't autostart gnome-settings-daemon
Looks good, please commit to trunk.
committed on trunk 2008-01-15 Frederic Crozat <fcrozat@mandriva.com> * src/plugins/media-player-keys/totem-media-player-keys.c: Prevent autostarting gnome-settings-daemon, only enable plugin if it is running already (Closes: #509438) I'm keeping this bug open since there is now a error popup for people having this plugin enabled and starting totem not in GNOME. I guess the popup should not be displayed when plugin activation fails at startup.
Change the retval for it then :)
Ok, tested here and it works. Do you want to review the patch for this change or shall I commit it directly ? :)
(In reply to comment #5) > Ok, tested here and it works. Do you want to review the patch for this change > or shall I commit it directly ? :) You should check the error returned from dbus_g_proxy_new_for_name_owner() and only error out if the error is anything but a failure to find the service. You can commit directly to SVN, I know you'll have tested it :)
Fixed with : 2008-01-16 Frederic Crozat <fcrozat@mandriva.com> * src/plugins/media-player-keys/totem-media-player-keys.c: Do not popup error only if gnome-settings-daemon was not running (Really closes #509438).