After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 509301 - [flacdec] CVS does not compile against flac-1.1.2
[flacdec] CVS does not compile against flac-1.1.2
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal major
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-14 08:43 UTC by Laurent Glayal
Modified: 2008-01-17 21:26 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Laurent Glayal 2008-01-14 08:43:40 UTC
Is there any specific requirement (version ?) for flac ?

gstflacdec.c: In function `gst_flac_dec_setup_seekable_decoder':
gstflacdec.c:304: error: `FLAC__METADATA_TYPE_PICTURE' undeclared (first use in this function)
gstflacdec.c:304: error: (Each undeclared identifier is reported only once
gstflacdec.c:304: error: for each function it appears in.)
gstflacdec.c: In function `gst_flac_dec_setup_stream_decoder':
gstflacdec.c:337: error: `FLAC__METADATA_TYPE_PICTURE' undeclared (first use in this function)
gstflacdec.c: In function `gst_flac_extract_picture_buffer':
gstflacdec.c:615: error: `FLAC__StreamMetadata_Picture' undeclared (first use in this function)
gstflacdec.c:615: error: syntax error before "picture"
gstflacdec.c:618: error: `FLAC__METADATA_TYPE_PICTURE' undeclared (first use in this function)
gstflacdec.c:621: error: `picture' undeclared (first use in this function)
gstflacdec.c:621: error: union has no member named `picture'
gstflacdec.c: In function `gst_flac_dec_metadata_callback':
gstflacdec.c:744: error: `FLAC__METADATA_TYPE_PICTURE' undeclared (first use in this function)
Comment 1 Laurent Glayal 2008-01-15 08:11:50 UTC
I think the requirement for `FLAC__METADATA_TYPE_PICTURE' (set inside FLAC/format.c) is flac release >= 1.2, I had a 1.1.2 release.
Comment 2 Tim-Philipp Müller 2008-01-17 21:26:45 UTC
Should be fixed now:

 2008-01-17  Tim-Philipp Müller  <tim at centricular dot net>

        * ext/flac/gstflacdec.c:
          Fix compilation against flac 1.1.2 (as on debian stable), where
          the picture metadata defines and structs don't exist yet.
          Fixes #509301.


Sorry it took so long.