GNOME Bugzilla – Bug 508809
Merge SexyIconEntry
Last modified: 2008-03-02 18:21:43 UTC
There seems to have been some interest in merging libsexy into gtk+, so I'm filing bugs for individual widgets that seem merge-worthy. So first up is SexyIconEntry. I'll gtk-ify its code and post a patch soon.
Created attachment 102618 [details] [review] GtkIconEntry patch Okay, I've tried to gtkify SexyIconEntry here. One thing that I changed was that in struct _SexyIconEntry there were some reserved fields: struct _SexyIconEntry { GtkEntry parent_object; SexyIconEntryPriv *priv; void (*gtk_reserved1)(void); void (*gtk_reserved2)(void); void (*gtk_reserved3)(void); void (*gtk_reserved4)(void); }; I didn't really understand the point of this since it has a `private' struct field member. So I removed those. The other thing (that I did not change) was that `get' methods passed a const struct for the first argument to the function. That doesn't seem to be a typical thing in GTK+ code, so I felt I should point it out here and get comments. Example: GtkImage *sexy_icon_entry_get_icon(const SexyIconEntry *entry, SexyIconEntryPosition position);
Created attachment 102626 [details] [review] Minor update to previous patch Added gtkiconentry.h to gtk.h
Created attachment 102634 [details] [review] Updated patch Updating the patch to add testiconentry.c to the tests.
*** This bug has been marked as a duplicate of 85292 ***