After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 508809 - Merge SexyIconEntry
Merge SexyIconEntry
Status: RESOLVED DUPLICATE of bug 85292
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-01-11 17:55 UTC by Cody Russell
Modified: 2008-03-02 18:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GtkIconEntry patch (29.13 KB, patch)
2008-01-11 19:47 UTC, Cody Russell
none Details | Review
Minor update to previous patch (29.50 KB, patch)
2008-01-11 21:28 UTC, Cody Russell
none Details | Review
Updated patch (34.91 KB, patch)
2008-01-12 00:07 UTC, Cody Russell
none Details | Review

Description Cody Russell 2008-01-11 17:55:52 UTC
There seems to have been some interest in merging libsexy into gtk+, so I'm filing bugs for individual widgets that seem merge-worthy.

So first up is SexyIconEntry.  I'll gtk-ify its code and post a patch soon.
Comment 1 Cody Russell 2008-01-11 19:47:55 UTC
Created attachment 102618 [details] [review]
GtkIconEntry patch

Okay, I've tried to gtkify SexyIconEntry here.  One thing that I changed was that in struct _SexyIconEntry there were some reserved fields:

struct _SexyIconEntry
{
        GtkEntry parent_object;

        SexyIconEntryPriv *priv;

        void (*gtk_reserved1)(void);
        void (*gtk_reserved2)(void);
        void (*gtk_reserved3)(void);
        void (*gtk_reserved4)(void);
};

I didn't really understand the point of this since it has a `private' struct field member.  So I removed those.

The other thing (that I did not change) was that `get' methods passed a const struct for the first argument to the function.  That doesn't seem to be a typical thing in GTK+ code, so I felt I should point it out here and get comments.

Example:
GtkImage *sexy_icon_entry_get_icon(const SexyIconEntry *entry, SexyIconEntryPosition position);
Comment 2 Cody Russell 2008-01-11 21:28:24 UTC
Created attachment 102626 [details] [review]
Minor update to previous patch

Added gtkiconentry.h to gtk.h
Comment 3 Cody Russell 2008-01-12 00:07:54 UTC
Created attachment 102634 [details] [review]
Updated patch

Updating the patch to add testiconentry.c to the tests.
Comment 4 Johan (not receiving bugmail) Dahlin 2008-03-02 18:21:43 UTC

*** This bug has been marked as a duplicate of 85292 ***