After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 508564 - Shouldn't there be a GError argument in g_file_monitor_directory and g_file_monitor_file?
Shouldn't there be a GError argument in g_file_monitor_directory and g_file_m...
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Alexander Larsson
gtkdev
Depends on:
Blocks:
 
 
Reported: 2008-01-10 17:27 UTC by Jan Arne Petersen
Modified: 2008-01-14 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (8.24 KB, patch)
2008-01-12 15:35 UTC, Jan Arne Petersen
none Details | Review
patch for gvfs (4.79 KB, patch)
2008-01-14 10:29 UTC, Jan Arne Petersen
none Details | Review

Description Jan Arne Petersen 2008-01-10 17:27:09 UTC
There isn't a GError argument in g_file_monitor_directory and g_file_monitor_file.
Comment 1 Alexander Larsson 2008-01-11 08:19:08 UTC
I'm not sure. I initially didn't add one because it can fail for only one reason: "not supported". But maybe it should have one just to be consistent.
Comment 2 Jan Arne Petersen 2008-01-11 09:20:28 UTC
What about the reason "cancelled" (in GDaemonFile)?
Comment 3 Jan Arne Petersen 2008-01-12 15:35:44 UTC
Created attachment 102663 [details] [review]
Proposed patch
Comment 4 Jan Arne Petersen 2008-01-14 10:29:53 UTC
Created attachment 102798 [details] [review]
patch for gvfs
Comment 5 Alexander Larsson 2008-01-14 15:05:06 UTC
commited