GNOME Bugzilla – Bug 508555
enable browser for all sources by default
Last modified: 2018-05-24 13:05:20 UTC
The summary says it all. The applied 1-line-patch does improve the default behaviour of rb by showing the user the browser right away for all sources. A user will be able to search the music-collection of a selected source by simple pointing- and clicking-actions without the need to enter search key-words via the keyboard. Not everybody is a geek and can touch-type :)
Created attachment 102526 [details] [review] patch to implement browser by default
Argl, the patch does apparently not work for someone else who tested it. I'm looking into it.
Comment on attachment 102526 [details] [review] patch to implement browser by default --- rhythmbox/plugins/mtpdevice/rb-mtp-plugin.c 2007-12-26 13:00:08.000000000 +0100 +++ rhythmbox-new/plugins/mtpdevice/rb-mtp-plugin.c 2008-01-11 04:02:30.000000000 +0100 @@ -241,6 +241,7 @@ RBSource *source; source = RB_SOURCE (rb_mtp_source_new (plugin->shell, device, udi)); + rb_source_browser_toggled (source, TRUE); rb_shell_append_source (plugin->shell, source, NULL); plugin->mtp_sources = g_list_prepend (plugin->mtp_sources, source); --- rhythmbox/plugins/ipod/rb-ipod-plugin.c 2008-01-11 03:58:27.000000000 +0100 +++ rhythmbox-new/plugins/ipod/rb-ipod-plugin.c 2008-01-11 04:01:02.000000000 +0100 @@ -203,7 +203,7 @@ if (rb_ipod_is_volume_ipod (volume)) { RBSource *src; src = RB_SOURCE (rb_ipod_source_new (plugin->shell, volume)); - + rb_source_browser_toggled (src, TRUE); plugin->ipod_sources = g_list_prepend (plugin->ipod_sources, src); g_signal_connect_object (G_OBJECT (src), "deleted", G_CALLBACK (rb_ipod_plugin_source_deleted),
Created attachment 102566 [details] [review] hopefully corrected version of the previous patch
Created attachment 102656 [details] [review] change default browser visibility for sources that don't store it in gconf I think it would be better to improve browser state tracking. If we committed a patch like this, I'd probably find it annoying to have the browser visible by default on all my playlists. For the device-based sources, we should just add gconf keys - /apps/rhythmbox/plugins/ipod/browser_visible for ipods etc. For the minority who have multiple devices of one kind, are they really going to want the browser shown for one device but not another? We'd need to do something smarter for playlists, though. Storing state in gconf doesn't seem right to me, though. Should it be stored in the playlists file?
For ipods, what about having /apps/rhythmbox/plugins/ipod/XXXXXXX-state/browser_visible keys, with XXXXXXX being the device serial number ? Actually, something that might be better, but is ipod specific, is to store the "browser visible" preference on the ipod, I'm pretty sure there's a field for that in the ipod database (itunes uses it)
Created attachment 103456 [details] [review] proper browser-state handling for ipod/mtp-devices (via gconf)
I've been trying my patch for a while, and it's really quite annoying. The patch for ipod/mtp sources looks OK, except perhaps the gconf keys should be under plugins/ipod/ and plugins/mtp/. I haven't tested it, as I don't have an ipod or an mtp device that works.
Other plugins save their UI-state under /apps/rhythmbox/state/<plugin> too (e.g. daap, iradio, library, podcast). Thus I'm only sticking to encountered conventions instead of introducing new ones and scattering stuff all over the place.
That's true, but it's that way because we started using those keys before daap and iradio became plugins. I think we should try to keep plugins contained so that conflicts are impossible, but it's probably not worth the effort of moving already established gconf keys.
Committed. Not sure why I left this lying around for so long..
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/491.