GNOME Bugzilla – Bug 508175
GST_TIMEVAL_TO_TIME() and GST_TIMESPEC_TO_TIME() need to be cast to GstClockTime
Last modified: 2008-01-09 12:22:22 UTC
Please describe the problem: The macros GST_TIMEVAL_TO_TIME() and GST_TIMESPEC_TO_TIME() need to cast their generated values to GstClockTime. Otherwise one will get a warning like gstrtspconnection.c:266: warning: signed and unsigned type in conditional expression when using a construct like to = timeout ? GST_TIMEVAL_TO_TIME (*timeout) : GST_CLOCK_TIME_NONE; since timeout->tv_sec and timeout->tv_usec are longs... Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 102427 [details] [review] Make GST_TIMEVAL_TO_TIME() and GST_TIMESPEC_TO_TIME() cast to GstClockTime
Patch by: Peter Kjellerstedt <pkj axis com> * gst/gstclock.h: Cast the results from the timeval/spec_to_time macros to what the docs say it casts to, a GstClockTime. fixes #508175.