After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 508057 - [PATCH] fixes behaviour of Page Up key
[PATCH] fixes behaviour of Page Up key
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-08 13:55 UTC by Peter Collingbourne
Modified: 2018-05-22 13:19 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Fixes Page Up bug (409 bytes, patch)
2008-01-08 13:57 UTC, Peter Collingbourne
none Details | Review
Fixes Page Up bug v2 (454 bytes, patch)
2008-01-17 18:36 UTC, Peter Collingbourne
needs-work Details | Review

Description Peter Collingbourne 2008-01-08 13:55:11 UTC
Please describe the problem:
When scrolling a document up in non-continuous mode using the Page Up key and you are at the top of the page you would normally expect the document viewer to show you the bottom of the previous page.  In fact this is implemented in ev-view.c lines 636-662.  However due to a bug Evince will reset the current scroll position when the new page is displayed to a few pixels from the top (which may be useful for scrolling up multiple pages but is doubly infuriating as you now have to page up twice to see the previous page).  The attached patch fixes that bug.  Applies to svn trunk

Steps to reproduce:
1. Load a document with 2 or more pages
2. go to top of page 2
3. hit Page Up


Actual results:
Evince goes to top of page 1

Expected results:
Evince goes to bottom of page 1

Does this happen every time?
yes

Other information:
Comment 1 Peter Collingbourne 2008-01-08 13:57:05 UTC
Created attachment 102391 [details] [review]
Fixes Page Up bug
Comment 2 Nickolay V. Shmyrev 2008-01-17 17:32:13 UTC
hm, we probably just need a case which will check if continuous mode is enabled.
Comment 3 Peter Collingbourne 2008-01-17 18:36:50 UTC
Created attachment 103081 [details] [review]
Fixes Page Up bug v2

Handles continuous mode correctly when using the toolbar.
Comment 4 Carlos Garcia Campos 2008-01-22 17:20:01 UTC
Hi Peter, thank you for the patch. I still see a problem. When clicking on next/prev button in the toolbar it should go to the top of the page. 
Comment 5 Komka Péter 2012-12-14 23:20:08 UTC
This very basic bug still exist (evince 3.2.1).
Please correct it.

The issue is not the "next/previous page". That works. Even the Ctrl-PgUp and Ctr-PgDn works.
The issue is the - how do you call it - "next/previous page-part (view)". PgDn works (though a few pixels odd - behaves as if Ctrl-PgDn was pressed), but PgUp DOES NOT WORK. (The PageUp key (every second hit) works as if Ctrl-PgUp was pressed.)

(I do not use the patch.)

Why I think it is basic? It is about moving around in a pdf. The first steps of a pdf-user (with not huge monitor) is hitting PageDowns, and PageUps. Reading the pdf. And moving backward sometimes. 1 pdf page = 2 views. Top half of a page, bottom half of a page.
"Continuous" mode leads to asynchronity, wide margins and headers-footers on the middle of the screen.
Comment 6 Anuj Khare 2014-02-28 09:47:48 UTC
Hello, this issue does not occur for me in the latest evince v3.11.90.

I think it has been resolved.
Comment 7 Germán Poo-Caamaño 2015-10-16 19:07:47 UTC
Still valid (3.18).
Comment 8 GNOME Infrastructure Team 2018-05-22 13:19:34 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/50.