After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 507584 - gio: gstgiobasesrc.c does not compile with CVS version of GLib
gio: gstgiobasesrc.c does not compile with CVS version of GLib
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-06 01:50 UTC by Simon Holm Thøgersen
Modified: 2008-01-06 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Simon Holm Thøgersen 2008-01-06 01:50:35 UTC
The compile fails in ext/gio with

gstgiobasesrc.c:192: warning: implicit declaration of function 'g_memory_input_stream_get_data_size'

The function has been removed from the CVS version of GLib, see bug #506374. I'm not sure if the functionality should be requested to be brought back, if it is available through another mechanism, or gst_gio_base_src_get_size should just return FALSE for GMemoryInputStream.

I've CC'ed Christian Kellner (original author of GLib's gio/gmemoryinputstream.c) and Alexander Larsson and Matthias Clasen (involved in the API change).
Comment 1 Matthias Clasen 2008-01-06 03:37:45 UTC
If you need it, we can bring it back.
Comment 2 Matthias Clasen 2008-01-06 07:15:45 UTC
Of course, gmemoryinputstream is seekable, so you can just use seek/tell to find the same information.
Comment 3 Sebastian Dröge (slomo) 2008-01-06 11:44:21 UTC
Using seek/tell is probably how we can solve it then... for all GSeekables and not only GMemoryInputStream.

I'll care for that later...
Comment 4 Sebastian Dröge (slomo) 2008-01-06 16:36:28 UTC
Ok, done:

2008-01-06  Sebastian Dröge  <slomo@circular-chaos.org>

        * configure.ac:
        * ext/gio/gstgiobasesrc.c: (gst_gio_base_src_get_size):
        * tests/check/pipelines/gio.c: (free_input), (GST_START_TEST):
        Update to GMemoryInputStream API changes in GLib SVN and require
        gio-2.0 >= 2.15.1 for this. Fixes bug #507584.
        We can also report the duration for every GSeekable, not only
        GFileInputStream and GMemoryInputStream.