After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 507239 - File menu, New note and new notebook icons
File menu, New note and new notebook icons
Status: RESOLVED OBSOLETE
Product: tomboy
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-04 12:09 UTC by Michael Monreal
Modified: 2009-05-23 10:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Mockup (45.84 KB, image/png)
2008-01-04 12:10 UTC, Michael Monreal
  Details
We also need a "New Notebook" icon that's dialog sized (17.24 KB, image/png)
2008-01-04 22:02 UTC, Boyd Timothy
  Details
Shows the notebook icon in the toolbar (44.90 KB, image/png)
2008-01-04 22:04 UTC, Boyd Timothy
  Details
Updated Create New Notebook Dialog (21.00 KB, image/png)
2008-01-04 22:25 UTC, Boyd Timothy
  Details
Notebook (16x16) (563 bytes, image/png)
2008-01-28 23:37 UTC, Michael Monreal
  Details
Icons pack (26.55 KB, application/x-gzip)
2008-01-29 15:20 UTC, Michael Monreal
  Details
tomboy note images (73.29 KB, application/zip)
2008-01-29 19:02 UTC, James Hancock
  Details
Idea (12.88 KB, image/png)
2008-01-30 00:52 UTC, Michael Monreal
  Details
Images for the view unfiled note icon (14.10 KB, application/zip)
2008-01-30 04:55 UTC, James Hancock
  Details
Patch (14.36 KB, patch)
2008-01-30 23:03 UTC, Michael Monreal
none Details | Review
Icons (161.42 KB, application/x-gzip)
2008-01-30 23:05 UTC, Michael Monreal
  Details

Description Michael Monreal 2008-01-04 12:09:42 UTC
In the menu, the following entries have the same icon:

# create a new note
# expand notebook menu
# create a new notebook
# create a new note inside a given notebook

They all use the gtk-new icon. With over-use like this, the icon is not helpful anymore. It would be nice if "new note" and "new notebook" could have different icons. The notebook submenu should not have an icon at all.

A related issue: right now note and notebook actions are grouped under the "File" menu. Perhaps it would make more sense to actually have "Note" and "Notebook" menus instead of "File":


Note
========
New Note
New Note in Notebook >
--------
Place in Notebook >
--------
Open
Delete
--------
Close


Notebook
========
New Notebook
--------
Delete


This would allow to place some actions into the menu that are currently not possible to do using the menu (placing the selected note into a notebook)
Comment 1 Michael Monreal 2008-01-04 12:10:43 UTC
Created attachment 102104 [details]
Mockup

This is how tomboy could look like compared to what it looks like right now (only icons, no menu changes)
Comment 2 Boyd Timothy 2008-01-04 18:15:53 UTC
I agree.  Having different icons would make things a lot more clear.  I've sent an email to the tango-artists mailing list asking for help.
Comment 3 Boyd Timothy 2008-01-04 22:02:45 UTC
Created attachment 102170 [details]
We also need a "New Notebook" icon that's dialog sized
Comment 4 Boyd Timothy 2008-01-04 22:04:03 UTC
Created attachment 102171 [details]
Shows the notebook icon in the toolbar

I'm just including this for reference.  When a note is inside of a given notebook, the notebook toolbar button will show the name of that notebook.  Should the icon be different for when a note isn't in any notebook?
Comment 5 Boyd Timothy 2008-01-04 22:25:20 UTC
Created attachment 102172 [details]
Updated Create New Notebook Dialog
Comment 6 Michael Monreal 2008-01-09 10:43:31 UTC
I see a problem with the current notebook terminology that affects how these icons will turn out:

Tomboy traditionally tries to mimic post-it notes. Those are quite different in how they work from a notebook. The current design suggests that you put post-it notes into a notebook, which is kind of strange (having a white notebook and create yellow notes inside etc).

So one way would be to change away from the sticky-notes look and use white notebook pages for all notes. But this would destroy a part of tomboy's identity.

But: the notebook itself is just meant to be a collection of post-it notes. How are post-it notes managed in reality? You normally stick them somewhere, most people have some kind of board for this. Now, wouldn't it make more sense to change "notebook" into "noteboard"? This way, everything would work the same in tomboy, but you would use a metaphor that actually matches reality.

As an idea for a possible icon for such boards, have a look at the favicon of ReviewBoard¹.

[1] http://www.review-board.org/
Comment 7 Boyd Timothy 2008-01-10 20:19:13 UTC
(In reply to comment #6)
Even though the Post-It -> Notebooks does not make sense, I believe a "Notebook" is much more easy to understand than a "Noteboard".  We'll see, but I think most users should have an easy time understanding what a notebook means.
Comment 8 Kalle Persson 2008-01-11 11:10:46 UTC
Cheers, here's a 16x16 px note-new icon. A notebook-new in 16x16 and 48x48px is underway.
Comment 9 Kalle Persson 2008-01-11 11:14:24 UTC
Sorry, forgot to post the link: http://nemus.se/tango/tomboy/note-new.png
Comment 10 Kalle Persson 2008-01-11 12:31:24 UTC
Here are the notebook-new icons. 16x16 followed by 48x48:
- http://nemus.se/tango/tomboy/notebook-new-16x16.png
- http://nemus.se/tango/tomboy/notebook-new-48x48.png

Opinions are welcome!
Comment 11 Michael Monreal 2008-01-12 19:14:55 UTC
I love both of the notebook-new icons, great work!

As for note-new, It is probably as good as it can be, but yellow on yellow is still a bit hard to make out. 

We could test how the new notebook icons look like in the menu together with the gtk-new icons currently in use for note-new. If we have the white/yellow paper mixup anyway, we can just as well do it this way and save one custom icon IMHO.
Comment 12 Boyd Timothy 2008-01-14 20:07:10 UTC
(In reply to comment #10)
> Here are the notebook-new icons. 16x16 followed by 48x48:
> - http://nemus.se/tango/tomboy/notebook-new-16x16.png
> - http://nemus.se/tango/tomboy/notebook-new-48x48.png
> 
> Opinions are welcome!
> 

Cool!  Any chance you can provide this in 22x22 as well?
Comment 13 Michael Monreal 2008-01-28 23:37:49 UTC
Created attachment 103920 [details]
Notebook (16x16)

As per IRC, the menus should use GTK_ICON_SIZE_MENU. Here's a 16x16 "Notebook" icon.

Notebook-new: http://nemus.se/tango/tomboy/notebook-new-16x16.png
Note-new: http://nemus.se/tango/tomboy/note-new.png
Comment 14 Michael Monreal 2008-01-28 23:42:28 UTC
As a reference, the current icon for "Notebooks->New $notebookname Note" should be note-new, not notebook-new (in both the search and tray menus)
Comment 15 Michael Monreal 2008-01-29 15:20:54 UTC
Created attachment 103961 [details]
Icons pack

This is the complete icons pack from kallepersson (16x16 notes-new, notebook, notebook-new as well as notebook-new in 48x48). Contains both the rendered png as well as the svg source.
Comment 16 James Hancock 2008-01-29 19:02:47 UTC
Created attachment 103978 [details]
tomboy note images
Comment 17 James Hancock 2008-01-29 19:05:02 UTC
Since A notebook is created of a bunch of notes, and notes are yellow. It did not seem a notebook should be white, so I tried out a yellow version. I attached the svgs and some pngs.

Let me know what you think
http://bugzilla.gnome.org/attachment.cgi?id=103978
Comment 18 Michael Monreal 2008-01-29 19:15:08 UTC
As you can read in the previous comments we already had this discussion.

Basicly I don't know of many yellow paper ring notebooks and the yellow notes tomboy symbolizes are not ring-notebook pages but post-its.

As for the icons themselves, the rings of the notebook look a bit blurry and the "new" emblem normally used in GNOME is a yellow star, not just a glow. I like Kalle's icons better and we actually have all required sizes of those.
Comment 19 Michael Monreal 2008-01-30 00:52:55 UTC
Created attachment 103999 [details]
Idea

How about this?

All notes: tomboy logo without pen
Unfiled notes: notbook with the known no/none/off/disabled emblem

I would also add a small separator line between the buildin "filters" and the actual notebooks (like the gtk filechooser has before the bookmarks)
Comment 20 James Hancock 2008-01-30 04:55:32 UTC
Created attachment 104004 [details]
Images for the view unfiled note icon
Comment 21 Michael Monreal 2008-01-30 23:02:35 UTC
As said on IRC I redid the icon installation stuff for tomboy. A new data/icons/ folder, icon names similar to the icon spec names and also included are all the sources (svg or xcf).

I fixed the code to use the new icon names, correct sizes and added support for reading icons from a private icon dir. There's still one bug, the note-new icon does not work, see Tomboy/ActionManager.cs... I guess the icon_theme is not accessible from there, but I'm to tired to fix this, so if someone could review...

This would also fix 470434.
Comment 22 Michael Monreal 2008-01-30 23:03:11 UTC
Created attachment 104078 [details] [review]
Patch
Comment 23 Michael Monreal 2008-01-30 23:05:26 UTC
Created attachment 104079 [details]
Icons

Apply the patch, delete data/images and extract this tar to data/. The bug and mail icons are used in addons, so I kept them in images/, they are still used as ressources, which probably makes sense when distributing addon dlls.
Comment 24 Michael Monreal 2008-02-06 13:14:35 UTC
The menu icons still have the wrong size in SVN. With the release nearing and documentation/translation teams needing to take new screenshots, this should be fixed ASAP, even if you don't take my patch from above.
Comment 25 Kevin Kubasik 2008-02-06 19:30:13 UTC
ok, so maybeI did something wrong, but the new tomboy note icon never shows up with this patch, once that is fixed, I will gladly commit, but were in a UI freeze, updating some icons should be ok, but causing regressions is a no-no.
Comment 26 Michael Monreal 2008-02-06 20:14:54 UTC
(In reply to comment #25)
> ok, so maybeI did something wrong, but the new tomboy note icon never shows up
> with this patch, once that is fixed, I will gladly commit, but were in a UI
> freeze, updating some icons should be ok, but causing regressions is a no-no.
> 

Yeah... see my comment 21. Sadly I do not have much time to look into this, I think it's an easy fix fut I'm not familiar with the tomboy codebase... can you make sure icon_theme is accessible in Tomboy/ActionManager.cs?
Comment 27 Boyd Timothy 2008-02-26 19:15:32 UTC
Setting the default assignee and QA Contact to "tomboy-maint@gnome.bugs".
Comment 28 Benjamin Podszun 2009-05-22 22:43:18 UTC
This bug is old and I see different icons for
# create a new note (yellow note with a star in the upper right corner)
# expand notebook menu (white notebook)
# create a new notebook (white notebook with a star in the upper right corner)
# create a new note inside a given notebook (same as create note)

I would argue that this is fixed. Comments?
Comment 29 Michael Monreal 2009-05-23 04:26:16 UTC
(In reply to comment #28)
> I would argue that this is fixed. Comments?

I agree.

Comment 30 Benjamin Podszun 2009-05-23 10:17:03 UTC
Closing as OBSOLETE - this seems to be fixed for quite a while already.