GNOME Bugzilla – Bug 507101
New UI for logout/shutdown dialogs
Last modified: 2011-08-27 04:21:58 UTC
openSUSE made kickass patch to make our life easier, with great usability thinking. they merged logout and shutdown (probably by gnome-session-save --kill) in their menu applet, but they changed dialog shown by default to more usable solution. Other information: screenshot: http://www.flickr.com/photo_zoom.gne?id=1166181703&size=o
Created attachment 102062 [details] [review] change dialogs appearance
Created attachment 106408 [details] [review] Updated Patch for 2.21.93 I updated the patch for v2.21.93. No code changes. One Question: How do I use that logout-dialog by default? I'm still having the other one (from the panel I think).
Hmmm. They use libssui [ http://code.google.com/p/libssui/ ] but it doesn't matter. Our session ending dialogs need lifting. Esp. the "gnome-session-save --kill" dialog. Checkboxes and button aren't good approach.
Created attachment 106412 [details] [review] Patch for choosing session dialog (for gnome-panel) This patch is taken from the ubuntu gnome-panel package. It creates a new gconf-key (/apps/panel/global/upstream_session) and modify the logout-applets, to use it. If true, it uses the old logout-dialog, if false the "gnome-session-remove --kill" one. You have to patch Gnome-Panel with this patch. Hmm, you should go to the mailinglist to talk with the devs, to include your patch upstream.
I am not sure if mine patch does what I want... Honestly... I guessed that this is the one. I leave the patching to you, since you have some experience...
>> I am not sure if mine patch does what I want... It changes the default gnome-session session-dialog by the one in the screenshot. I thought this is what you wanted? By default the panel does not use that logout dialog. You need to patch the panel with the patch from ubuntu, and _then_ your patch becomes usefull, 'cause then the new session-dialog will be used. (unless you change the gconf-key /apps/panel/global/upstream_session to true). Without that patch you can't enjoy the new session-dialog. You should give it a try.
> It changes the default gnome-session session-dialog by the one in the > screenshot. > I thought this is what you wanted? Yes, it is what I want :) . > By default the panel does not use that logout dialog. You need to patch the > panel with the patch from ubuntu, and _then_ your patch becomes usefull, 'cause > then the new session-dialog will be used. (unless you change the gconf-key > /apps/panel/global/upstream_session to true). Without that patch you can't > enjoy the new session-dialog. You should give it a try. I'm counting on stability for now... I only hope GNOME can do some lifting for those dialogs...
currently is feature freeze, the patches will (if they will) at the earliest included in v2.23/2.24
2.23.x released, 2.24.0 will be soon, so those patches will probably land in 2.26.0 or 2.28.0. which release is the 3.0?
Created attachment 117707 [details] [review] Updated logout/shutdown dialogs I've rewritten the dialogs for the new gnome-session. I'd like to have this in 2.24, but we have to move fast: + this is a UI change that needs approval (would need feedback from the doc team) + it introduces new strings + it'd be nice to use the same icons as gpm for suspend/hibernate, but we can't :/ Right now, it's using a sleep icon that's probably brought by libssui.
Thanks Vincent. I like the look of this. - Patch seems to be missing test-logout.c. - I'm not sure about using the term "suspend" in the description of the user-switch action. The term is pretty overloaded already. - Maybe the gsm_new_tile etc functions need a bit more namespacing. Not sure what exactly though. Once we decide on the exact new strings to use I'm in favor of getting this in for 2.24.
Created attachment 117732 [details] [review] Updated patch Fix namespace problems and add missing test-logout.c I kind of agree with your comment on Suspend in the switch user context. I can't think of a good string, though. The main issue for me really is the icons, especially the suspend/sleep icon. I can't find a good one. Maybe we can install the gpm ones in hicolor, though? Or maybe we could add the gpm icon theme path to the pathes we looked at?
Right. We have a similar problem in GDM. We've used the pause button but that is very good. The g-p-m icons are really terrible though. The ones I've seen look like a RAM card for Suspend and a disk with "zzz" over it. Yuck. I guess we should ask the artists about this.
Created attachment 117733 [details] Screenshot of lot out
Created attachment 117734 [details] Screenshot of shut down Just attaching the screenshots for freeze break request. I'm going to send a mail now, to get approval ASAP.
Changed version to 2.23.x, since you want it for 2.24.x. Change if needed. BTW, that log out/shutdown UI is great and when it's ready in GNOME 2.24.x, I will be having a party - such nice feature moved from downstream to upstream, to share goodness of open source. Very nice!
What's missing in contrast to libssui is the nice desaturation effect in the background. Any chance to get this back? Besides that: patch is working fine and a big improvement imho
(In reply to comment #17) > What's missing in contrast to libssui is the nice desaturation effect in the > background. Any chance to get this back? Not 100% sure we'll want this, but it's easy to add it back (it was there in previous gnome-session too). The problem is that it's weird to desaturate, click "log out" and then come back to a normal desktop because the operation is inhibited in some way. Don't know...
Also, doing this effect would mean that clicking the help button closes the dialog. We probably don't want this.
Created attachment 117818 [details] [review] Updated patch This fixes some minor issues. It won't be in 2.23.91 since I didn't get the second release team approval. Now we'll have to ask for string freeze break :/
Have to say it's really a bit scary how we continue to make this so much more complicated than (say) Mac OS X, which just has four simple menu items: Sleep, Restart, Shut Down, Log Out*. No big intimidating dialog, no wads of prose to read through, no buttons that don't look like buttons, just a plain, simple confirmation dialog for each menu option. Maybe I'm missing something, but I really don't get our constant fascination with trying to copy the Windows logout debacle instead :/ * Ok, I admit it has the advantage of just doing a hibernate+sleep at the same time, by default. But that's a relatively new feature.
*** Bug 550606 has been marked as a duplicate of this bug. ***
Small suggestions as requested: 1. I doubt the wordiness of "Log Out of the Session" and "Shut Down the Computer" in the titles provides any benefit. I suggest just "Log Out" and "Shut Down". 2. For "Log Out", "Shut Down", and "Restart", that each of them "Ends your session" probably isn't as important as that it "Closes all programs". The latter is important to know if you're using any programs incapable of perfectly maintaining state across sessions (such as all existing Web browsers). 3. Someone choosing "Switch User" intends that the computer should switch from one account to another, which usually (but not always) belongs to a different user. This task isn't completed by clicking the button: you then need to choose the account you want to switch to. Therefore, the label should end with an ellipsis: "Switch Account…". 4. The concluding text should not use italics. (A common Gnome mistake.) 5. The concluding text is too far to the right in the logout dialog (compare with the same text in the shutdown dialog). 6. There doesn't seem to be any point in putting the current account's name in quotes. It's almost always going to be a simple name, not a many-word phrase with possible awkward grammar like a filename sometimes has. 7. "will be automatically logged out" and "will be automatically shut down" are split infinitives, and "This system will be automatically shut down" raises the question "by what?". I suggest "will log out automatically" and "will shut down automatically". 8. That the countdown updates only once every ten seconds for the first 30 seconds is a thoughtful way of avoiding distraction, but it misled me into assuming that it wasn't a countdown at all, so that I had no idea whether the logout/shutdown was 58 seconds or 1 second away. Perhaps the same avoidance of distraction could be achieved by smoothly fading the number from one value to the next. 9. The current layout leave the "Cancel" button with no option but to end up rightmost, which is the wrong place. I don't have any good suggestions for fixing this in a small way. I agree with Calum that it's depressing that we present so many quit options. Fixing that requires coordinated work in the kernel, GDM, gnome-session, and the panel.
Also, "Switch User" doesn't, to me at least, make any sense in the log out dialog. I don't know if it's an improvement over stock GNOME or not since I haven't tested it in a while. And yes, I agree with Calum and Matthew. This is still much more complicated than it needs to be. But the only thing that requires any coordination with the kernel is "Sleep", right? Maybe it would be ok to have a little more complicated dialog for Hibernate/Suspend until that is fixed.
Created attachment 118735 [details] Sleep icon used in openSUSE Attaching the sleep icon used in openSUSE (we don't have any such icon upstream), as requested by Sebastien on IRC. It'd be better to use the g-p-m icon, but it's not installed in hicolor at the moment.
Created attachment 121007 [details] [review] Updated patch Small update for the latest releases.
Created attachment 121009 [details] [review] Real updated patch ;-) Attached the wrong file :-)
The thing I hate most about these new-style dialogs is what mpt pointed out further up: Why do we have to use pseudo-buttons that don't look like buttons ?
Created attachment 129417 [details] [review] Updated patch for 2.25.91 I updated the patch to apply to 2.25.91 -- although it needs some testing I guess. I didn't fix any of Matthew's comments, but I'll try to do this for 2.27.
Any news on this? OpenSuSE is still shipping this but users from other distributions also want new UI :-) Thanks a lot
Created attachment 177734 [details] [review] fix deprecated call, building with gtk 2.91.7
I guess this is obsolete now with Gnome3 arriving?