Bug 507020 – [rtpjitterbuffer] unreffing peeked buffer and not popping it -> double unref

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 507020 - [rtpjitterbuffer] unreffing peeked buffer and not popping it -> double unref


Summary:	[rtpjitterbuffer] unreffing peeked buffer and not popping it -> double unref


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-bad
Version:	git master
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	0.10.6
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-01-03 13:40 UTC by Aurelien Grimaud
Modified:	2008-01-04 18:48 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
valgrind log (2.75 KB, text/plain) 2008-01-03 13:43 UTC, Aurelien Grimaud	Details

Description Aurelien Grimaud 2008-01-03 13:40:41 UTC

Please describe the problem:
In gst_rtp_jitter_buffer_loop, when flushing, the buffer previously peeked from queue is unreffed but not removed from queue.
When jitterbuffer is destroyed, queue is cleared and buffer is unreffed a second time.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:

Comment 1 Aurelien Grimaud 2008-01-03 13:43:06 UTC

Created attachment 102047 [details]
valgrind log

Comment 2 Wim Taymans 2008-01-04 18:48:13 UTC

Thanks!

        * gst/rtpmanager/gstrtpjitterbuffer.c:
        (gst_rtp_jitter_buffer_loop):
        Don't unref the popped buffer when we don't have ownership.
        Fixes #507020.