GNOME Bugzilla – Bug 506778
Tangofy time-admin icon
Last modified: 2008-02-22 11:42:59 UTC
time-admin of gnome-system-tools still uses a non tango icon. Maybe also an idea to add a preferences-date-time to the icon spec.
Thanks for reporting, anyway application icons should be shipped by the applications not by g-i-t, reassigning.
Created attachment 104256 [details] Icons package Here's the icons for time-admin.
Created attachment 104286 [details] [review] Patch to existing files to use new icon
Created attachment 104287 [details] icons of Lapo with Makefiles Just untar this in the root of gnome-system-tools Permission to apply the patch and add icons to SVN?
Hi, can somebody look at this patch. Would be nice to get this in before 2.22!!
I'd tend to think this is a UI change, so we could need confirmation from the release team [1], could you please mail them? If they're ok, you're more than welcome to commit a patch. Regarding the patch, there are already icons in g-s-t/pixmaps/ that are installed in hicolor, so I'd recommend to use that same directory for the time-admin icons. If it's necessary, you can move irda.png and plip.png to g-s-t/pixmaps/48x48/ Thanks! [1] according to http://live.gnome.org/ReleasePlanning/Freezes
Carlos, I think it's cleaner to have icons and pixmaps in different directory. My suggestion is to move irda en plip to the icons directory. Furthermore it's probably easier if we put all icons in the same dir and have the filenames indicate what the icons are. You would get icon names like hicolor_apps_16x16_time_admin.png which get installed as hicolor/apps/16x16/time_admin.png See for instance http://svn.gnome.org/viewvc/vinagre/trunk/data/icons/ Advantage is that you only have one makefile and you have unique file names. So confusions of files will not be likely to occur. Do you agree? Thanks Jaap
I'm ok with moving icons then to g-s-t/icons, I just thought it'd be silly to have a directory for just one file (world_map-960.png). Regarding not using subdirs in icons, I'm not sure whether it's a good idea, the automake rules get too hand-crafted and too cryptic, see http://svn.gnome.org/viewvc/vinagre/trunk/data/icons/Makefile.am?revision=89&view=markup, for example. The subdirs approach seems more natural to me.
OK, I'll keep the subdirs
so if i'm right the following user-doc screenshots are affected? C/figures/time-tool-automatic.png C/figures/time-tool-manual.png C/figures/time-map.png C/figures/time-servers.png the "GST Time Setup Manual" has localized screenshots for Swedish (sv), Spanish (es), French (fr), Catalan (ca). :-/
Andre, You are right. I can update these as well Jaap
Fixed in SVN. I only did not update the spanish screenshot because many of the translations are not up to date. I'll ask the spanish translators if they can update it. I'll make new screenshots for spanish after that.
*** Bug 400609 has been marked as a duplicate of this bug. ***