GNOME Bugzilla – Bug 506752
--font doesn't work
Last modified: 2008-03-23 13:02:07 UTC
$ gucharmap --font serif Results: Still using sans.
*** Bug 516843 has been marked as a duplicate of this bug. ***
Created attachment 105385 [details] [review] first try This seems to work fairly nicely. Some of the code in main.c should probably be moved into gucharmap_mini_fontselection_init.
Looks good to me. Behdad?
Didn't look very closely but I trust that it does the right thing :). Minor thing, the g_strdup is not needed. It leaks now.
Ok, cool. Unless I've missed something (which is probable), the pango documentation doesn't seem to say that the family string is copied. Could that be fixed?
(In reply to comment #5) > Ok, cool. Unless I've missed something (which is probable), the pango > documentation doesn't seem to say that the family string is copied. Could that > be fixed? I thought about that, but I believe the norm in glib and pango is that if it doesn't say anything about the lifecycle of the string passed in, it means you are safe to dispose it. That of course means that it copies it. When a copy is not made, the docs explicity say that the string/object/... needs to be kept alive until .... For example pango_font_description_set_family_static() docs say: "The caller must make sure that the string passed in stays around until desc has been freed or the name is set again."
That makes sense. Thanks :)
Created attachment 107375 [details] [review] memory leak fixed Bug 506752 – --font doesn't work Patch by Jared Moore * gucharmap-mini-font-selection.c (gucharmap_mini_font_selection_set_font_name): If given font description doesn't have a font family, keep the old one. * main.c (main): Fixed faulty logic for dealing with command line arguments. Is there anything I can do to help get patches committed faster? (I also have a patch waiting at #517188). :)
I was waiting for 2.22.0, I guess I should have let you know that :) Please commit to trunk and 2-22 branch.
I don't have commit access. If you'd like, I could apply for it.
No problem, I'll commit them soon, or if someone else with commit access wants to, feel free to do so.
Committed.