After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 506715 - [PATCH] [flacdec] PICTURE blocks should be retrieved as metadata
[PATCH] [flacdec] PICTURE blocks should be retrieved as metadata
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-01 17:48 UTC by John Millikin
Modified: 2008-01-12 03:12 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Emit metadata messages when a PICTURE block is encountered (6.45 KB, patch)
2008-01-01 17:49 UTC, John Millikin 		committed Details | Review
Test case (292.64 KB, application/x-compressed-tar)
2008-01-12 03:12 UTC, John Millikin 		  Details

Description John Millikin 2008-01-01 17:48:37 UTC 
If a FLAC file has one or more PICTURE blocks, they should be emitted as metadata messages.
Comment 1 John Millikin 2008-01-01 17:49:09 UTC 
Created attachment 101947 [details] [review]
Emit metadata messages when a PICTURE block is encountered
Comment 2 Wim Taymans 2008-01-03 12:26:46 UTC 
        Patch by: John Millikin <jmillikin at gmail dot com>

        * ext/flac/gstflacdec.c: (gst_flac_dec_setup_seekable_decoder),
        (gst_flac_dec_setup_stream_decoder),
        (gst_flac_normalize_picture_mime_type),
        (gst_flac_extract_picture_buffer),
        (gst_flac_dec_metadata_callback):
        Emit metadata messages when a PICTURE block is encountered.
        Fixes #506715.
Comment 3 Jan Schmidt 2008-01-11 15:20:20 UTC 
Any chance of a test file?
Comment 4 Tim-Philipp Müller 2008-01-11 15:29:01 UTC 
Wouldn't it make more sense to add a function to libgsttag than to just copy'n'paste this code from id3v2frames.c into flacdec?
Comment 5 Jan Schmidt 2008-01-11 20:20:28 UTC 
What would such a function provide exactly?
Comment 6 John Millikin 2008-01-12 03:12:22 UTC 
Created attachment 102640 [details]
Test case

> Any chance of a test file?

Attached. Archive contains PNG format cover and FLAC file with embedded cover. To create your own with other image formats or options, use the "metaflac" utility.