After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 505745 - [avidemux] warning: 'res' may be used uninitialized in this function
[avidemux] warning: 'res' may be used uninitialized in this function
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal major
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-26 15:28 UTC by Christian Kirbach
Modified: 2007-12-26 16:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
fix 3 compiler warnings (1.71 KB, patch)
2007-12-26 15:37 UTC, Christian Kirbach
rejected Details | Review

Description Christian Kirbach 2007-12-26 15:28:47 UTC
cc1: warnings being treated as errors
gstavidemux.c: In function 'gst_avi_demux_loop':
gstavidemux.c:3701: warning: 'res' may be used uninitialized in this function
make[3]: *** [libgstavi_la-gstavidemux.lo] Fehler 1
Comment 1 Tim-Philipp Müller 2007-12-26 15:36:09 UTC
Bug in GLib-2.15.x AFAIK [0].

Could you do

 $ make ERROR_CFLAGS='' 2>warnings.log

and attach warnings.log? (so we can fix them all in one go)


[0] http://mail.gnome.org/archives/gtk-devel-list/2007-December/msg00301.html
Comment 2 Christian Kirbach 2007-12-26 15:37:41 UTC
Created attachment 101627 [details] [review]
fix 3 compiler warnings

fixes three gcc 4.2.1 compiler warnings
Comment 3 Christian Kirbach 2007-12-26 15:40:05 UTC
It was those three warnings inhibiting my build on Ubuntu 7.10 with jhbuild.

It is compiler warnings on gst files, not to anything related to glib.
Comment 4 Christian Kirbach 2007-12-26 15:48:46 UTC
With last patch warnings.log is emty.
Comment 5 Tim-Philipp Müller 2007-12-26 16:06:51 UTC
> It was those three warnings inhibiting my build on Ubuntu 7.10 with jhbuild.
> It is compiler warnings on gst files, not to anything related to glib.

Doesn't jhbuild build against the latest glib? I think these warnings are caused by changes to the g_assert_not_reached() macro in GLib. I prefer to fix the cause rather than initialize the variables to something bogus though:

 2007-12-26  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/avi/gstavidemux.c: (gst_avi_demux_loop):
        * gst/wavparse/gstwavparse.c: (gst_wavparse_chain):
        * sys/ximage/gstximagesrc.c: (composite_pixel):
          Fix 'xyz may be used uninitialized' compiler warnings caused
          by broken g_assert_not_reached() macro in GLib-2.15.x (it's
          not really nice to abort in any case). Fixes #505745.

Please re-open if that's not enough, thanks!