GNOME Bugzilla – Bug 505570
f-spot installs extra copies of application icons
Last modified: 2010-08-02 12:45:15 UTC
Please describe the problem: The icons in 'apps' directories are installed in two different locations by the f-spot build system. Steps to reproduce: 1. Build and install f-spot Actual results: f-spot application icons are installed under both /usr/share/icons/hicolor/ and /usr/share/f-spot/icons/hicolor/ (may vary depending on configure options). Expected results: The 'apps' icon directories should appear only under /usr/share/icons/. Does this happen every time? Yes. Other information: For reference, this corresponds to Debian bug #441326: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=441326
Created attachment 101583 [details] [review] Install 'apps' icons in hicolordir only.
Created attachment 109871 [details] [review] Updated patch to avoid installing icons twice. Now with ChangeLog entry.
Comment on attachment 109871 [details] [review] Updated patch to avoid installing icons twice. Now with ChangeLog entry. Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this. Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap. Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again. You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
Created attachment 164544 [details] [review] Update to current git HEAD. This updates the patch. However, I have not verified again that the copies of the f-spot icons in $(pkgdatadir)/icons/hicolor are not used - it seems unlikely, though.
They might be used by the menu. I looked at the packages in ubuntu/debian and it seems as if this patch is not shipped anymore. Is that right?
The patch was removed from Debian, but I think it was a misunderstanding, and I've reopened their bug about this. In src/Core/Global.cs, the FSpot.Global.IconTheme is created by adding a search path to the default gtk theme. This means that when searching for the "f-spot" icon, the ones installed into the default gtk theme get picked up everywhere. I've tested this - you can apply the patch, install and run f-spot, and check the icon in the window decorations at the top left. However, if you are not installing the icons into the default gtk theme, you need to set XDG_DATA_DIRS/XDG_DATA_HOME properly. So, installing into "/usr/local/" should always work, and installing into a home directory should work if f-spot is configured with "--datadir=~/.local/share" on modern distributions. Basically, we're installing duplicate icons to work around the cases where people don't do any of those things. Maybe that's a good thing.
Could this patch be applied, please? I'm going to upload 0.6.2-2 to sid now, and will apply it there. Would like to not have to add it to the 0.7 series too. :)
Am applying this patch to both stable-0.6 and master. Tim: please use git format-patch next time to generate the patch.