After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 505158 - [PATCH] Build fail if smalltalk (include/gst.h) is installed in system.
[PATCH] Build fail if smalltalk (include/gst.h) is installed in system.
Status: RESOLVED FIXED
Product: gnome-system-tools
Classification: Deprecated
Component: general
2.20.x
Other All
: Normal minor
: ---
Assigned To: Carlos Garnacho
Carlos Garnacho
: 167210 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-23 04:57 UTC by Jeremy Messenger
Modified: 2007-12-26 02:00 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
Reorder the -I/path/to in GST_TOOL_CFLAGS to fix the build. (509 bytes, patch)
2007-12-23 04:58 UTC, Jeremy Messenger 		committed Details | Review

Description Jeremy Messenger 2007-12-23 04:57:56 UTC 
Please describe the problem:
Build fail if smalltalk (include/gst.h) is installed in system. The problem is in GST_TOOL_CFLAGS that has wrong order of -I/path/to that will trying to build with smalltalk's include/gst.h rather than in src/common.gst.h. The build failure log can be view over at http://www.freebsd.org/cgi/query-pr.cgi?pr=118941 ..

Steps to reproduce:
1. Install smalltalk.
2. Build gnome-system-tools and fail.
3. 


Actual results:


Expected results:


Does this happen every time?
Yes.

Other information:
Will attaching a patch for configure.in to reorder the -I/path/to in GST_TOOL_CFLAGS. This configure.in is from 2.20.0 tarball, not SVN.
Comment 1 Jeremy Messenger 2007-12-23 04:58:52 UTC 
Created attachment 101485 [details] [review]
Reorder the -I/path/to in GST_TOOL_CFLAGS to fix the build.
Comment 2 Jeremy Messenger 2007-12-23 05:01:47 UTC 
Add a bit more detail, before patch (-I/usr/local/include come first before that -I../../src/common):

cc -DHAVE_CONFIG_H -I. -I../.. -D_THREAD_SAFE -DORBIT2=1 -D_REENTRANT -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/freetype2 -I/usr/local/include/libglade-2.0 -I/usr/local/include/libxml2 -I/usr/local/include/gconf/2 -I/usr/local/include/orbit-2.0 -I/usr/local/include/liboobs-1.0 -I../../src/common [...] nm-integration.c

After patch:

cc -DHAVE_CONFIG_H -I. -I../.. -I../../src/common -D_THREAD_SAFE -DORBIT2=1 -D_REENTRANT -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/freetype2 -I/usr/local/include/libglade-2.0 -I/usr/local/include/libxml2 -I/usr/local/include/gconf/2 -I/usr/local/include/orbit-2.0 -I/usr/local/include/liboobs-1.0 [...] nm-integration.c
Comment 3 Carlos Garnacho 2007-12-26 01:44:50 UTC 
Thanks for the patch! it's now committed to svn trunk
Comment 4 Carlos Garnacho 2007-12-26 02:00:37 UTC 
*** Bug 167210 has been marked as a duplicate of this bug. ***