After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 504824 - Moving volume icons across the desktop triggers copy and not move
Moving volume icons across the desktop triggers copy and not move
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] GIO
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 504970 505379 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-21 09:58 UTC by Cosimo Cecchi
Modified: 2007-12-27 10:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
proposed patch (687 bytes, patch)
2007-12-26 21:48 UTC, Cosimo Cecchi 		none Details | Review

Description Cosimo Cecchi 2007-12-21 09:58:45 UTC 
With Nautilus 2.21.1 (GIO powered), dragging the trash icon across the desktop triggers the "copy" action: the mouse cursor gets a "+" near it and if I release the button, I get an error box saying:

"There was an error getting information about "trash".
Error while getting mount info: The specified location is not supported."

I expect the trash to move its icon on drag, not to copy itself.
I'm using gvfs 0.1.0, nautilus 2.21.1 and glib 2.15.0.
Comment 1 Jan de Groot 2007-12-22 00:18:32 UTC 
Same for all other special icons on the desktop. Normal files work well though.
Comment 2 Jose M. daLuz 2007-12-22 02:46:30 UTC 
*** Bug 504970 has been marked as a duplicate of this bug. ***
Comment 3 Cosimo Cecchi 2007-12-25 19:54:19 UTC 
*** Bug 505379 has been marked as a duplicate of this bug. ***
Comment 4 Cosimo Cecchi 2007-12-26 12:01:08 UTC 
Modifying summary, as this happens with any volume and not only with Trash.
Comment 5 Cosimo Cecchi 2007-12-26 21:48:50 UTC 
Created attachment 101647 [details] [review]
proposed patch

This happens because the URI for "special" icons on the desktop has the "x-nautilus-desktop:" prefix and we do not check for it when doing DnD. Attached patch solves the problem checking it early and assigning as action for DnD GDK_ACTION_MOVE in nautilus_drag_default_drop_action_for_icons ().
Comment 6 Alexander Larsson 2007-12-27 10:55:35 UTC 
Thats not quite right. We should only do that in the target-is-desktop case.
I'm commiting a similar patch that moves the check.

2007-12-27  Alexander Larsson  <alexl@redhat.com>

        * libnautilus-private/nautilus-dnd.c:
        (nautilus_drag_default_drop_action_for_icons):
	Default dnd of desktop icons to move. (#504824)
	Based on patch by Cosimo Cecchi