After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 504786 - pad probes leak refs to their data
pad probes leak refs to their data
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other All
: Normal blocker
: 0.10.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-21 01:37 UTC by Olivier Crête
Modified: 2008-01-13 17:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Test case to demonstrate the problem (1.38 KB, patch)
2007-12-21 01:38 UTC, Olivier Crête 		committed Details | Review
patch to fix the problem (7.30 KB, patch)
2007-12-21 01:38 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2007-12-21 01:37:35 UTC 
Pad probes leak references to their data. When they are created, the data is ref'ed, but they are not unrefed correctly when disconnect. 

There are two possibles approaches. 
1. Implement a method to pass a closure to the gst core and go like pygobject..
2. just use the regular pygobject function and do the counter stuff inside the bindings.

I picked option 2 because its a lot more simple..
Comment 1 Olivier Crête 2007-12-21 01:38:18 UTC 
Created attachment 101373 [details] [review]
Test case to demonstrate the problem
Comment 2 Olivier Crête 2007-12-21 01:38:38 UTC 
Created attachment 101374 [details] [review]
patch to fix the problem
Comment 3 Olivier Crête 2007-12-21 01:39:49 UTC 
In the test case.. I left a superfluous print statement
Comment 4 Olivier Crête 2008-01-13 03:15:57 UTC 
shouldn't this be pushed in before the next release?
Comment 5 Edward Hervey 2008-01-13 17:52:32 UTC 
yes, confirming as blocker
Comment 6 Edward Hervey 2008-01-13 17:59:54 UTC 
Thanks, commited

2008-01-13  Olivier Crete  <tester@tester.ca>

        reviewed by: Edward Hervey  <edward.hervey@collabora.co.uk>

        * gst/gstpad.override:
        * testsuite/test_pad.py:
        Re-implement wrapping of gst_pad_add_*probe in order to avoid leaks of
        user-data associated with the probes.
        Fixes #504786