After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 504600 - Crash in handle_cached_dir_changed
Crash in handle_cached_dir_changed
Status: RESOLVED OBSOLETE
Product: gnome-menus
Classification: Core
Component: libgnome-menu
2.26.x
Other opensolaris
: High critical
: ---
Assigned To: gnome-menus dummy account
gnome-menus dummy account
: 513706 513773 513819 514482 514638 514650 514663 514737 514902 514941 514952 515001 515114 515316 515842 516457 516554 516765 516836 516881 516940 517011 517113 517126 517245 517557 517638 517692 518240 518339 518532 518536 518632 518717 518779 518951 519024 519177 519247 519430 519432 519456 519494 519504 519585 519701 519850 519959 519996 520004 520081 520389 520579 520590 520592 520604 520733 520918 520991 520992 521113 521116 521117 521216 521217 521220 521256 521486 521514 521538 521555 521590 521633 521635 521745 521839 521855 521864 521866 521873 521907 521943 521984 522081 522251 522361 522385 522531 522990 523295 523371 523495 523673 523760 523765 523799 523906 523944 523945 524196 524225 524279 524444 524845 524906 524945 524972 525256 525430 525437 525460 525658 526104 526168 526169 526170 526221 526441 526766 526809 526823 526833 526837 527077 527086 527153 527180 527215 527226 527227 527236 527246 528350 529090 529945 529986 530147 530539 530811 530838 533551 534184 535037 537429 537952 540482 541744 543011 544929 546543 546717 547375 549376 550366 550960 551760 551920 552803 553879 558637 560978 561709 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-20 05:34 UTC by harry.fu
Modified: 2021-05-25 12:46 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
crasher fix (787 bytes, patch)
2008-03-06 15:49 UTC, Matt Keenan (IRC:MattMan)
none Details | Review
Updated patch (458 bytes, patch)
2009-04-08 11:43 UTC, Wang Xin
none Details | Review

Description harry.fu 2007-12-20 05:34:44 UTC
Version: 2.20.1

What were you doing when the application crashed?
composing a mail using thunderbird


Distribution:                    Solaris Express Community Edition snv_78 X86
Gnome Release: 2.21.2 2007-12-03 (Sun Microsystems, Inc.)
BugBuddy Version: 2.20.1

X Vendor: Sun Microsystems, Inc.
X Vendor Release: 6620
Selinux: No
Accessibility: Enabled
GTK+ Theme: nimbus
Icon Theme: nimbus

Memory status: size: 200871936 vsize: 200871936 resident: 22745088 share: 0 rss: 22745088 rss_rlim: 0
CPU usage: start_time: 0 rtime: 221 utime: 1726605 stime: 488640 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0

Backtrace was generated from '/usr/bin/gnome-panel'

(no debugging symbols found)
sol-thread active.
Retry #1:
Retry #2:
Retry #3:
Retry #4:
[New LWP    1        ]
[New Thread 1 (LWP 1)]

Thread 1 (LWP 1)

  • #0 _waitid
    from /lib/libc.so.1
  • #1 _waitpid
    from /lib/libc.so.1
  • #2 waitpid_cancel
    from /lib/libc.so.1
  • #3 g_spawn_sync
    from /usr/lib/libglib-2.0.so.0
  • #4 g_spawn_command_line_sync
    from /usr/lib/libglib-2.0.so.0
  • #5 __1cNrun_bug_buddy6Fpkclp0_b_
    from /usr/lib/gtk-2.0/modules/libgnomebreakpad.so
  • #6 __1cMcheck_if_gdb6Fpv_b_
    from /usr/lib/gtk-2.0/modules/libgnomebreakpad.so
  • #7 _ex_text0
    from /usr/lib/gtk-2.0/modules/libgnomebreakpad.so
  • #8 __sighndlr
    from /lib/libc.so.1
  • #9 call_user_handler
    from /lib/libc.so.1
  • #10 <signal handler called>
  • #11 ??
  • #12 handle_cached_dir_changed
    from /usr/lib/libgnome-menu.so.2
  • #13 emit_events_in_idle
    from /usr/lib/libgnome-menu.so.2
  • #14 g_idle_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #15 g_main_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #16 g_main_context_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #17 g_main_context_iterate
    from /usr/lib/libglib-2.0.so.0
  • #18 g_main_loop_run
    from /usr/lib/libglib-2.0.so.0
  • #19 gtk_main
    from /usr/lib/libgtk-x11-2.0.so.0
  • #20 main

Thread 1 (LWP    1        ):
#-1 0xceaf4075 in _waitid () from /lib/libc.so.1
No symbol table info available.
#-1 0xceaf4075 in _waitid () from /lib/libc.so.1


----------- .xsession-errors (17204627 sec old) ---------------------
/etc/X11/gdm/PreSession/Default: Registering your session with wtmp and utmp
/etc/X11/gdm/PreSession/Default: running: /usr/openwin/bin/sessreg -a -w /var/log/wtmp -u /var/run/utmp -x "/var/lib/gdm/129.158.148.26:12.Xservers" -h "129.158.148.26" -l "129.158.148.26:12" "nf14561
/etc/X11/gdm/Xsession: Beginning session setup...
/etc/X11/gdm/Xsession: Setup done, will execute: /usr/bin/ctrun -l child -i none /usr/dt/config/Xsession.jds
--------------------------------------------------
Comment 1 Philip Withnall 2008-02-01 19:11:16 UTC
Thanks for taking the time to report this bug.
Unfortunately, that stack trace is missing some elements that will help a lot to solve the problem, so it will be hard for the developers to fix that crash. Can you get us a stack trace with debugging symbols? Please see http://live.gnome.org/GettingTraces for more information on how to do so and reopen this bug or report a new one. Thanks in advance!
Comment 2 Philip Withnall 2008-02-01 19:11:22 UTC
*** Bug 513706 has been marked as a duplicate of this bug. ***
Comment 3 Philip Withnall 2008-02-01 22:38:49 UTC
*** Bug 513773 has been marked as a duplicate of this bug. ***
Comment 4 Philip Withnall 2008-02-02 12:00:26 UTC
*** Bug 513819 has been marked as a duplicate of this bug. ***
Comment 5 Gianluca Borello 2008-02-05 11:01:59 UTC
*** Bug 514482 has been marked as a duplicate of this bug. ***
Comment 6 Philip Withnall 2008-02-05 23:10:32 UTC
*** Bug 514638 has been marked as a duplicate of this bug. ***
Comment 7 Philip Withnall 2008-02-06 06:46:13 UTC
*** Bug 514650 has been marked as a duplicate of this bug. ***
Comment 8 Philip Withnall 2008-02-06 06:46:23 UTC
*** Bug 514663 has been marked as a duplicate of this bug. ***
Comment 9 Philip Withnall 2008-02-06 23:03:32 UTC
*** Bug 514737 has been marked as a duplicate of this bug. ***
Comment 10 Gianluca Borello 2008-02-07 15:59:59 UTC
*** Bug 514952 has been marked as a duplicate of this bug. ***
Comment 11 Gianluca Borello 2008-02-07 16:00:13 UTC
*** Bug 514941 has been marked as a duplicate of this bug. ***
Comment 12 Gianluca Borello 2008-02-07 16:00:40 UTC
*** Bug 514902 has been marked as a duplicate of this bug. ***
Comment 13 Gianluca Borello 2008-02-07 16:01:01 UTC
*** Bug 515001 has been marked as a duplicate of this bug. ***
Comment 14 Philip Withnall 2008-02-08 06:51:08 UTC
*** Bug 515114 has been marked as a duplicate of this bug. ***
Comment 15 Philip Withnall 2008-02-09 00:04:52 UTC
*** Bug 515316 has been marked as a duplicate of this bug. ***
Comment 16 Philip Withnall 2008-02-11 19:03:41 UTC
*** Bug 515842 has been marked as a duplicate of this bug. ***
Comment 17 Philip Withnall 2008-02-14 14:43:16 UTC
*** Bug 516457 has been marked as a duplicate of this bug. ***
Comment 18 Philip Withnall 2008-02-14 21:58:30 UTC
*** Bug 516554 has been marked as a duplicate of this bug. ***
Comment 19 Philip Withnall 2008-02-15 23:10:17 UTC
*** Bug 516765 has been marked as a duplicate of this bug. ***
Comment 20 Philip Withnall 2008-02-16 12:44:32 UTC
*** Bug 516836 has been marked as a duplicate of this bug. ***
Comment 21 Philip Withnall 2008-02-16 12:44:53 UTC
Marking as NEEDINFO due to all the dupes.
Comment 22 Philip Withnall 2008-02-16 18:34:56 UTC
*** Bug 516881 has been marked as a duplicate of this bug. ***
Comment 23 Gianluca Borello 2008-02-17 10:59:58 UTC
*** Bug 516940 has been marked as a duplicate of this bug. ***
Comment 24 Philip Withnall 2008-02-17 15:16:45 UTC
*** Bug 517011 has been marked as a duplicate of this bug. ***
Comment 25 Philip Withnall 2008-02-18 06:25:26 UTC
*** Bug 517113 has been marked as a duplicate of this bug. ***
Comment 26 Philip Withnall 2008-02-18 06:28:44 UTC
*** Bug 517126 has been marked as a duplicate of this bug. ***
Comment 27 Philip Withnall 2008-02-18 16:56:16 UTC
*** Bug 517245 has been marked as a duplicate of this bug. ***
Comment 28 Philip Withnall 2008-02-19 22:28:32 UTC
*** Bug 517557 has been marked as a duplicate of this bug. ***
Comment 29 Vincent Untz 2008-02-19 22:46:47 UTC
Matt, Brian: this crash might be opensolaris-specific. Could you give it an eye?
Comment 30 Philip Withnall 2008-02-20 17:52:42 UTC
*** Bug 517692 has been marked as a duplicate of this bug. ***
Comment 31 Philip Withnall 2008-02-20 17:56:22 UTC
*** Bug 517638 has been marked as a duplicate of this bug. ***
Comment 32 Philip Withnall 2008-02-23 23:01:13 UTC
*** Bug 518240 has been marked as a duplicate of this bug. ***
Comment 33 Philip Withnall 2008-02-24 01:26:12 UTC
*** Bug 518339 has been marked as a duplicate of this bug. ***
Comment 34 Philip Withnall 2008-02-25 06:36:54 UTC
*** Bug 518536 has been marked as a duplicate of this bug. ***
Comment 35 Philip Withnall 2008-02-25 06:37:05 UTC
*** Bug 518532 has been marked as a duplicate of this bug. ***
Comment 36 Philip Withnall 2008-02-25 16:42:32 UTC
*** Bug 518632 has been marked as a duplicate of this bug. ***
Comment 37 Philip Withnall 2008-02-25 22:12:05 UTC
*** Bug 518717 has been marked as a duplicate of this bug. ***
Comment 38 Philip Withnall 2008-02-26 07:28:46 UTC
*** Bug 518779 has been marked as a duplicate of this bug. ***
Comment 39 Philip Withnall 2008-02-27 06:37:50 UTC
*** Bug 518951 has been marked as a duplicate of this bug. ***
Comment 40 Philip Withnall 2008-02-27 17:47:46 UTC
*** Bug 519024 has been marked as a duplicate of this bug. ***
Comment 41 Philip Withnall 2008-02-28 06:21:27 UTC
*** Bug 519177 has been marked as a duplicate of this bug. ***
Comment 42 Gianluca Borello 2008-02-28 11:53:11 UTC
*** Bug 519247 has been marked as a duplicate of this bug. ***
Comment 43 Matt Keenan (IRC:MattMan) 2008-02-28 14:36:45 UTC
After looking briefly at all the duplicate bug reports (phew). Here's
the list of actions people were doing when the crash occured :

- Installing Compiz (Three People)
- Installing Xfce 4.4.1
- Installed Opera 9.26
- Composing mail in thunderbird (Two People)
- Firefox Minimized with one terminal running
- Firefox
- Running ".exe" after installing Wine
- Installing a package via command line.
- Performing "pkgrm SUNWnmap" for installation of nmap-4.53 from source file
- Installing dev tools e.g. install_devtools.sh
- Right clicking calculator menu option.
- Installing SUNW0Punching (Three People)
- Editing Main Menu
- Installing Developer Tools
- Installing Netbeans
- Nothing (Six People)
- Using Terminal (Two People)
- pkg-get from Blastwave
- Installing citrix client
- Login after screensaver activation
- Generic application installation
- Opening network settings control panel


So from above list the majority of people were simply installing applications.
Chances are that most of these installs would possibly be installing new .desktop files, for menu items. And looking at the stack trace, the crash
appers to be occuring in "handle_cache_dir_changed()" from libgnome-menu.so.2.

I need to have a quick look at this function to see what it does, and maybe there is something solaris specific that is going on here that is causing this, 
as all of the reports are for OpenSolaris only.
Comment 44 Matt Keenan (IRC:MattMan) 2008-02-28 14:51:21 UTC
handle_cache_dir_changed() is used to update cached menu directory entries.
So when a new .desktop file is installed or removed (i think), a menu monitor
event is triggered and this caused handle_cache_dir_changed() to be called.

Unfortunately there isn't enough debug information in the stack traces to 
be able to trace exactly where or what in handle_cache_dir_changed() is
causing this problem.

If any of the bug submitters can recreate this issue on a regular basis I'd be 
happy to provide a debug version of libgnome-panel.so.2 for solaris which
would help in narrowing this issue down further.
Comment 45 stephen.wolf 2008-02-28 17:28:38 UTC
(In reply to comment #44)
> handle_cache_dir_changed() is used to update cached menu directory entries.
> So when a new .desktop file is installed or removed (i think), a menu monitor
> event is triggered and this caused handle_cache_dir_changed() to be called.
> 
> Unfortunately there isn't enough debug information in the stack traces to 
> be able to trace exactly where or what in handle_cache_dir_changed() is
> causing this problem.
> 
> If any of the bug submitters can recreate this issue on a regular basis I'd be 
> happy to provide a debug version of libgnome-panel.so.2 for solaris which
> would help in narrowing this issue down further.
> 

Hi Matt,

I don't have a specific way to trigger it again but I seem to be getting errors at least once a day.  

I'd be happy to install your debug and let it ride.

Steve
Comment 46 robert.vassar 2008-02-28 19:44:39 UTC
Matt,


This is fairly trivial to catch in dbx just by attaching the pid. I've reproduced it several times now, but can't seem to determine any kind of trigger behavior.  It seems to happen as soon as I stop watching it.  :-)

I cannot find a ".desktop" file.


This likely won't be useful without symbols, but here's what dbx gives me:



(dbx) threads
*>    t@1  a  l@1   ?()   signal SIGSEGV in  in <can't get PC>() 
(dbx) where
current thread: t@1
=>[1] 0x0(0x82d5bc0, 0x82b3298), at 0x0 
  [2] handle_cached_dir_changed(0x82a5688, 0x2, 0x832d1c8, 0x822d258), at 0xf6717212 
  [3] emit_events_in_idle(0x0), at 0xf67201a7 
  [4] g_idle_dispatch(0x832d640, 0xf67200fc, 0x0), at 0xfec7aedb 
  [5] g_main_dispatch(0x80f4078), at 0xfec77c76 
  [6] g_main_context_dispatch(0x80f4078), at 0xfec78d85 
  [7] g_main_context_iterate(0x80f4078, 0x1, 0x1, 0x80d3208), at 0xfec791a2 
  [8] g_main_loop_run(0x8291b38), at 0xfec797a4 
  [9] gtk_main(0x8047300, 0xfeffb7cc, 0xfeffb7cc, 0x8047300, 0x8047414, 0x8047338), at 0xfb3ea9de 
  [10] main(0x3, 0x8047344, 0x8047354), at 0x80776e2 
(dbx) regs
current thread: t@1
current frame:  [1]
gs	 0x000001c3 0x00000000
fs	 0x00000000 0x00000000
es	 0x0000004b 0x00000000
ds	 0x0000004b 0x00000000
ss	 0x0000004b 0x00000000
cs	 0x00000043 0x00000000
edi	 0x0832f4e8
esi	 0x0822d258
ebp	 0x0804713c
esp	 0x08047108
ebx	 0x00000000
edx	 0xfed08c00
ecx	 0x00000000
eax	 0x082b1a18
eip	 0x00000000:0x00000000	<bad address 0x0>
trapno	 0x0000000e 0x00000000
err	 0x00000014 0x00000000
eflags	 0x00010206 0x00000000
(dbx) up
0xf6717212: handle_cached_dir_changed+0x0272:	addl     $0x00000008,%esp
(dbx) 


I can also run a debug libgnome-panel.so.2.  Note: I have upgraded my system to build 84.

Rob

Comment 47 Philip Withnall 2008-02-29 06:37:18 UTC
*** Bug 519432 has been marked as a duplicate of this bug. ***
Comment 48 Philip Withnall 2008-02-29 06:38:10 UTC
*** Bug 519430 has been marked as a duplicate of this bug. ***
Comment 49 Christian Kirbach 2008-02-29 07:25:46 UTC
*** Bug 519456 has been marked as a duplicate of this bug. ***
Comment 50 Philip Withnall 2008-02-29 16:51:27 UTC
*** Bug 519504 has been marked as a duplicate of this bug. ***
Comment 51 Philip Withnall 2008-02-29 16:53:11 UTC
*** Bug 519494 has been marked as a duplicate of this bug. ***
Comment 52 Philip Withnall 2008-02-29 18:53:35 UTC
*** Bug 519585 has been marked as a duplicate of this bug. ***
Comment 53 Philip Withnall 2008-03-01 09:46:28 UTC
*** Bug 519701 has been marked as a duplicate of this bug. ***
Comment 54 Gianluca Borello 2008-03-02 10:16:25 UTC
*** Bug 519850 has been marked as a duplicate of this bug. ***
Comment 55 Philip Withnall 2008-03-02 22:32:33 UTC
*** Bug 519959 has been marked as a duplicate of this bug. ***
Comment 56 Philip Withnall 2008-03-02 23:02:16 UTC
*** Bug 519996 has been marked as a duplicate of this bug. ***
Comment 57 Philip Withnall 2008-03-03 06:11:41 UTC
*** Bug 520004 has been marked as a duplicate of this bug. ***
Comment 58 Gianluca Borello 2008-03-03 12:53:49 UTC
*** Bug 520081 has been marked as a duplicate of this bug. ***
Comment 59 Matt Keenan (IRC:MattMan) 2008-03-04 12:02:36 UTC
OK I've managed to recreate what I think is this bug with a recent opensolaris
build, bear in mind this appears to be only happening using gnome 2.20.

The file monitoring required for panel menu updates in 2.21/22 on solaris
is not working correctly and I think this is because of the update of the
panel to use GIO, which relies on fam/gamin in the OS, I am investigating
into the status of this on Solaris to see what if anything needs to be done
inside the panel to help this. Probably nothing.

In the mean time I will try and determine the cause of this crash for 2.20.
Comment 60 Matt Keenan (IRC:MattMan) 2008-03-04 15:16:53 UTC
The crash for me is occuring because of a reference to a null monitor callback.

The directory monitor callbacks are stored in a GList under dir>monitors.
When an entry within a monitored directory is changed/deleted the directory
monitors are called.

The GList dir->monitors is traversed and each (dir->monitors)->data->callback
is in turn called, for some reason on of these monitor callbacks is NULL and
thus the core.

A quick fix is to ensure the NULL callback is not being referenced, in function
cached_dir_invoke_monitors()
e.g. 

+   if (monitor->callback)
        monitor->callback (monitor->ed, monitor->user_data);
i
Once I add this line menu monitoring appears to function correctly for me.

I am concerned about this rogue list element, how is being added, and why ?
I'm not a libgnome-menu expert so I can't answer this easily, anyone of the
panel maintainers care to chime in here ?
Comment 61 Philip Withnall 2008-03-04 22:04:04 UTC
*** Bug 520389 has been marked as a duplicate of this bug. ***
Comment 62 Philip Withnall 2008-03-05 21:11:32 UTC
*** Bug 520592 has been marked as a duplicate of this bug. ***
Comment 63 Philip Withnall 2008-03-05 21:11:37 UTC
*** Bug 520590 has been marked as a duplicate of this bug. ***
Comment 64 Philip Withnall 2008-03-05 21:11:59 UTC
*** Bug 520579 has been marked as a duplicate of this bug. ***
Comment 65 Philip Withnall 2008-03-05 22:04:10 UTC
*** Bug 520604 has been marked as a duplicate of this bug. ***
Comment 66 Matt Keenan (IRC:MattMan) 2008-03-06 15:49:28 UTC
Created attachment 106693 [details] [review]
crasher fix

From what I can see looks like this is a bug in entry-directories.c, and would
appear to be being casued by incorrect traversal of the onitor linked
list.

In function : cached_dir_invoke_monitors() the list of monitors
is travesed courtesy of a variable next. which is assigned at the start
of each iteration.

However the tmp variable can actually change during the processing of the loop
by the callback function itself. Therefore the next item on the list could
actually be NULL when you get to the end of the that loop iteration, but 
next still points to the memory of the deleted list item, and thus we end
up with NULL callback pointer which is attempted to be called.

This is likely a bug on Linux aswell but because of the differences between
the OS's it's somehow not manifesting itself as a crash.

Within the source all processing of GList monitors is done in this fashion
so this should be changed.

The attached patch applies to both 2.20 branch and Trunk and should be applied to both.
Comment 67 Philip Withnall 2008-03-06 16:43:04 UTC
*** Bug 520733 has been marked as a duplicate of this bug. ***
Comment 68 Philip Withnall 2008-03-07 07:49:25 UTC
*** Bug 520918 has been marked as a duplicate of this bug. ***
Comment 69 Philip Withnall 2008-03-07 17:14:20 UTC
*** Bug 520992 has been marked as a duplicate of this bug. ***
Comment 70 Philip Withnall 2008-03-07 17:14:29 UTC
*** Bug 520991 has been marked as a duplicate of this bug. ***
Comment 71 Philip Withnall 2008-03-08 00:32:26 UTC
*** Bug 521117 has been marked as a duplicate of this bug. ***
Comment 72 Philip Withnall 2008-03-08 00:32:32 UTC
*** Bug 521116 has been marked as a duplicate of this bug. ***
Comment 73 Philip Withnall 2008-03-08 00:33:07 UTC
*** Bug 521113 has been marked as a duplicate of this bug. ***
Comment 74 Gianluca Borello 2008-03-08 17:42:27 UTC
*** Bug 521216 has been marked as a duplicate of this bug. ***
Comment 75 Gianluca Borello 2008-03-08 17:42:33 UTC
*** Bug 521217 has been marked as a duplicate of this bug. ***
Comment 76 Gianluca Borello 2008-03-08 17:42:40 UTC
*** Bug 521220 has been marked as a duplicate of this bug. ***
Comment 77 Philip Withnall 2008-03-08 21:04:38 UTC
*** Bug 521256 has been marked as a duplicate of this bug. ***
Comment 78 Philip Withnall 2008-03-10 06:45:20 UTC
*** Bug 521486 has been marked as a duplicate of this bug. ***
Comment 79 Philip Withnall 2008-03-10 07:28:02 UTC
*** Bug 521514 has been marked as a duplicate of this bug. ***
Comment 80 Philip Withnall 2008-03-10 16:39:04 UTC
*** Bug 521590 has been marked as a duplicate of this bug. ***
Comment 81 Philip Withnall 2008-03-10 16:39:16 UTC
*** Bug 521538 has been marked as a duplicate of this bug. ***
Comment 82 Philip Withnall 2008-03-10 16:39:20 UTC
*** Bug 521555 has been marked as a duplicate of this bug. ***
Comment 83 Philip Withnall 2008-03-10 18:26:34 UTC
*** Bug 521635 has been marked as a duplicate of this bug. ***
Comment 84 Philip Withnall 2008-03-10 18:26:39 UTC
*** Bug 521633 has been marked as a duplicate of this bug. ***
Comment 85 Gianluca Borello 2008-03-11 11:56:00 UTC
*** Bug 521745 has been marked as a duplicate of this bug. ***
Comment 86 Philip Withnall 2008-03-11 22:42:54 UTC
*** Bug 521873 has been marked as a duplicate of this bug. ***
Comment 87 Philip Withnall 2008-03-11 22:43:23 UTC
*** Bug 521866 has been marked as a duplicate of this bug. ***
Comment 88 Philip Withnall 2008-03-11 22:43:44 UTC
*** Bug 521864 has been marked as a duplicate of this bug. ***
Comment 89 Philip Withnall 2008-03-11 22:43:49 UTC
*** Bug 521855 has been marked as a duplicate of this bug. ***
Comment 90 Philip Withnall 2008-03-11 22:49:05 UTC
*** Bug 521839 has been marked as a duplicate of this bug. ***
Comment 91 Philip Withnall 2008-03-12 06:29:35 UTC
*** Bug 521907 has been marked as a duplicate of this bug. ***
Comment 92 Philip Withnall 2008-03-12 07:55:10 UTC
*** Bug 521943 has been marked as a duplicate of this bug. ***
Comment 93 Mike Webb 2008-03-12 13:05:58 UTC
This bug was automatically submitted, most likeley since I registered the OE.  Sorry for the clutter if that's the case.
Comment 94 Philip Withnall 2008-03-12 18:32:50 UTC
*** Bug 521984 has been marked as a duplicate of this bug. ***
Comment 95 Philip Withnall 2008-03-12 19:43:20 UTC
*** Bug 522081 has been marked as a duplicate of this bug. ***
Comment 96 Philip Withnall 2008-03-13 16:37:49 UTC
*** Bug 522251 has been marked as a duplicate of this bug. ***
Comment 97 Philip Withnall 2008-03-14 06:32:27 UTC
*** Bug 522361 has been marked as a duplicate of this bug. ***
Comment 98 Gianluca Borello 2008-03-14 11:45:00 UTC
*** Bug 522385 has been marked as a duplicate of this bug. ***
Comment 99 Philip Withnall 2008-03-15 07:22:49 UTC
*** Bug 522531 has been marked as a duplicate of this bug. ***
Comment 100 Philip Withnall 2008-03-17 16:55:06 UTC
*** Bug 522990 has been marked as a duplicate of this bug. ***
Comment 101 Philip Withnall 2008-03-19 06:42:19 UTC
*** Bug 523295 has been marked as a duplicate of this bug. ***
Comment 102 Philip Withnall 2008-03-19 17:59:23 UTC
*** Bug 523371 has been marked as a duplicate of this bug. ***
Comment 103 Philip Withnall 2008-03-20 11:01:07 UTC
*** Bug 523495 has been marked as a duplicate of this bug. ***
Comment 104 Gianluca Borello 2008-03-21 11:50:42 UTC
*** Bug 523673 has been marked as a duplicate of this bug. ***
Comment 105 Gianluca Borello 2008-03-22 09:13:48 UTC
*** Bug 523760 has been marked as a duplicate of this bug. ***
Comment 106 Gianluca Borello 2008-03-22 09:13:55 UTC
*** Bug 523765 has been marked as a duplicate of this bug. ***
Comment 107 Gianluca Borello 2008-03-22 09:14:00 UTC
*** Bug 523799 has been marked as a duplicate of this bug. ***
Comment 108 Philip Withnall 2008-03-22 22:18:13 UTC
*** Bug 523906 has been marked as a duplicate of this bug. ***
Comment 109 Philip Withnall 2008-03-23 07:27:17 UTC
*** Bug 523944 has been marked as a duplicate of this bug. ***
Comment 110 Philip Withnall 2008-03-23 07:27:22 UTC
*** Bug 523945 has been marked as a duplicate of this bug. ***
Comment 111 tanww 2008-03-24 03:42:09 UTC
Hi,

  Since this bug is duplicated or in the process in solving. Please close this case.  Thanks!

Regards,

Johnny
Comment 112 Gianluca Borello 2008-03-25 12:58:03 UTC
*** Bug 524196 has been marked as a duplicate of this bug. ***
Comment 113 Gianluca Borello 2008-03-25 12:58:40 UTC
*** Bug 524225 has been marked as a duplicate of this bug. ***
Comment 114 Gianluca Borello 2008-03-25 13:00:58 UTC
*** Bug 524279 has been marked as a duplicate of this bug. ***
Comment 115 Philip Withnall 2008-03-26 08:54:03 UTC
*** Bug 524444 has been marked as a duplicate of this bug. ***
Comment 116 Philip Withnall 2008-03-28 19:21:33 UTC
*** Bug 524845 has been marked as a duplicate of this bug. ***
Comment 117 Gianluca Borello 2008-03-29 09:10:41 UTC
*** Bug 524906 has been marked as a duplicate of this bug. ***
Comment 118 Philip Withnall 2008-03-29 13:35:17 UTC
*** Bug 524945 has been marked as a duplicate of this bug. ***
Comment 119 Philip Withnall 2008-03-29 14:30:41 UTC
*** Bug 524972 has been marked as a duplicate of this bug. ***
Comment 120 Philip Withnall 2008-03-31 06:14:18 UTC
*** Bug 525256 has been marked as a duplicate of this bug. ***
Comment 121 Gianluca Borello 2008-04-01 11:40:52 UTC
*** Bug 525430 has been marked as a duplicate of this bug. ***
Comment 122 Gianluca Borello 2008-04-01 11:49:37 UTC
*** Bug 525437 has been marked as a duplicate of this bug. ***
Comment 123 Gianluca Borello 2008-04-02 10:30:32 UTC
*** Bug 525658 has been marked as a duplicate of this bug. ***
Comment 124 Philip Withnall 2008-04-02 17:17:49 UTC
*** Bug 525460 has been marked as a duplicate of this bug. ***
Comment 125 Philip Withnall 2008-04-04 07:30:05 UTC
*** Bug 526104 has been marked as a duplicate of this bug. ***
Comment 126 Philip Withnall 2008-04-04 16:47:35 UTC
*** Bug 526168 has been marked as a duplicate of this bug. ***
Comment 127 Philip Withnall 2008-04-04 16:47:39 UTC
*** Bug 526169 has been marked as a duplicate of this bug. ***
Comment 128 Philip Withnall 2008-04-04 16:47:45 UTC
*** Bug 526170 has been marked as a duplicate of this bug. ***
Comment 129 Philip Withnall 2008-04-04 19:46:36 UTC
*** Bug 526221 has been marked as a duplicate of this bug. ***
Comment 130 Philip Withnall 2008-04-06 07:12:09 UTC
*** Bug 526441 has been marked as a duplicate of this bug. ***
Comment 131 Philip Withnall 2008-04-07 17:29:29 UTC
*** Bug 526766 has been marked as a duplicate of this bug. ***
Comment 132 Philip Withnall 2008-04-07 21:31:17 UTC
*** Bug 526809 has been marked as a duplicate of this bug. ***
Comment 133 Philip Withnall 2008-04-07 22:04:38 UTC
*** Bug 526823 has been marked as a duplicate of this bug. ***
Comment 134 Philip Withnall 2008-04-08 06:03:52 UTC
*** Bug 526837 has been marked as a duplicate of this bug. ***
Comment 135 Philip Withnall 2008-04-08 06:03:57 UTC
*** Bug 526833 has been marked as a duplicate of this bug. ***
Comment 136 Philip Withnall 2008-04-09 06:39:15 UTC
*** Bug 527077 has been marked as a duplicate of this bug. ***
Comment 137 Gianluca Borello 2008-04-09 11:26:09 UTC
*** Bug 527086 has been marked as a duplicate of this bug. ***
Comment 138 Philip Withnall 2008-04-09 15:59:45 UTC
*** Bug 527153 has been marked as a duplicate of this bug. ***
Comment 139 Philip Withnall 2008-04-09 17:30:06 UTC
*** Bug 527180 has been marked as a duplicate of this bug. ***
Comment 140 Philip Withnall 2008-04-09 21:48:05 UTC
*** Bug 527227 has been marked as a duplicate of this bug. ***
Comment 141 Philip Withnall 2008-04-09 21:48:10 UTC
*** Bug 527226 has been marked as a duplicate of this bug. ***
Comment 142 Philip Withnall 2008-04-09 21:48:15 UTC
*** Bug 527215 has been marked as a duplicate of this bug. ***
Comment 143 Vincent Untz 2008-04-09 21:58:41 UTC
Matt: I'm not totally comfortable with this part of the code, but the patch looks weird to me. If the callback modifies the list, then even with your patch, things could go wrong.

I need to take a sheet of paper and a pen to write how things work to be sure that the fix is right...
Comment 144 Philip Withnall 2008-04-09 22:17:51 UTC
*** Bug 527236 has been marked as a duplicate of this bug. ***
Comment 145 Philip Withnall 2008-04-10 06:05:42 UTC
*** Bug 527246 has been marked as a duplicate of this bug. ***
Comment 146 Matt Keenan (IRC:MattMan) 2008-04-10 09:03:07 UTC
Vincent, 

One of the basis for making the changes I did was the simple fact that all
other iterations of the list were done in the manner that I've changed this
function to do, and when I checked the revision history in SVN, this code
has not changed for a long long time, where as all new code written appear
to be using the method of traversal that I am changing it to.

But go ahead and write down on paper, it's always the best route to take :)

BTW this does solve the crash's on OpenSolaris.
Comment 147 Philip Withnall 2008-04-16 05:47:20 UTC
*** Bug 528350 has been marked as a duplicate of this bug. ***
Comment 148 Philip Withnall 2008-04-20 19:57:26 UTC
*** Bug 529090 has been marked as a duplicate of this bug. ***
Comment 149 Philip Withnall 2008-04-25 18:35:23 UTC
*** Bug 529945 has been marked as a duplicate of this bug. ***
Comment 150 Philip Withnall 2008-04-25 22:16:46 UTC
*** Bug 529986 has been marked as a duplicate of this bug. ***
Comment 151 Philip Withnall 2008-04-27 09:12:37 UTC
*** Bug 530147 has been marked as a duplicate of this bug. ***
Comment 152 Philip Withnall 2008-04-29 15:41:45 UTC
*** Bug 530539 has been marked as a duplicate of this bug. ***
Comment 153 Philip Withnall 2008-04-30 22:56:17 UTC
*** Bug 530811 has been marked as a duplicate of this bug. ***
Comment 154 Christian Kirbach 2008-04-30 23:01:41 UTC
How can this be unconfirmed with that many duplicates?
confirming report.
Comment 155 Philip Withnall 2008-05-01 06:04:14 UTC
*** Bug 530838 has been marked as a duplicate of this bug. ***
Comment 156 Kjartan Maraas 2008-05-08 13:11:43 UTC
How are you doing with the pen and the paper Vincent? :-)
Comment 157 Vincent Untz 2008-05-15 08:52:24 UTC
(In reply to comment #156)
> How are you doing with the pen and the paper Vincent? :-)

Matt's fix fixes the crash but is kind of wrong (since it can remove some events, though unlikely to happen in real life). And a good fix means rewriting the way we handle the events. This is more or less planned for 2.23 :-)
Comment 158 Matt Keenan (IRC:MattMan) 2008-05-15 10:13:48 UTC
Glad to hear the Pen & Paper method has completed.

You mention that the fix I proposed will "possiblly but unlikely in real life"
miss out on some events, I'll not argue, but would it make sense to get this
integrated into gnome 2.22 ? especially as you point out the even handling
is being re-written for 2.23, so therefore the potential even missing fix
won't be there for that long :)

BTW what is the new even mechanism being done for 2.23/24 any URL pointers
to some more info ?
Comment 159 Philip Withnall 2008-05-17 13:26:21 UTC
*** Bug 533551 has been marked as a duplicate of this bug. ***
Comment 160 Philip Withnall 2008-05-21 13:45:55 UTC
*** Bug 534184 has been marked as a duplicate of this bug. ***
Comment 161 Philip Withnall 2008-05-27 11:07:00 UTC
*** Bug 535037 has been marked as a duplicate of this bug. ***
Comment 162 Philip Withnall 2008-06-09 16:38:42 UTC
*** Bug 537429 has been marked as a duplicate of this bug. ***
Comment 163 Philip Withnall 2008-06-12 17:09:31 UTC
*** Bug 537952 has been marked as a duplicate of this bug. ***
Comment 164 André Klapper 2008-06-13 20:30:05 UTC
There has not been a single report coming from GNOME 2.22 so far. Also couldn't find a ticket in Launchpad. Is this really still a blocker?
Comment 165 Matt Keenan (IRC:MattMan) 2008-06-17 08:25:32 UTC
Reason for no 2.22 reports is :
  - All reports are for OpenSolaris
  - The patch attached fixes the bug on OpenSolaris and panel is
    distributed on OpenSolaris with this patch applied, and thus
    there are no 2.22 reports coming in :)

Thus why I'd love to see this patch applied to community SVN :) so 
the patch could be dropped from OpenSolaris builds. 
Comment 166 Vincent Untz 2008-06-17 10:00:41 UTC
The reason I didn't apply the patch is that it's wrong (see comment #157).
Comment 167 André Klapper 2008-06-17 11:41:42 UTC
(In reply to comment #157)
> Matt's fix fixes the crash but is kind of wrong (since it can remove some
> events, though unlikely to happen in real life). And a good fix means rewriting
> the way we handle the events. This is more or less planned for 2.23 :-)

This sounds like vuntz wants me to set the target milestone to 2.24 instead of 2.22. I'm fine with that as long as somebody really(TM) works on it. ;-)
Comment 168 Philip Withnall 2008-06-27 17:00:50 UTC
*** Bug 540482 has been marked as a duplicate of this bug. ***
Comment 169 Philip Withnall 2008-07-06 10:30:22 UTC
*** Bug 541744 has been marked as a duplicate of this bug. ***
Comment 170 Philip Withnall 2008-07-15 06:18:37 UTC
*** Bug 543011 has been marked as a duplicate of this bug. ***
Comment 171 Susana 2008-07-27 22:22:04 UTC
*** Bug 544929 has been marked as a duplicate of this bug. ***
Comment 172 André Klapper 2008-07-30 17:30:06 UTC
Vuntz, any news here with regard to rewriting the way we handle the events, so that Matt could update the patch?
Comment 173 Vincent Untz 2008-07-30 18:03:43 UTC
Unfortunately, no news. So this patch is still needed in OpenSolaris for now...
Comment 174 Gianluca Borello 2008-08-06 15:29:38 UTC
*** Bug 546543 has been marked as a duplicate of this bug. ***
Comment 175 Susana 2008-08-09 01:56:52 UTC
*** Bug 546717 has been marked as a duplicate of this bug. ***
Comment 176 Baptiste Mille-Mathias 2008-08-12 08:33:36 UTC
*** Bug 547375 has been marked as a duplicate of this bug. ***
Comment 177 Philip Withnall 2008-08-26 00:22:50 UTC
*** Bug 549376 has been marked as a duplicate of this bug. ***
Comment 178 André Klapper 2008-08-29 15:31:35 UTC
This will not be fixed for 2.24 according to vuntz.
Comment 179 Philip Withnall 2008-09-02 06:35:53 UTC
*** Bug 550366 has been marked as a duplicate of this bug. ***
Comment 180 Philip Withnall 2008-09-05 15:53:33 UTC
*** Bug 550960 has been marked as a duplicate of this bug. ***
Comment 181 Philip Withnall 2008-09-11 15:59:10 UTC
*** Bug 551760 has been marked as a duplicate of this bug. ***
Comment 182 Philip Withnall 2008-09-12 16:46:59 UTC
*** Bug 551920 has been marked as a duplicate of this bug. ***
Comment 183 Philip Withnall 2008-09-18 17:21:28 UTC
*** Bug 552803 has been marked as a duplicate of this bug. ***
Comment 184 Philip Withnall 2008-09-26 06:29:37 UTC
*** Bug 553879 has been marked as a duplicate of this bug. ***
Comment 185 Philip Withnall 2008-10-31 09:49:38 UTC
*** Bug 558637 has been marked as a duplicate of this bug. ***
Comment 186 Philip Withnall 2008-11-16 00:16:10 UTC
*** Bug 560978 has been marked as a duplicate of this bug. ***
Comment 187 Philip Withnall 2008-11-20 17:58:37 UTC
*** Bug 561709 has been marked as a duplicate of this bug. ***
Comment 188 André Klapper 2009-02-05 18:34:11 UTC
3 dups in the last 4 months => not a blocker anymore.
Comment 189 Wang Xin 2009-04-08 08:15:21 UTC
This problem can still be reproduced on opensolaris. But there is a bug in the attached patch. I will provide a new patch soon.
Comment 190 Wang Xin 2009-04-08 11:43:27 UTC
Created attachment 132325 [details] [review]
Updated patch

Detail about the patch can be found at http://defect.opensolaris.org/bz/show_bug.cgi?id=7677.
Comment 191 André Klapper 2009-10-05 14:45:15 UTC
ping - patch available.
Comment 192 Vincent Untz 2009-10-05 15:02:21 UTC
(In reply to comment #166)
> The reason I didn't apply the patch is that it's wrong (see comment #157).

Still valid :-)
Comment 193 André Klapper 2021-05-25 12:46:01 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new enhancement request ticket at
  https://gitlab.gnome.org/GNOME/gnome-menus/-/issues/

Thank you for your understanding and your help.