After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 504597 - Direct compare on string
Direct compare on string
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.20.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2007-12-20 04:41 UTC by JP Rosevear
Modified: 2007-12-27 11:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to do proper string compare (458 bytes, patch)
2007-12-20 04:42 UTC, JP Rosevear 		none Details | Review

Description JP Rosevear 2007-12-20 04:41:09 UTC 
File roller does:
       if ((path == "") || (path[0] == '/'))

Path is a pointer though.
Comment 1 JP Rosevear 2007-12-20 04:42:08 UTC 
Created attachment 101299 [details] [review]
patch to do proper string compare
Comment 2 Paolo Bacchilega 2007-12-27 11:06:48 UTC 
patch applied to trunk, thanks.