After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503967 - epiphany-webkit: text resize does not work.
epiphany-webkit: text resize does not work.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
2.20.x
Other Linux
: Normal major
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-17 02:19 UTC by Michael Gilbert
Modified: 2008-12-15 15:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20



Description Michael Gilbert 2007-12-17 02:19:50 UTC
this is the second problem i ran into with epiphany-webkit.

the text resize feature does not work.  ctrl++, ctrl+-, ctrl+mwheelup,
ctrl+mwheeldown, and the view menu "larger text" and "smaller text"
options do not do anything.

this is debian bug 452762 (http://bugs.debian.org/452762).

thanks again for all the hard work.
Comment 1 Cosimo Cecchi 2007-12-17 07:28:54 UTC
This is due to http://bugs.webkit.org/show_bug.cgi?id=14998, currently WebKit/GTK+ misses a zoom feature.
Comment 2 Reinout van Schouwen 2007-12-17 08:56:41 UTC
Marking NOTGNOME.
Comment 3 Xan Lopez 2007-12-17 09:06:05 UTC
Reinouts, we'll still need to do some things on our side (as in most of the other webkit bugs), so it's good to keep them open I'd say. Reopening.
Comment 4 Marco Barisione 2008-04-08 11:24:53 UTC
http://bugs.webkit.org/show_bug.cgi?id=14998 has been fixed but for now WebKit gtk is lacking an API to use zooming, adding this API is tracked by http://bugs.webkit.org/show_bug.cgi?id=14998

I'm probably going to make full-page zoom the default and text-only scaling (like in gecko) usable setting a property on the webview if other WebKit developers agree with me. What do you think? Do epiphany developers have any preference?
Comment 5 Christian Persch 2008-04-08 11:40:50 UTC
I would prefer having both kinds of zoom available in the API. Epiphany itself will probably only offer text-zoom in its UI.
Comment 6 Xan Lopez 2008-04-08 11:42:26 UTC
For us it makes more sense to have text-only as default, if they must share the API. As chpe says it would make sense to offer both and let embedders pick what they want to do...
Comment 7 Marco Barisione 2008-04-08 13:10:07 UTC
I was hoping to convince you to use full-page zoom as the default :)

The API will offer both but you cannot you them at the same time. Safari will use text-only zoom but the mode can be changed modifying a key with their equivalent of gconftool.
Comment 8 Christian Persch 2008-04-08 13:38:01 UTC
Why can't text-zoom and full-zoom be used at the same time? They're clearly orthogonal features.
Comment 9 Michael Gilbert 2008-05-04 02:02:20 UTC
there are some other issues related to fonts, but i'm not sure if they should be associated with this bug or if a new bug should be opened.  the issues are:

1. choosing language-specific fonts doesn't work.

if you go to Edit -> Preferences -> Fonts & Styles -> Detailed Font Settings you can change the settings there, but they will have no effect.  the same can also be said for Edit -> Preferences -> Language -> Encodings.  you can change the default language encoding, but it has no effect.

2.  choosing language-specific minimum font size doesn't work

modifying Edit -> Preferences -> Fonts & Styles -> Minimum size doesn't have any effect.  this may in fact be related to the text zoom capabality.

3.  web pages can't specify their own fonts

Edit -> Preferences -> Fonts & Style -> Let web pages specify their own fonts also doesn't have any effect because a default font is always used.

let me know if i should open this up as a separate bug.

see debian bug #478198 (http://bugs.debian.org/478198).
Comment 10 Martin Sourada 2008-05-31 14:38:43 UTC
Just letting you know, that as of epiphany revision 8264 and WebKit-gtk r34271 I can successfully zoom in/out using the buttons in toolbar, entries in menu or ctrl-+/-. Zoom to normal size seems however to be disabled. 

It zoomes only text which is IMHO desired behaviour.
Comment 11 alp 2008-06-17 12:17:22 UTC
(In reply to comment #10)
> Just letting you know, that as of epiphany revision 8264 and WebKit-gtk r34271
> I can successfully zoom in/out using the buttons in toolbar, entries in menu or
> ctrl-+/-. Zoom to normal size seems however to be disabled. 

Fixed in r8281.

> 
> It zoomes only text which is IMHO desired behaviour.
> 

WebKit has API to enable full content zoom. If anyone wants to add preference UI or some way of optionally enabling that, I can review the patch in a new bug.
Comment 12 Michael Gilbert 2008-06-17 21:22:00 UTC
This is great!  Thanks for the hard work on getting this feature implemented.

I would recommend text-only zoom as the default.  Full content zoom is a decent feature to have available, but it isn't very good as a default.  I've seen firefox 3's full content zoom (which is their default) -- parts of the zoomed-in page usually end up outside the viewable window, and the images end up looking terrible.
Comment 13 Michael Gilbert 2008-12-15 05:49:52 UTC
i just tried epiphany-wekbit 2.24, and text resize still does not work.  is this problem supposed to be fixed in this stable version or is it coming in 2.26?
Comment 14 Cosimo Cecchi 2008-12-15 09:10:58 UTC
Should be trunk only.
Comment 15 Michael Gilbert 2008-12-15 15:43:34 UTC
ok, thanks for the info.  will this be pushed into the stable 2.26 release?