After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503921 - Fails to build with GCC 4.3
Fails to build with GCC 4.3
Status: RESOLVED FIXED
Product: epiphany-extensions
Classification: Deprecated
Component: error-viewer
2.20.x
Other Linux
: Normal normal
: ---
Assigned To: epiphany-extensions-maint
Adam Hooper
: 519174 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-16 21:43 UTC by Josselin Mouette
Modified: 2008-02-28 01:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
[1/1] Include <cstring> for strcmp. (449 bytes, patch)
2007-12-28 16:09 UTC, Xan Lopez 		none Details | Review

Description Josselin Mouette 2007-12-16 21:43:14 UTC 
[ Initially found by Martin Milchmayr, see http://bugs.debian.org/456053 ]

The error-viewer extension fails to build with GCC 4.3:

> Automatic build of epiphany-extensions_2.20.1-2 on em64t by sbuild/amd64 0.53
...
>  g++ -DHAVE_CONFIG_H -I. -I../../.. -I.. -I../../../include -I../../../extensions/error-viewer -DSHARE_DIR=\"/usr/share/epiphany-extensions\" -DPNG_NO_MMX_CODE -DORBIT2=1 -pthread -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/epiphany/2.20 -I/usr/include/libgnomeui-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/orbit-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-vfs-module-2.0 -I/usr/include/gconf/2 -I/usr/include/libart-2.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gail-1.0 -fno-rtti -fshort-wchar -g -Wall -O2 -Wall -Wno-unused -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -g -Wall -O2 -c validate.cpp  -fPIC -DPIC -o .libs/liberrorvieweropensp_la-validate.o
> validate.cpp: In member function 'void HtmlErrorFinder::handle_line(const char*)':
> validate.cpp:143: error: 'strcmp' was not declared in this scope
> make[5]: *** [liberrorvieweropensp_la-validate.lo] Error 1
> make[5]: Leaving directory `/build/tbm/epiphany-extensions-2.20.1/extensions/error-viewer/opensp'

AIUI this is just a matter of adding a correct "#include <string.h>".
Comment 1 Xan Lopez 2007-12-28 16:09:10 UTC 
Created attachment 101737 [details] [review]
[1/1] Include <cstring> for strcmp.

 extensions/error-viewer/opensp/validate.cpp |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Comment 2 Xan Lopez 2007-12-28 16:10:13 UTC 
It's <cstring> for C++ AFAIK.
Comment 3 Xan Lopez 2007-12-28 17:16:42 UTC 
Ok, I've pushed this now.
Comment 4 JP Rosevear 2008-02-28 01:05:43 UTC 
*** Bug 519174 has been marked as a duplicate of this bug. ***