After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503842 - Audio waveform display when in complex timeline
Audio waveform display when in complex timeline
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
Git
Other All
: Normal enhancement
: 0.13.1
Assigned To: Brandon Lewis
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-16 12:14 UTC by Luca Della Santina
Modified: 2009-02-10 12:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Waveform display widget implementation (24.25 KB, patch)
2007-12-16 12:16 UTC, Luca Della Santina
none Details | Review
Waveform display widget pixmaps (3.44 KB, application/x-compressed-tar)
2007-12-16 12:17 UTC, Luca Della Santina
  Details
Screenshot of the waveform widget (130.29 KB, image/png)
2008-01-13 13:11 UTC, Luca Della Santina
  Details

Description Luca Della Santina 2007-12-16 12:14:19 UTC
When in complex timeline view audio sources that the user drags into the timeline  display the audio waveform.
In this way users have a graphical representation of what's inide the currect audio portion of the timeline and can trim/join/apply filter with precision upon the audio track(s)
Comment 1 Luca Della Santina 2007-12-16 12:16:16 UTC
Created attachment 101050 [details] [review]
Waveform display widget implementation

needs the accompanying icons to be placed inside the pixmaps directory to work
Comment 2 Luca Della Santina 2007-12-16 12:17:58 UTC
Created attachment 101051 [details]
Waveform display widget pixmaps

new pixmaps needed by the waveform display widget, place them inside the /pitivi/pixmaps directory
Comment 3 Luca Della Santina 2007-12-16 12:28:24 UTC
The porposed Waveform display widget directly comes from Jokosher's implementation, stripped out of the application logic and fitted into pitivi architecture.

A comceptual separation was needed inside complexsource.py in order to make distinction between audio and video sources, therefore complexaudiosource/complexvideosource were created

Waveform peaks computation is performed only the first time the audio source is dragged inside the complex timeline, so that for any successive dragging no time is wasted in recomputations.

Several aspects are likely to be improved:
- Place waveform peaks computation inside a thread
- (re)implement trim functionalities like in Jokosher's widget
- Optimize waveform screen redrawing (now highly unoptimized)
Comment 4 W. Michael Petullo 2008-01-12 09:55:19 UTC
Would this allow one to apply a new audio track to a video? I would like to be able to record a video, import it into pitivi and then add an audio track from a different source.

Should I enter a new enhancement bug or will this report suffice?
Comment 5 Luca Della Santina 2008-01-13 12:48:59 UTC
This patch allows only to view a graphical representation of the audio track by plotting the audio peaks inside the audio track rectangule.

I think the feature you're requesting is already implemented in pitivi, since when in advanced view you can drag a video-only source into the timeline and then drag an audio-only source in corrispondece of the video, so that it becomes the audio track, then render the project.
I myself tried to to this, and it worked only few times, since there are a lot of bugs/unimplemented in advanced timeline.
My advice is to fill a bug-report for the feature you're looking at, and if you have some spare time also ask directly to developers on the IRC channel.

Sincerely.
Comment 6 Luca Della Santina 2008-01-13 13:11:36 UTC
Created attachment 102733 [details]
Screenshot of the waveform widget

PiTiVi screenshot with the patch applied, showing a custom audio track whose audio-peaks are analyzed and plotted by the new widget.
Comment 7 Brandon Lewis 2008-11-04 05:26:15 UTC
I'm working on integrating this into current pitivi. Thanks for the patch, and sorry it's taken us so long to get around to including your work.