After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503725 - check/uncheck "Index mounted directories" needs trackerd reindex
check/uncheck "Index mounted directories" needs trackerd reindex
Status: VERIFIED FIXED
Product: tracker
Classification: Core
Component: Preferences
unspecified
Other opensolaris
: Normal normal
: ---
Assigned To: Martyn Russell
Jamie McCracken
: 521614 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-15 09:49 UTC by avazhang
Modified: 2008-07-29 08:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds HAL support for watching new mount points (83.35 KB, patch)
2008-01-10 16:44 UTC, Martyn Russell
none Details | Review
Better patch (48.90 KB, patch)
2008-01-11 11:18 UTC, Martyn Russell
none Details | Review
Updated patch (92.88 KB, patch)
2008-04-10 11:51 UTC, Martyn Russell
reviewed Details | Review
Updated patch (126.33 KB, patch)
2008-04-10 15:52 UTC, Martyn Russell
committed Details | Review

Description avazhang 2007-12-15 09:49:26 UTC
Please describe the problem:
check/uncheck "Index mounted directories" needs trackerd reindex
Now this function doesn't work unless user run "trackerd -R" manually.

Steps to reproduce:



Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Martyn Russell 2008-01-10 16:44:32 UTC
Created attachment 102525 [details] [review]
Adds HAL support for watching new mount points
Comment 2 Martyn Russell 2008-01-11 11:18:46 UTC
Created attachment 102581 [details] [review]
Better patch

The last patch had traces of other work I am doing and should be ignored.
Comment 3 Martyn Russell 2008-03-10 16:51:59 UTC
Just realised, I created a new bug for this bug report.
I had to refactor the patch anyway, so this is deprecated really as a duplicate of bug #521614.

*** This bug has been marked as a duplicate of 521614 ***
Comment 4 Martyn Russell 2008-04-10 11:51:46 UTC
Created attachment 108989 [details] [review]
Updated patch

This patch actually goes a little further than just improving HAL support, it actually fixes up the tracker-process-files.[ch] to work better with the two new options to index or not index mounted directories and removable devices.

This patch removes or moves a lot of code from src/trackerd/tracker-utils.[ch] too. 

I have been testing this patch for the last 1/2 week. It seems to work nicely.
Comment 5 Martyn Russell 2008-04-10 11:54:39 UTC
*** Bug 521614 has been marked as a duplicate of this bug. ***
Comment 6 Martyn Russell 2008-04-10 15:52:52 UTC
Created attachment 109000 [details] [review]
Updated patch

Sorry, this patch is the same as the last but with the tracker-hal.[ch] files included that I forgot to add.
Comment 7 Jamie McCracken 2008-04-11 03:31:16 UTC
can you make sure it wont index cdrom and/or dvd (that would be so slow!)

once done pls commit 

thanks

jamie
Comment 8 Martyn Russell 2008-04-11 11:47:13 UTC
Committed, thanks.
Comment 9 avazhang 2008-07-29 08:04:02 UTC
Verified on Verm95(Gnome 2.23.4 + Tracker 0.6.6)

If change the "Index mounted directories" key, tracker-preferences will pop up a window to inform user that trackerd will re-index.