Created attachment 100880 [details]
Screenshot of existing password dialog

Created attachment 100881 [details] [review]
Patch (revised)

This is the patch that was submitted to evolution-patches, but with the GtkVBox spacing set to 6 instead of 5 as suggested by Matthew Barnes. This results in at least 12 pixels between any two elements as suggested by Gnome Human Interface Guidelines[1]. The closest is the distance between the input box and the checkbox - at exactly 12 pixels (not including the feint highlight line adjacent to the dark border) - based on my screenshot using using the Clearlooks theme.

[1] Gnome Human Interface Guidelines: http://library.gnome.org/devel/hig-book/stable/design-window.html.en

Created attachment 100882 [details]
Screenshot of patched password dialog

I like it.  Approving the patch.

If you want to take on some additional work, I think the dialog would look even better if the entry box and check box were left-aligned with the "Please enter password" label instead of the icon.

You can use a 2-column GtkTable for this.  Make the first column exclusively for the icon -- use "top" vertical alignment and have the column span however many rows there are in the second column.  Like this:

   +------+-----------------------------+  }
   |  /\  | Please enter password.      |  }  GtkTable, packed inside
   | /__\ +-----------------------------+  }  the dialog's GtkVBox.
   |      | [Entry box                ] |  }
   |      +-----------------------------+  }
   |      | [ ] Remember this password  |  }
   +------+-----------------------------+
   |                 [Cancel]  [  OK  ] |
   +------------------------------------+

Again, this is totally optional.  I think your patch can go in as is.

I agree with the extra request of matthew, would be cool if it was handled (eventually in another report) because it currently feels weird with the rest of the desktop.

fwiw, I also agree with Matthew.

I'll try implementing that suggestion, I agree it will probably look nicer. Just a  note to say I haven't forgotten this, I'm just busy. If there's no more progress in a month feel free to ping me :)

Patch committed to SVN trunk as r8313
(http://svn.gnome.org/viewvc/evolution-data-server?view=revision&revision=8313)

Created attachment 101763 [details] [review]
Patch with aligned elements

This implements the suggestion by Matthew Barnes to left-align the input elements with the prompt text, to the right of the icon.

I ended up using a GtkVBox in a GtkHBox rather than a GtkTable because it was more flexible at handling the optional "Remember this password" field.

Created attachment 101764 [details]
Screenshot with aligned elements

Created attachment 101974 [details] [review]
Patch with aligned elements (corrected code style)

This is the same as attachment 101763 [details] [review] except with correct whitespacing around GTK_* casts.

The gtkmessagedialog.h include is no longer needed in libedataserverui/e-passwords.c, although one or two other headers (gtklabel, gtkdialog) will probably need to replace it.

Created attachment 102615 [details] [review]
Revised patch

I took Ted's patch and iterated on it a little more, fixing a few alignment issues, getting rid of the separator, and having the GtkLabel treat the text as markup in preparation for bug #506250.

Created attachment 102616 [details]
Another Screenshot

Matt, didn't fejj say whey they didn't have user@host, rather reverted after lots of complaints? Still we going in that fashion? Or Am I reading wrong somewhere?

See bug #506250, which deals with the wording.  This bug is just UI stuff.

Matt then ok. Commit it asap. Also lets close bug 506250 asap. I want it to look great :)

Patch committed to SVN trunk as r8361 (had to commit before the release :-) )
(http://svn.gnome.org/viewvc/evolution-data-server?view=revision&revision=8361)

Closing this since the patch was committed.