After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503383 - A better place for the browser toggle
A better place for the browser toggle
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
0.11.x
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-13 09:30 UTC by Christophe Dehais
Modified: 2012-01-08 06:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Moving the toggle at the top of the browser (56.46 KB, image/png)
2007-12-13 09:32 UTC, Christophe Dehais
  Details
Moves the browser toggle from main toolbar to source header (5.31 KB, patch)
2007-12-16 01:18 UTC, Christophe Dehais
none Details | Review

Description Christophe Dehais 2007-12-13 09:30:28 UTC
Considering that the browser enable state is per-source, as is the search field, it might make sense to move it near that field.
Attaching a mockup illustrating the idea.

Other information:
Comment 1 Christophe Dehais 2007-12-13 09:32:00 UTC
Created attachment 100874 [details]
Moving the toggle at the top of the browser
Comment 2 Andrew Conkling 2007-12-13 16:34:45 UTC
Agreed; it makes sense to place it next to the Search box. Are there any sources to worry about when the browse button would need to disappear? I expect it already does, but I'm trying to think of any obstacles we'd run into.
Comment 3 Christophe Dehais 2007-12-14 10:04:55 UTC
Good point. Maybe the HIG answers that, but it may be best to just render it insensitive (if we really want to place it as shown on the mockup). This will avoid the search panel to jump left and right when changing source.
Comment 4 Christophe Dehais 2007-12-16 01:18:52 UTC
Created attachment 101033 [details] [review]
Moves the browser toggle from main toolbar to source header

OK, here is a proposition.
Everything in the source header is now in the 'SearchBar' toolbar that previously  only contained the search filter selectors (if any). The search entry is wrapped in a GtkToolItem and integrated in this toolbar.
Then the browser toggle is just moved at its new place in the ui description file.

As a consequence the RBSourceHeader widget now derive from GtkHBox instead of GtkTable, the only reason being that GtkBin alone didn't work.

It works almost fine, but I see 2 problems:
* I don't know if it's very legal/safe to mess with the UI constructed by an UIManager.
* The filter selectors buttons are now very big (text 'lost' in the button).

And finally, the header take 100% width and the search entry takes the maximum space available. This can be changed if it causes problems.
Comment 5 Jonathan Matthew 2012-01-08 06:28:42 UTC
this happened a while ago