GNOME Bugzilla – Bug 503383
A better place for the browser toggle
Last modified: 2012-01-08 06:28:42 UTC
Considering that the browser enable state is per-source, as is the search field, it might make sense to move it near that field. Attaching a mockup illustrating the idea. Other information:
Created attachment 100874 [details] Moving the toggle at the top of the browser
Agreed; it makes sense to place it next to the Search box. Are there any sources to worry about when the browse button would need to disappear? I expect it already does, but I'm trying to think of any obstacles we'd run into.
Good point. Maybe the HIG answers that, but it may be best to just render it insensitive (if we really want to place it as shown on the mockup). This will avoid the search panel to jump left and right when changing source.
Created attachment 101033 [details] [review] Moves the browser toggle from main toolbar to source header OK, here is a proposition. Everything in the source header is now in the 'SearchBar' toolbar that previously only contained the search filter selectors (if any). The search entry is wrapped in a GtkToolItem and integrated in this toolbar. Then the browser toggle is just moved at its new place in the ui description file. As a consequence the RBSourceHeader widget now derive from GtkHBox instead of GtkTable, the only reason being that GtkBin alone didn't work. It works almost fine, but I see 2 problems: * I don't know if it's very legal/safe to mess with the UI constructed by an UIManager. * The filter selectors buttons are now very big (text 'lost' in the button). And finally, the header take 100% width and the search entry takes the maximum space available. This can be changed if it causes problems.
this happened a while ago